Bug #233428 --> User defined notify sounds don't work. We were storing file paths instead of file urls for the custom sound url pref.

mail/components/prefwindow/content/pref-mailnews.js

@@ -84,7 +84,9 @@ function Browse()
   var ret = fp.show();
   if (ret == nsIFilePicker.returnOK) {
     var mailnewsSoundFileUrl = document.getElementById("mailnewsSoundFileUrl");
-    mailnewsSoundFileUrl.value = fp.file.path;
+
+    // convert the nsILocalFile into a nsIFile url 
+    mailnewsSoundFileUrl.value = fp.fileURL.spec;
   }
 
   onCustomWavInput();

mail/components/prefwindow/content/pref-mailnews.xul

@@ -125,7 +125,7 @@
       <vbox>
         <spacer flex="1"/>
         <hbox align="center">
-          <textbox flex="1" oninput="onCustomWavInput()" id="mailnewsSoundFileUrl" preftype="string"
+          <textbox readonly="true" flex="1" oninput="onCustomWavInput()" id="mailnewsSoundFileUrl" preftype="string"
                    prefstring="mail.biff.play_sound.url"/>
           <button id="browse" label="&browse.label;" filepickertitle="&browse.title;"
                   accesskey="&browse.accesskey;" oncommand="Browse()"/>