From 3cfad823cbfffb6fa44cbb26662dcea33b1f1dfa Mon Sep 17 00:00:00 2001 From: Benoit Jacob Date: Thu, 2 Sep 2010 13:59:54 -0400 Subject: [PATCH] Backed out changeset be48a89b9561. Asked for by Mossop and dietrich. --- .../extensions/content/extensions-content.js | 2 +- .../extensions/test/xpinstall/Makefile.in | 2 - .../browser_unsigned_trigger_iframe.js | 50 ------------------- .../test/xpinstall/installtrigger_frame.html | 29 ----------- 4 files changed, 1 insertion(+), 82 deletions(-) delete mode 100644 toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_trigger_iframe.js delete mode 100644 toolkit/mozapps/extensions/test/xpinstall/installtrigger_frame.html diff --git a/toolkit/mozapps/extensions/content/extensions-content.js b/toolkit/mozapps/extensions/content/extensions-content.js index 0f2f5b7c88b..32262753c07 100644 --- a/toolkit/mozapps/extensions/content/extensions-content.js +++ b/toolkit/mozapps/extensions/content/extensions-content.js @@ -250,7 +250,7 @@ function InstallTriggerManager() { InstallTriggerManager.prototype = { handleEvent: function handleEvent(aEvent) { - var window = aEvent.target.defaultView; + var window = aEvent.originalTarget.defaultView.content; // Need to make sure we are called on what we care about - // content windows. DOMWindowCreated is called on *all* HTMLDocuments, diff --git a/toolkit/mozapps/extensions/test/xpinstall/Makefile.in b/toolkit/mozapps/extensions/test/xpinstall/Makefile.in index da3810ca265..b65413bea67 100644 --- a/toolkit/mozapps/extensions/test/xpinstall/Makefile.in +++ b/toolkit/mozapps/extensions/test/xpinstall/Makefile.in @@ -46,7 +46,6 @@ include $(topsrcdir)/config/rules.mk _BROWSER_FILES = head.js \ browser_unsigned_url.js \ browser_unsigned_trigger.js \ - browser_unsigned_trigger_iframe.js \ browser_whitelist.js \ browser_whitelist2.js \ browser_whitelist3.js \ @@ -101,7 +100,6 @@ _BROWSER_FILES = head.js \ multipackage.xpi \ enabled.html \ installtrigger.html \ - installtrigger_frame.html \ startsoftwareupdate.html \ installchrome.html \ triggerredirect.html \ diff --git a/toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_trigger_iframe.js b/toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_trigger_iframe.js deleted file mode 100644 index e0422a5e601..00000000000 --- a/toolkit/mozapps/extensions/test/xpinstall/browser_unsigned_trigger_iframe.js +++ /dev/null @@ -1,50 +0,0 @@ -// ---------------------------------------------------------------------------- -// Test for bug 589598 - Ensure that installing through InstallTrigger -// works in an iframe in web content. - -function test() { - Harness.installConfirmCallback = confirm_install; - Harness.installEndedCallback = install_ended; - Harness.installsCompletedCallback = finish_test; - Harness.setup(); - - var pm = Services.perms; - pm.add(makeURI("http://example.com/"), "install", pm.ALLOW_ACTION); - - var triggers = encodeURIComponent(JSON.stringify({ - "Unsigned XPI": { - URL: TESTROOT + "unsigned.xpi", - IconURL: TESTROOT + "icon.png", - toString: function() { return this.URL; } - } - })); - gBrowser.selectedTab = gBrowser.addTab(); - gBrowser.loadURI(TESTROOT + "installtrigger_frame.html?" + triggers); -} - -function confirm_install(window) { - items = window.document.getElementById("itemList").childNodes; - is(items.length, 1, "Should only be 1 item listed in the confirmation dialog"); - is(items[0].name, "XPI Test", "Should have seen the name"); - is(items[0].url, TESTROOT + "unsigned.xpi", "Should have listed the correct url for the item"); - is(items[0].icon, TESTROOT + "icon.png", "Should have listed the correct icon for the item"); - is(items[0].signed, "false", "Should have listed the item as unsigned"); - return true; -} - -function install_ended(install, addon) { - install.cancel(); -} - -function finish_test(count) { - is(count, 1, "1 Add-on should have been successfully installed"); - - Services.perms.remove("example.com", "install"); - - var doc = gBrowser.contentWindow.frames[0].document; // Document of iframe - is(doc.getElementById("return").textContent, "true", "installTrigger in iframe should have claimed success"); - is(doc.getElementById("status").textContent, "0", "Callback in iframe should have seen a success"); - - gBrowser.removeCurrentTab(); - Harness.finish(); -} diff --git a/toolkit/mozapps/extensions/test/xpinstall/installtrigger_frame.html b/toolkit/mozapps/extensions/test/xpinstall/installtrigger_frame.html deleted file mode 100644 index 11af0f35f03..00000000000 --- a/toolkit/mozapps/extensions/test/xpinstall/installtrigger_frame.html +++ /dev/null @@ -1,29 +0,0 @@ - - - - - - - -InstallTrigger frame tests - - - - - - -

InstallTrigger tests

-

-

- -