Bug 98711: Fix misuses of string.Right(). r=jfrancis, sr=jst

editor/base/nsHTMLDataTransfer.cpp

@@ -1558,7 +1558,7 @@ nsresult nsHTMLEditor::CreateDOMFragmentFromPaste(nsIDOMNSRange *aNSRange,
     PRInt32 err, sep;
     sep = aInfoStr.FindChar((PRUnichar)',');
     aInfoStr.Left(numstr1, sep);
-    aInfoStr.Right(numstr2, sep+1);
+    aInfoStr.Right(numstr2, aInfoStr.Length() - (sep+1));
     *outRangeStartHint = numstr1.ToInteger(&err) + contextDepth;
     *outRangeEndHint   = numstr2.ToInteger(&err) + contextDepth;
   }

editor/libeditor/html/nsHTMLDataTransfer.cpp

@@ -1558,7 +1558,7 @@ nsresult nsHTMLEditor::CreateDOMFragmentFromPaste(nsIDOMNSRange *aNSRange,
     PRInt32 err, sep;
     sep = aInfoStr.FindChar((PRUnichar)',');
     aInfoStr.Left(numstr1, sep);
-    aInfoStr.Right(numstr2, sep+1);
+    aInfoStr.Right(numstr2, aInfoStr.Length() - (sep+1));
     *outRangeStartHint = numstr1.ToInteger(&err) + contextDepth;
     *outRangeEndHint   = numstr2.ToInteger(&err) + contextDepth;
   }

mailnews/news/src/nsNntpService.cpp

@@ -676,7 +676,7 @@ nsNntpService::SetUpNntpUrlForPosting(nsINntpUrl *nntpUrl, const char *newsgroup
       if (slashpos > 0 ) {
         // theRest is "host/group"
         theRest.Left(currentHost, slashpos);
-        theRest.Right(currentGroup, slashpos);
+        theRest.Right(currentGroup, theRest.Length() - slashpos);
       }
       else {
         // str is "group"

xpfe/appshell/src/nsUserInfoMac.cpp

@@ -94,7 +94,7 @@ nsUserInfo::GetDomain(char * *aDomain)
   if (atOffset != kNotFound)
   {
     nsCAutoString domainString;
-    tempString.Right(domainString, atOffset + 1);
+    tempString.Right(domainString, tempString.Length() - (atOffset + 1));
     *aDomain = domainString.ToNewCString();
     return NS_OK;
   }

xpfe/components/startup/src/nsUserInfoMac.cpp

@@ -94,7 +94,7 @@ nsUserInfo::GetDomain(char * *aDomain)
   if (atOffset != kNotFound)
   {
     nsCAutoString domainString;
-    tempString.Right(domainString, atOffset + 1);
+    tempString.Right(domainString, tempString.Length() - (atOffset + 1));
     *aDomain = domainString.ToNewCString();
     return NS_OK;
   }