diff --git a/webtools/tinderbox/showbuilds.cgi b/webtools/tinderbox/showbuilds.cgi index 468718c89ad..2dfccc76deb 100755 --- a/webtools/tinderbox/showbuilds.cgi +++ b/webtools/tinderbox/showbuilds.cgi @@ -23,8 +23,10 @@ require 'globals.pl'; require 'lloydcgi.pl'; require 'imagelog.pl'; require 'header.pl'; +require 'utils.pl'; $|=1; +$default_root = pickDefaultRepository(); # # show 12 hours by default @@ -231,14 +233,8 @@ sub display_build_table_row { my ($tt, $hour_color); $tt = &print_time($build_time_times->[$t]); - if( $tree2 ne ""){ - $qr = ""; - $er = ""; - } - else { - $qr = &query_ref( $td1, $build_time_times->[$t]); - $er = ""; - } + my ($qr) = ''; + my ($er) = ''; if ($build_time_times->[$t] % 7200 > 3600) { $hour_color = ""; @@ -250,6 +246,10 @@ sub display_build_table_row { if ($lasthour == $hour) { $tt =~ s/^.* //; } else { + if ($tree2 eq '') { + $qr = &query_ref( $td1, $build_time_times->[$t]); + $er = ""; + } $lasthour = $hour; } @@ -443,7 +443,11 @@ sub query_ref { my( $td, $mindate, $maxdate, $who ) = @_; my( $output ) = ''; - $output = "{cvs_module}&branch=$td->{cvs_branch}&cvsroot=$td->{cvs_root}&date=explicit&mindate=$mindate&maxdate=$maxdate"; + $output = "{cvs_module}"; + $output .= "&branch=$td->{cvs_branch}" if $td->{cvs_branch} ne 'HEAD'; + $output .= "&cvsroot=$td->{cvs_root}" if $td->{cvs_root} ne $default_root; + $output .= "&date=explicit&mindate=$mindate"; + $output .= "&maxdate=$maxdate" if $maxdate ne ''; $output .= "&who=$who" if $who ne ''; $output .= ">"; } @@ -540,7 +544,7 @@ function js_what_menu(d,noteid,logfile,errorparser,buildname,buildtime) { l = document.layers['popup']; l.document.write( "
" + - note_array[noteid] + + note[noteid] + "
"); l.document.close(); @@ -557,7 +561,10 @@ function js_what_menu(d,noteid,logfile,errorparser,buildname,buildtime) { return false; } -note_array = new Array(); +note = new Array(); +tree = new Array(); +name = new Array(); +err = new Array(); @@ -570,9 +577,9 @@ note_array = new Array(); ENDJS $script_str .= " -\n"; +$script_str .= "\n"; }