Bug 398724 Problems with floating all-day items; r=mvl, r=mschroeder

calendar/libical/src/libical/icaltime.c

@@ -396,7 +396,7 @@ struct icaltimetype icaltime_from_string(const char* str)
 	tt.zone = icaltimezone_get_utc_timezone();
 	tt.is_date = 0;
     } else if (size == 8) { /* A DATE */
-	tt.is_utc = 1;
+	tt.is_utc = 0;
 	tt.is_date = 1;
     } else { /* error */
 	goto FAIL;

calendar/test/unit/head_consts.js

@@ -44,3 +44,15 @@ function createDate(aYear, aMonth, aDay) {
     cd.isDate = true;
     return cd;
 }
+
+// branch support:
+if (typeof do_check_true != "function") {
+    do_check_true = function do_check_true(condition) {
+        do_check_eq(condition, true);
+    }
+}
+if (typeof do_check_false != "function") {
+    do_check_false = function do_check_false(condition) {
+        do_check_eq(condition, false);
+    }
+}

calendar/test/unit/test_datetime.js

@@ -77,4 +77,10 @@ function run_test() {
 
     cd.day += 1;
     do_check_eq(cd.timezoneOffset, 2*3600);
+
+    // Bug 398724 – Problems with floating all-day items
+    var event = Cc["@mozilla.org/calendar/event;1"].createInstance(Ci.calIEvent);
+    event.icalString = "BEGIN:VEVENT\nUID:45674d53-229f-48c6-9f3b-f2b601e7ae4d\nSUMMARY:New Event\nDTSTART;VALUE=DATE:20071003\nDTEND;VALUE=DATE:20071004\nEND:VEVENT";
+    do_check_eq(event.startDate.timezone, "floating");
+    do_check_eq(event.endDate.timezone, "floating");
 }

calendar/test/unit/test_ics_roundtrip.js

@@ -137,6 +137,7 @@ function run_test() {
     event = eventClass.createInstance(eventIID);
     event.icalString = "BEGIN:VEVENT\n" +
                        "UID:1\n" +
+                       "DTSTART:20070521T100000Z\n" +
                        "X-MAGIC:mymagicstring\n" +
                        "END:VEVENT";
     expectedProps = {

calendar/test/unit/test_recur.js

@@ -46,7 +46,8 @@ function run_test() {
                "RRULE:FREQ=WEEKLY;INTERVAL=1;COUNT=6;BYDAY=TH\n" +
                "DTSTART:20020402T114500\n" +
                "DTEND:20020402T124500\n",
-               ["20020404T114500", "20020411T114500", "20020418T114500",
+               ["20020402T114500", // DTSTART part of the resulting set
+                "20020404T114500", "20020411T114500", "20020418T114500",
                 "20020425T114500", "20020502T114500", "20020509T114500"]);
 
     // bug 353797: occurrences for repeating all day events should stay "all-day"