Win32 only - Bug 370126: Wrong value written to EditFlags by NSIS installer? r=sspitzer

browser/installer/windows/nsis/shared.nsh

@@ -385,6 +385,7 @@
   ${If} $2 == ""
     ${AddHandlerValues} "$0\gopher" "$1" "$8,0" "URL:Gopher Protocol" "true" "true"
   ${Else}
+    ReadRegStr $2 SHCTX "$0\gopher\shell\open\command" ""
     ClearErrors
     ${WordFind} "$2" "${FileMainEXE}" "E+1{" $R1
     ${Unless} ${Errors}

toolkit/mozapps/installer/windows/nsis/common.nsh

@@ -1663,10 +1663,14 @@ Exch $R9 ; exchange the new $R9 value with the top of the stack
       WriteRegStr SHCTX "$R4" "" "$R7"
       WriteRegStr SHCTX "$R4" "FriendlyTypeName" "$R7"
 
-      StrCmp "$R8" "true" 0 +4
+      StrCmp "$R8" "true" 0 +8
-      DeleteRegValue SHCTX "$R4" "EditFlags"
-      WriteRegBin SHCTX "$R4" "EditFlags" 2
       WriteRegStr SHCTX "$R4" "URL Protocol" ""
+      StrCpy $R3 ""
+      ClearErrors
+      ReadRegDWord $R3 SHCTX "$R4" "EditFlags"
+      StrCmp $R3 "" 0 +3 ; Only add EditFlags if a value doesn't exist
+      DeleteRegValue SHCTX "$R4" "EditFlags"
+      WriteRegDWord SHCTX "$R4" "EditFlags" 0x00000002
 
       StrCmp "$R9" "true" 0 +13
       WriteRegStr SHCTX "$R4\DefaultIcon" "" "$R6"