Bug 226232 DRefTool analysis for xul files

r=roc sr=roc

layout/xul/base/src/nsPopupSetFrame.cpp

@@ -351,6 +351,8 @@ nsPopupSetFrame::ShowPopup(nsIContent* aElementContent, nsIContent* aPopupConten
     entry = mPopupList->GetEntry(aPopupContent);
   if (!entry) {
     entry = new nsPopupFrameList(aPopupContent, mPopupList);
+    if (!entry)
+      return NS_ERROR_OUT_OF_MEMORY;
     mPopupList = entry;
   }
 
@@ -801,6 +803,8 @@ nsPopupSetFrame::AddPopupFrame(nsIFrame* aPopup)
     entry = mPopupList->GetEntry(content);
   if (!entry) {
     entry = new nsPopupFrameList(content, mPopupList);
+    if (!entry)
+      return NS_ERROR_OUT_OF_MEMORY;
     mPopupList = entry;
   }
   

layout/xul/base/src/nsRootBoxFrame.cpp

@@ -321,6 +321,9 @@ nsRootBoxFrame::AddTooltipSupport(nsIContent* aNode)
   // it will add itself to, and destroyed when those targets
   // are destroyed
   nsXULTooltipListener* listener = new nsXULTooltipListener();
+  if (!listener)
+    return NS_ERROR_OUT_OF_MEMORY;
+
   listener->Init(aNode, this);
   return NS_OK;
 }

layout/xul/base/src/nsSplitterFrame.cpp

@@ -188,7 +188,6 @@ nsSplitterFrameInner::GetResizeBefore()
                                 nsXULAtoms::resizebefore, value);
   if (value.Equals(NS_LITERAL_STRING("farthest")))
     return Farthest;
-    else
   return Closest;
 }
 
@@ -206,9 +205,8 @@ nsSplitterFrameInner::GetResizeAfter()
                                 nsXULAtoms::resizeafter, value);
   if (value.Equals(NS_LITERAL_STRING("farthest")))
     return Farthest;
-    else if (value.Equals(NS_LITERAL_STRING("grow")))
+  if (value.Equals(NS_LITERAL_STRING("grow")))
     return Grow;
-    else 
   return Closest;
 }
 
@@ -220,11 +218,9 @@ nsSplitterFrameInner::GetState()
                                 nsXULAtoms::state, value);
   if (value.Equals(NS_LITERAL_STRING("dragging")))
     return Dragging;
-    else if (value.Equals(NS_LITERAL_STRING("collapsed")))
+  if (value.Equals(NS_LITERAL_STRING("collapsed")))
     return Collapsed;
-	else 
   return Open;
-
 }
 
 //
@@ -248,21 +244,19 @@ NS_NewSplitterFrame ( nsIPresShell* aPresShell, nsIFrame** aNewFrame )
   
 } // NS_NewSplitterFrame
 
-nsSplitterFrame::nsSplitterFrame(nsIPresShell* aPresShell):nsBoxFrame(aPresShell)
+nsSplitterFrame::nsSplitterFrame(nsIPresShell* aPresShell)
+: nsBoxFrame(aPresShell),
+  mInner(0)
 {
-  mInner = new nsSplitterFrameInner(this);
-  mInner->AddRef();
-  mInner->mChildInfosAfter = nsnull;
-  mInner->mChildInfosBefore = nsnull;
-  mInner->mState = nsSplitterFrameInner::Open;
-  mInner->mDragging = PR_FALSE;
 }
 
 nsSplitterFrame::~nsSplitterFrame()
 {
+  if (mInner) {
     mInner->RemoveListener();
     mInner->Release();
   }
+}
 
 
 //
@@ -324,6 +318,16 @@ nsSplitterFrame::Init(nsIPresContext*  aPresContext,
               nsStyleContext*  aContext,
               nsIFrame*        aPrevInFlow)
 {
+  NS_ENSURE_FALSE(mInner, NS_ERROR_ALREADY_INITIALIZED);
+  mInner = new nsSplitterFrameInner(this);
+  if (!mInner)
+    return NS_ERROR_OUT_OF_MEMORY;
+
+  mInner->AddRef();
+  mInner->mChildInfosAfter = nsnull;
+  mInner->mChildInfosBefore = nsnull;
+  mInner->mState = nsSplitterFrameInner::Open;
+  mInner->mDragging = PR_FALSE;
 /* make it real time drag for now due to problems
   nsILookAndFeel* lookAndFeel;
   if (NS_SUCCEEDED(nsComponentManager::CreateInstance(kLookAndFeelCID, nsnull, NS_GET_IID(nsILookAndFeel), (void**)&lookAndFeel))) {
@@ -474,7 +478,6 @@ nsSplitterFrame::HandleEvent(nsIPresContext* aPresContext,
                                       nsGUIEvent* aEvent,
                                       nsEventStatus* aEventStatus)
 {
-
   switch (aEvent->message) {
     case NS_MOUSE_MOVE: 
       mInner->MouseDrag(aPresContext, aEvent);
@@ -510,7 +513,6 @@ nsSplitterFrameInner::MouseUp(nsIPresContext* aPresContext, nsGUIEvent* aEvent)
     }
 
     //printf("MouseUp\n");
-
   }
 }
 
@@ -598,7 +600,6 @@ nsSplitterFrameInner::MouseDrag(nsIPresContext* aPresContext, nsGUIEvent* aEvent
           if (GetCollapseDirection() == After) 
           {
             mOuter->mContent->SetAttr(kNameSpaceID_None, nsXULAtoms::state, NS_LITERAL_STRING("collapsed"), PR_TRUE);
-                           
           }
 
         } else if (oldPos < 0 && oldPos < pos)
@@ -607,27 +608,20 @@ nsSplitterFrameInner::MouseDrag(nsIPresContext* aPresContext, nsGUIEvent* aEvent
           if (GetCollapseDirection() == Before) 
           {
             mOuter->mContent->SetAttr(kNameSpaceID_None, nsXULAtoms::state, NS_LITERAL_STRING("collapsed"), PR_TRUE);
-                         
           }
         }
-                
       }
     } else {
       // if we are not in a collapsed position and we are not dragging make sure
       // we are dragging.
       if (currentState != Dragging)
         mOuter->mContent->SetAttr(kNameSpaceID_None, nsXULAtoms::state, NS_LITERAL_STRING("dragging"), PR_TRUE);
-
       if (realTimeDrag)
         AdjustChildren(aPresContext);
       else
         MoveSplitterBy(aPresContext, pos);
-
     }
 
-
-
-
     // printf("----- resize ----- ");
     /*
       for (i=0; i < mChildInfosBeforeCount; i++) 
@@ -1018,7 +1012,6 @@ nsSplitterFrameInner::UpdateState()
     }
   }
   mState = newState;
-  
 }
 
 void
@@ -1070,7 +1063,6 @@ else {
     nsBoxLayoutState state(aPresContext);
     mOuter->MarkDirty(state);
   }
-
 }
 
 void

layout/xul/base/src/nsTextBoxFrame.cpp

@@ -157,7 +157,6 @@ nsTextBoxFrame::nsTextBoxFrame(nsIPresShell* aShell):nsLeafBoxFrame(aShell), mCr
 
 nsTextBoxFrame::~nsTextBoxFrame()
 {
-    if (mAccessKeyInfo)
     delete mAccessKeyInfo;
 }
 
@@ -733,8 +732,11 @@ nsTextBoxFrame::UpdateAccessIndex()
                 mAccessKeyInfo = nsnull;
             }
         } else {
-            if (!mAccessKeyInfo)
+            if (!mAccessKeyInfo) {
                 mAccessKeyInfo = new nsAccessKeyInfo();
+                if (!mAccessKeyInfo)
+                    return;
+            }
 
             nsAString::const_iterator start, end;