From 59972d5798cea71bc72f3fdbde9ec4075f3291b8 Mon Sep 17 00:00:00 2001 From: "benjamin%smedbergs.us" Date: Tue, 18 Jul 2006 14:45:36 +0000 Subject: [PATCH] Removes an unnecessary transaction in the QueryFolderChildren() function that was causing an incorrect return value. bug=328364 r=brettw@gmail.com Original committer: annie.sullivan%gmail.com Original revision: 1.48 Original date: 2006/02/23 22:18:34 --- toolkit/components/places/src/nsNavBookmarks.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/toolkit/components/places/src/nsNavBookmarks.cpp b/toolkit/components/places/src/nsNavBookmarks.cpp index b817de51843..ef94f32ae25 100644 --- a/toolkit/components/places/src/nsNavBookmarks.cpp +++ b/toolkit/components/places/src/nsNavBookmarks.cpp @@ -1371,8 +1371,6 @@ nsNavBookmarks::QueryFolderChildren(PRInt64 aFolderId, nsNavHistoryQueryOptions *aOptions, nsCOMArray *aChildren) { - mozStorageTransaction transaction(DBConn(), PR_FALSE); - nsresult rv; mozStorageStatementScoper scope(mDBGetChildren); @@ -1421,7 +1419,7 @@ nsNavBookmarks::QueryFolderChildren(PRInt64 aFolderId, NS_ENSURE_TRUE(aChildren->AppendObject(node), NS_ERROR_OUT_OF_MEMORY); } - return transaction.Commit(); + return NS_OK; } PRInt32