From 62e69790b7b41403cc46a4b10f8183d4b2d61c22 Mon Sep 17 00:00:00 2001 From: Christopher Henderson Date: Sun, 21 Feb 2010 16:06:20 -0500 Subject: [PATCH] Bug 541743 - Closing two tabs from yelp.com in rapid succession crashes Camino [@ nsCOMPtr_base::assign_from_qi(nsQueryInterface, nsID const&) | nsDocShell::FirePageHideNotification(int) ] [@ nsDocShell::FirePageHideNotification(int) ], so hold a strong ref to the docshell. r=bz --- embedding/browser/webBrowser/nsWebBrowser.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/embedding/browser/webBrowser/nsWebBrowser.cpp b/embedding/browser/webBrowser/nsWebBrowser.cpp index 02946d04aaf..774e3e2440b 100644 --- a/embedding/browser/webBrowser/nsWebBrowser.cpp +++ b/embedding/browser/webBrowser/nsWebBrowser.cpp @@ -1600,6 +1600,7 @@ NS_IMETHODIMP nsWebBrowser::ScrollByPages(PRInt32 aNumPages) NS_IMETHODIMP nsWebBrowser::SetDocShell(nsIDocShell* aDocShell) { + nsCOMPtr kungFuDeathGrip(mDocShell); if(aDocShell) { NS_ENSURE_TRUE(!mDocShell, NS_ERROR_FAILURE);