Bug 653310 - Always put a dumpID property on ipc:content-shutdown notification property bags. r=cjones

This commit is contained in:
Cameron McCormack 2011-04-29 10:03:40 +12:00
Родитель 015c0d2cba
Коммит 6d2b2b8c97
2 изменённых файлов: 3 добавлений и 4 удалений

Просмотреть файл

@ -284,10 +284,9 @@ ContentParent::ActorDestroy(ActorDestroyReason why)
TakeMinidump(getter_AddRefs(crashDump)) &&
CrashReporter::GetIDFromMinidump(crashDump, dumpID);
if (!dumpID.IsEmpty()) {
props->SetPropertyAsAString(NS_LITERAL_STRING("dumpID"),
dumpID);
props->SetPropertyAsAString(NS_LITERAL_STRING("dumpID"), dumpID);
if (!dumpID.IsEmpty()) {
CrashReporter::AnnotationTable notes;
notes.Init();
notes.Put(NS_LITERAL_CSTRING("ProcessType"), NS_LITERAL_CSTRING("content"));

Просмотреть файл

@ -19,7 +19,7 @@
'Subject implements nsIPropertyBag2.');
if ('nsICrashReporter' in Components.interfaces) {
ok(subject.getPropertyAsAString('dumpID'), "dumpID is present");
ok(subject.getPropertyAsAString('dumpID'), "dumpID is present and not an empty string");
}
Services.obs.removeObserver(crashObserver, 'ipc:content-shutdown');