updated README and fixed 3484 (make in strings const)

xpcom/tools/xpidl/README

@@ -1,8 +1,8 @@
 Wed Dec  2 14:35:41 EST 1998
 
 xpidl depends on Andrew Veliath and Elliot Lee's libIDL, a part of the
-GNOME ORBit C ORB.  We currently require libIDL >= 0.5.8, which in turn
-requires glib >= 1.1.7.
+GNOME ORBit C ORB.  We currently require libIDL >= 0.6.1, which in turn
+requires glib >= 1.2.0.
 
 libIDL builds for Linux and Win32 can be found, along with source tarballs,
 at http://www.rpi.edu/~veliaa/libIDL/, and Win32 users will need glib 1.1 and

xpcom/tools/xpidl/xpidl_header.c

@@ -346,13 +346,24 @@ xpcom_param(TreeState *state)
     IDL_tree param = state->tree;
     state->tree = IDL_PARAM_DCL(param).param_type_spec;
 
+    /* in string and in wstring are const */
+    if (IDL_PARAM_DCL(param).attr == IDL_PARAM_IN &&
+        (IDL_NODE_TYPE(state->tree) == IDLN_TYPE_STRING ||
+         IDL_NODE_TYPE(state->tree) == IDLN_TYPE_WIDE_STRING))
+        fputs("const ", state->file);
+
     if (!xpcom_type(state))
         return FALSE;
-    fprintf(state->file, "%s%s",
-            STARRED_TYPE(state->tree)  ? "" : " ",
-            IDL_PARAM_DCL(param).attr == IDL_PARAM_IN ? "" : "*");
-    fprintf(state->file, "%s",
-            IDL_IDENT(IDL_PARAM_DCL(param).simple_declarator).str);
+
+    /* unless the type ended in a *, add a space */
+    if (!STARRED_TYPE(state->tree))
+        fputc(' ', state->file);
+
+    /* out and inout params get a bonus *! */
+    if (IDL_PARAM_DCL(param).attr != IDL_PARAM_IN)
+        fputc('*', state->file);
+
+    fputs(IDL_IDENT(IDL_PARAM_DCL(param).simple_declarator).str, state->file);
     return TRUE;
 }
 

xpcom/typelib/xpidl/README

@@ -1,8 +1,8 @@
 Wed Dec  2 14:35:41 EST 1998
 
 xpidl depends on Andrew Veliath and Elliot Lee's libIDL, a part of the
-GNOME ORBit C ORB.  We currently require libIDL >= 0.5.8, which in turn
-requires glib >= 1.1.7.
+GNOME ORBit C ORB.  We currently require libIDL >= 0.6.1, which in turn
+requires glib >= 1.2.0.
 
 libIDL builds for Linux and Win32 can be found, along with source tarballs,
 at http://www.rpi.edu/~veliaa/libIDL/, and Win32 users will need glib 1.1 and

xpcom/typelib/xpidl/xpidl_header.c

@@ -346,13 +346,24 @@ xpcom_param(TreeState *state)
     IDL_tree param = state->tree;
     state->tree = IDL_PARAM_DCL(param).param_type_spec;
 
+    /* in string and in wstring are const */
+    if (IDL_PARAM_DCL(param).attr == IDL_PARAM_IN &&
+        (IDL_NODE_TYPE(state->tree) == IDLN_TYPE_STRING ||
+         IDL_NODE_TYPE(state->tree) == IDLN_TYPE_WIDE_STRING))
+        fputs("const ", state->file);
+
     if (!xpcom_type(state))
         return FALSE;
-    fprintf(state->file, "%s%s",
-            STARRED_TYPE(state->tree)  ? "" : " ",
-            IDL_PARAM_DCL(param).attr == IDL_PARAM_IN ? "" : "*");
-    fprintf(state->file, "%s",
-            IDL_IDENT(IDL_PARAM_DCL(param).simple_declarator).str);
+
+    /* unless the type ended in a *, add a space */
+    if (!STARRED_TYPE(state->tree))
+        fputc(' ', state->file);
+
+    /* out and inout params get a bonus *! */
+    if (IDL_PARAM_DCL(param).attr != IDL_PARAM_IN)
+        fputc('*', state->file);
+
+    fputs(IDL_IDENT(IDL_PARAM_DCL(param).simple_declarator).str, state->file);
     return TRUE;
 }