mozilla
/
pjs
зеркало из https://github.com/mozilla/pjs.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 395974 - "our storage unit tests cause "WARNING: Unsafe use of LIKE detected!" warnings" (Bind the value to avoid WARNING) [p=ondrej@allpeers.com (Ondrej Brablc) r=sdwilsh]

This commit is contained in:
reed%reedloden.com 2008-03-08 11:25:41 +00:00
Родитель 8fd80a5d60
Коммит 747db36f04
1 изменённых файлов: 16 добавлений и 8 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

24
storage/test/unit/test_like.js
Просмотреть файл

@ -104,7 +104,8 @@ function test_count()
function test_like_1() function test_like_1()
{ {
var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE 'abc';"); var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE ?;");
stmt.bindStringParameter(0, 'abc');
var solutions = ["abc", "ABC"]; var solutions = ["abc", "ABC"];
do_check_true(stmt.executeStep()); do_check_true(stmt.executeStep());
do_check_true(solutions.indexOf(stmt.getString(0)) != -1); do_check_true(solutions.indexOf(stmt.getString(0)) != -1);
@ -117,7 +118,8 @@ function test_like_1()
function test_like_2() function test_like_2()
{ {
var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE 'ABC';"); var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE ?;");
stmt.bindStringParameter(0, 'ABC');
var solutions = ["abc", "ABC"]; var solutions = ["abc", "ABC"];
do_check_true(stmt.executeStep()); do_check_true(stmt.executeStep());
do_check_true(solutions.indexOf(stmt.getString(0)) != -1); do_check_true(solutions.indexOf(stmt.getString(0)) != -1);
@ -130,7 +132,8 @@ function test_like_2()
function test_like_3() function test_like_3()
{ {
var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE 'aBc';"); var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE ?;");
stmt.bindStringParameter(0, 'aBc');
var solutions = ["abc", "ABC"]; var solutions = ["abc", "ABC"];
do_check_true(stmt.executeStep()); do_check_true(stmt.executeStep());
do_check_true(solutions.indexOf(stmt.getString(0)) != -1); do_check_true(solutions.indexOf(stmt.getString(0)) != -1);
@ -143,7 +146,8 @@ function test_like_3()
function test_like_4() function test_like_4()
{ {
var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE 'abc%';"); var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE ?;");
stmt.bindStringParameter(0, 'abc%');
var solutions = ["abc", "abcd", "ABC", "ABC abc xyz"]; var solutions = ["abc", "abcd", "ABC", "ABC abc xyz"];
do_check_true(stmt.executeStep()); do_check_true(stmt.executeStep());
do_check_true(solutions.indexOf(stmt.getString(0)) != -1); do_check_true(solutions.indexOf(stmt.getString(0)) != -1);
@ -160,7 +164,8 @@ function test_like_4()
function test_like_5() function test_like_5()
{ {
var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE 'a_c';"); var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE ?;");
stmt.bindStringParameter(0, 'a_c');
var solutions = ["abc", "ABC"]; var solutions = ["abc", "ABC"];
do_check_true(stmt.executeStep()); do_check_true(stmt.executeStep());
do_check_true(solutions.indexOf(stmt.getString(0)) != -1); do_check_true(solutions.indexOf(stmt.getString(0)) != -1);
@ -173,7 +178,8 @@ function test_like_5()
function test_like_6() function test_like_6()
{ {
var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE 'ab%d';"); var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE ?;");
stmt.bindStringParameter(0, 'ab%d');
var solutions = ["abcd", "abd"]; var solutions = ["abcd", "abd"];
do_check_true(stmt.executeStep()); do_check_true(stmt.executeStep());
do_check_true(solutions.indexOf(stmt.getString(0)) != -1); do_check_true(solutions.indexOf(stmt.getString(0)) != -1);
@ -186,7 +192,8 @@ function test_like_6()
function test_like_7() function test_like_7()
{ {
var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE 'a_c%';"); var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE ?;");
stmt.bindStringParameter(0, 'a_c%');
var solutions = ["abc", "abcd", "ABC", "ABC abc xyz"]; var solutions = ["abc", "abcd", "ABC", "ABC abc xyz"];
do_check_true(stmt.executeStep()); do_check_true(stmt.executeStep());
do_check_true(solutions.indexOf(stmt.getString(0)) != -1); do_check_true(solutions.indexOf(stmt.getString(0)) != -1);
@ -203,7 +210,8 @@ function test_like_7()
function test_like_8() function test_like_8()
{ {
var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE '%bcd';"); var stmt = createStatement("SELECT x FROM t1 WHERE x LIKE ?;");
stmt.bindStringParameter(0, '%bcd');
var solutions = ["abcd", "bcd"]; var solutions = ["abcd", "bcd"];
do_check_true(stmt.executeStep()); do_check_true(stmt.executeStep());
do_check_true(solutions.indexOf(stmt.getString(0)) != -1); do_check_true(solutions.indexOf(stmt.getString(0)) != -1);