Bug 325316 - [p=reed r=bear]

webtools/bonsai/Makefile.in

@@ -36,54 +36,57 @@ CO=@CO@
 RCSDIFF=@RCSDIFF@
 CVSGRAPH=@CVSGRAPH@
 
-FILES = CGI.pl			\
+FILES =		CGI.pl			\
-	addcheckin.pl		\
+		addcheckin.pl		\
-	admin.cgi		\
+		adminfuncs.pl		\
-	adminfuncs.pl		\
+		adminmail.pl		\
-	adminmail.pl		\
+		bonsai.gif		\
-	closemessage		\
+		bonsai.ico		\
-	contacthelp.html	\
+		closemessage		\
-	countcheckins.cgi	\
+		contacthelp.html	\
-	createlegaldirs.pl	\
+		createlegaldirs.pl	\
-	cvsblame.cgi		\
+		cvsblame.pl		\
-	cvsblame.pl		\
+		cvsquery.pl		\
-	cvsguess.cgi		\
+		cvsregexp.html		\
-	cvsgraph.cgi		\
+		defparams.pl		\
-	cvslog.cgi		\
+		dolog.pl		\
-	cvsquery.cgi		\
+		get_line.pl		\
-	cvsquery.pl		\
+		globals.pl		\
-	cvsqueryform.cgi	\
+		handleAdminMail.pl	\
-	cvsregexp.html		\
+		handleCheckinMail.pl	\
-	cvsview2.cgi		\
+		index.html		\
-	defparams.pl		\
+		modules.pl		\
-	doadmin.cgi		\
+		openmessage
-	doeditcheckin.cgi	\
+
-	doeditmessage.cgi	\
+EXECFILES =	admin.cgi		\
-	doeditparams.cgi	\
+		countcheckins.cgi	\
-	doeditwhiteboard.cgi	\
+		cvsblame.cgi		\
-	dolog.pl		\
+		cvsguess.cgi		\
-	dotweak.cgi		\
+		cvsgraph.cgi		\
-	editcheckin.cgi		\
+		cvslog.cgi		\
-	editmessage.cgi		\
+		cvsquery.cgi		\
-	editparams.cgi		\
+		cvsqueryform.cgi	\
-	editwhiteboard.cgi	\
+		cvsview2.cgi		\
-	get_line.pl		\
+		doadmin.cgi		\
-	globals.pl		\
+		doeditcheckin.cgi	\
-	handleAdminMail.pl	\
+		doeditmessage.cgi	\
-	handleCheckinMail.pl	\
+		doeditparams.cgi	\
-	index.html		\
+		doeditwhiteboard.cgi	\
-	maketables.sh		\
+		dotweak.cgi		\
-	moduleanalyse.cgi	\
+		editcheckin.cgi		\
-	modules.pl		\
+		editmessage.cgi		\
-	multidiff.cgi		\
+		editparams.cgi		\
-	openmessage		\
+		editwhiteboard.cgi	\
-	rebuildcvshistory.cgi	\
+		maketables.sh		\
-	repophook.cgi		\
+		moduleanalyse.cgi	\
-	rview.cgi		\
+		multidiff.cgi		\
-	showcheckins.cgi	\
+		rebuildcvshistory.cgi	\
-	switchtree.cgi		\
+		repophook.cgi		\
-	toplevel.cgi		\
+		rview.cgi		\
-	viewold.cgi
+		showcheckins.cgi	\
+		switchtree.cgi		\
+		toplevel.cgi		\
+		viewold.cgi
 
 all: treeconfig.pl params
 
@@ -104,11 +107,12 @@ install: all
 	  echo Installing $$I && \
           sed -e s#/usr/bin/perl#$(PERL)#g \
               $$I > $(PREFIX)/$$I && \
-	chmod 755 $(PREFIX)/$$I; done
+	  chmod 644 $(PREFIX)/$$I; done
-	cp bonsai.gif $(PREFIX)
+	@for I in $(EXECFILES); do \
-	chmod 644 $(PREFIX)/bonsai.gif
+	  echo Installing CGI file $$I && \
-	cp bonsai.ico $(PREFIX)
+          sed -e s#/usr/bin/perl#$(PERL)#g \
-	chmod 644 $(PREFIX)/bonsai.ico
+              $$I > $(PREFIX)/$$I && \
+	  chmod 755 $(PREFIX)/$$I; done
 	-mkdir -p $(PREFIX)/data && chmod 777 $(PREFIX)/data
 	cp htaccess-dist $(PREFIX)/data/.htaccess
 	chmod 644 $(PREFIX)/data/.htaccess

webtools/bonsai/globals.pl

@@ -620,7 +620,7 @@ sub LoadDirList {
      if (-f $modules) {
           if ((!(-f $dirsfile)) ||
               ((-M $dirsfile) > (-M $modules))) {
-               system("./createlegaldirs.pl", $::TreeID);
+               system("/usr/bin/perl", "createlegaldirs.pl", $::TreeID);
           }
      }
 

webtools/bonsai/handleAdminMail.pl

@@ -46,7 +46,7 @@ while (<STDIN>) {
 }
 close(FILE);
 chmod(0666, $filename);
-system("./adminmail.pl", $filename);
+system("/usr/bin/perl", "-w", "adminmail.pl", $filename);
 
 # unlink($filename);
 

webtools/bonsai/handleCheckinMail.pl

@@ -46,7 +46,7 @@ while (<STDIN>) {
 }
 close(FILE);
 chmod(0666, $filename);
-system("./addcheckin.pl",  $filename);
+system("/usr/bin/perl", "-w", "addcheckin.pl",  $filename);
 
 unlink($filename);
 

webtools/bonsai/processqueue.pl

@@ -32,7 +32,7 @@
 $inprocess = "data/queue/processing-$$";
 
 foreach $file (sort(glob("data/queue/*.q"))) {
-    rename $file, $inprocess || die "Couldn't rename queue file.";
+    rename($file, $inprocess) || die "Couldn't rename queue file.";
-    system "./dolog.pl < $inprocess";
+    system("/usr/bin/perl", "-T", "dolog.pl", "<", "$inprocess");
-    rename $inprocess, "$file.done";
+    rename($inprocess, "$file.done");
 }