From 8039026b667740db5668fa3875cf2a71c2774454 Mon Sep 17 00:00:00 2001
From: "neil%parkwaycc.co.uk" <neil%parkwaycc.co.uk>
Date: Fri, 11 Jun 2004 11:48:14 +0000
Subject: [PATCH] Bug 245325 Really fix addressbook's abuse of menulists
 r/sr=mscott

---
 .../addrbook/content/abContactsPanel.js       |  12 +-
 .../addrbook/content/abContactsPanel.xul      |   2 +-
 .../prefs/resources/content/pref-directory.js | 107 ++++--------------
 .../resources/content/addressbook-panel.js    |  32 +-----
 .../resources/content/addressbook-panel.xul   |   4 +-
 5 files changed, 32 insertions(+), 125 deletions(-)

diff --git a/mail/components/addrbook/content/abContactsPanel.js b/mail/components/addrbook/content/abContactsPanel.js
index dd97f63c4bb..974d7831c9b 100644
--- a/mail/components/addrbook/content/abContactsPanel.js
+++ b/mail/components/addrbook/content/abContactsPanel.js
@@ -87,7 +87,7 @@ var gAddressBookPanelAbListener = {
       // if so, select the person addressbook (it can't be removed)
       if (directory == GetAbView().directory) {
           var abPopup = document.getElementById('addressbookList');
-          abPopup.setAttribute("selectedAB", kPersonalAddressbookURI);
+          abPopup.value = kPersonalAddressbookURI;
           LoadPreviouslySelectedAB();
       } 
     }
@@ -115,6 +115,9 @@ var gAddressBookPanelAbListener = {
 function LoadPreviouslySelectedAB()
 {
   var abPopup = document.getElementById('addressbookList');
+  var value = abPopup.value || kPersonalAddressbookURI;
+  abPopup.selectedItem = null;
+  abPopup.value = value;
   ChangeDirectoryByURI(abPopup.selectedItem.id);
 }
 
@@ -135,13 +138,6 @@ function AbPanelLoad()
   gSearchInput = document.getElementById("searchInput");
 }
 
-
-function AbPanelOnChange(event)
-{
-  var abPopup = document.getElementById('addressbookList');
-  abPopup.setAttribute("selectedAB", abPopup.value);
-}
-
 function AbPanelUnload()
 {
   var addrbookSession = Components.classes["@mozilla.org/addressbook/services/session;1"].getService().QueryInterface(Components.interfaces.nsIAddrBookSession);
diff --git a/mail/components/addrbook/content/abContactsPanel.xul b/mail/components/addrbook/content/abContactsPanel.xul
index 8e3c3c4cefc..0a06aab8520 100644
--- a/mail/components/addrbook/content/abContactsPanel.xul
+++ b/mail/components/addrbook/content/abContactsPanel.xul
@@ -66,7 +66,7 @@
     <label value="&addressbookPicker.label;"/> 
     <hbox id="panel-bar" class="toolbar" align="center">
       <menulist id="addressbookList" 
-                oncommand="DirPaneSelectionChangeMenulist(); AbPanelOnChange(event)" flex="1"
+                oncommand="DirPaneSelectionChangeMenulist();" flex="1"
                 persist="value">
         <menupopup id="addressbookList-menupopup" 
                    datasources="rdf:addressdirectory" 
diff --git a/mailnews/addrbook/prefs/resources/content/pref-directory.js b/mailnews/addrbook/prefs/resources/content/pref-directory.js
index a682dcef6c9..5f9513c9278 100644
--- a/mailnews/addrbook/prefs/resources/content/pref-directory.js
+++ b/mailnews/addrbook/prefs/resources/content/pref-directory.js
@@ -93,19 +93,11 @@ function setupDirectoriesList()
   var directoriesList = document.getElementById("directoriesList");
   var directoryServer = 
         document.getElementById("identity.directoryServer").getAttribute('value');
-  try {
-    var directoryServerString = gPrefInt.getComplexValue(directoryServer + ".description",
-                                                         Components.interfaces.nsISupportsString).data;
-  }
-  catch(ex) {}
-  if (directoryServerFlag || !directoryServerString) {
+  if (directoryServerFlag) {
     document.getElementById("identity.directoryServer").setAttribute("value", "");
     directoryServer = "";
-    var addressBookBundle = document.getElementById("bundle_addressBook");
-    directoryServerString = addressBookBundle.getString("directoriesListItemNone");
   }
   directoriesList.value = directoryServer;
-  directoriesList.label = directoryServerString;
   gFromGlobalPref = false;
 }
 
@@ -200,27 +192,11 @@ function LoadDirectories(popup)
       if (gRefresh) {  
       // gRefresh is true if user edits, removes or adds a directory.
         directoriesList =  document.getElementById("directoriesList");
-        directoryDescription = null;
-        if(directoriesList.value != "") {
-          // make sure the selected directory still exists
-          try {
-            directoryDescription = gPrefInt.
-                     getComplexValue(directoriesList.value + ".description",
-                                     Components.interfaces.nsISupportsString).data;
-          }
-          catch (ex) {}
-        }
-        if(!directoryDescription) {
-          // if selected directory doesn't exist, set it to none
+        var value = directoriesList.value;
+        directoriesList.selectedItem = null;
+        directoriesList.value = value;
+        if (!directoriesList.selectedItem)
           directoriesList.value = "";
-          addressBookBundle = document.getElementById("bundle_addressBook");
-          directoriesList.label = addressBookBundle.
-                          getString("directoriesListItemNone");
-        }
-        else {
-          directoriesList.label = directoryDescription;
-          directoriesList.value = directoriesList.value;
-        }
       }
     }
     if (popup && gFromGlobalPref) {
@@ -228,72 +204,31 @@ function LoadDirectories(popup)
       directoriesList =  document.getElementById("directoriesList");
       if (gRefresh) {
         // gRefresh is true if user edits, removes or adds a directory.
-        directoryDescription = null;
-        if(directoriesList.label != "") {
-          // make sure the selected directory still exists
-          try {
-            directoryDescription = gPrefInt.
-                     getComplexValue(directoriesList.value + ".description",
-                                     Components.interfaces.nsISupportsString).data;
-          }
-          catch (ex) {}
-        }
-        if(!directoryDescription) {
-          // if selected directory doesn't exist, 
-          // set it the first one in the list of directories 
-          // if we have  atleast one directory.
-          // or else set it to ""
-          if (gAvailDirectories.length) {
-            directoriesList.label = gAvailDirectories[0].label;
-            directoriesList.value = gAvailDirectories[0].value;
-            directoriesList.removeAttribute("disabled");
-          }
-          else {
-            directoriesList.label = "";
-            directoriesList.value = null;
-            directoriesList.setAttribute("disabled", true);
-          }
-        }
-        else {
-          directoriesList.label = directoryDescription;
-          directoriesList.value = directoriesList.value;
+        var value = directoriesList.value;
+        directoriesList.selectedItem = null;
+        directoriesList.value = value;
+        if (!directoriesList.selectedItem)
+          directoriesList.selectedIndex = 0;
+        if (!directoriesList.selectedItem) {
+          directoriesList.value = "";
+          directoriesList.disabled = true;
         }
+        else if (!gPrefInt.prefIsLocked("ldap_2.autoComplete.directoryServer"))
+          directoriesList.disabled = false;
         return;
       }
       var pref_string_title = "ldap_2.autoComplete.directoryServer";
       try {
         var directoryServer = gPrefInt.getCharPref(pref_string_title);
+        directoriesList.value = directoryServer;
+        if (!directoriesList.selectedItem)
+          directoriesList.selectedIndex = 0;
+        if (!directoriesList.selectedItem)
+          directoriesList.value = "";
       }
       catch (ex)
       {
-        directoryServer = "";
-      }
-      if (directoryServer != "")
-      {
-        pref_string_title = directoryServer + ".description";
-        try {
-          description = gPrefInt.getComplexValue(pref_string_title,
-                                                 Components.interfaces.nsISupportsString).data;
-        }
-        catch (ex) {
-          description = "";
-        } 
-      }
-      if ((directoryServer != "") && (description != ""))
-      {
-        directoriesList.label = description;
-        directoriesList.value = directoryServer;
-      }
-      else if(gAvailDirectories.length) {
-         directoriesList.label = gAvailDirectories[0].label;
-         directoriesList.value = gAvailDirectories[0].value;
-         gPrefInt.setCharPref("ldap_2.autoComplete.directoryServer", 
-                              gAvailDirectories[0].value);
-      }
-      else {
-        directoriesList.label = "";
-        directoriesList.value = null;
-        gPrefInt.setCharPref("ldap_2.autoComplete.directoryServer", "");
+        directoriesList.selectedItem = null;
       }
     }
   }
diff --git a/mailnews/addrbook/resources/content/addressbook-panel.js b/mailnews/addrbook/resources/content/addressbook-panel.js
index e9e7f12e244..513414aa6b7 100644
--- a/mailnews/addrbook/resources/content/addressbook-panel.js
+++ b/mailnews/addrbook/resources/content/addressbook-panel.js
@@ -53,7 +53,7 @@ var gAddressBookPanelAbListener = {
       // if so, select the person addressbook (it can't be removed)
       if (directory == GetAbView().directory) {
           var abPopup = document.getElementById('addressbookList');
-          abPopup.setAttribute("selectedAB", kPersonalAddressbookURI);
+          abPopup.value = kPersonalAddressbookURI;
           LoadPreviouslySelectedAB();
       } 
     }
@@ -81,26 +81,9 @@ var gAddressBookPanelAbListener = {
 function LoadPreviouslySelectedAB()
 {
   var abPopup = document.getElementById('addressbookList');
-  if ( abPopup )
-  {
-    var menupopup = document.getElementById('addressbookList-menupopup');
-    var selectedAB = abPopup.getAttribute("selectedAB");
-    if (!selectedAB) 
-      selectedAB = kPersonalAddressbookURI;
-      
-    if ( selectedAB && menupopup && menupopup.childNodes )
-    {
-      for ( var index = menupopup.childNodes.length - 1; index >= 0; index-- )
-      {
-        if ( menupopup.childNodes[index].getAttribute('value') == selectedAB )
-        {
-          abPopup.label = menupopup.childNodes[index].getAttribute('label');
-          abPopup.value = menupopup.childNodes[index].getAttribute('value');
-          break;
-        }
-      }
-    }
-  }
+  var value = abPopup.value || kPersonalAddressbookURI;
+  abPopup.selectedItem = null;
+  abPopup.value = value;
   ChangeDirectoryByURI(abPopup.selectedItem.id);
 }
 
@@ -123,13 +106,6 @@ function AbPanelLoad()
   gSearchInput = document.getElementById("searchInput");
 }
 
-
-function AbPanelOnChange(event)
-{
-  var abPopup = document.getElementById('addressbookList');
-  abPopup.setAttribute("selectedAB", abPopup.value);
-}
-
 function AbPanelUnload()
 {
   var addrbookSession = Components.classes["@mozilla.org/addressbook/services/session;1"].getService().QueryInterface(Components.interfaces.nsIAddrBookSession);
diff --git a/mailnews/addrbook/resources/content/addressbook-panel.xul b/mailnews/addrbook/resources/content/addressbook-panel.xul
index 2ce107b3f5a..57063051153 100644
--- a/mailnews/addrbook/resources/content/addressbook-panel.xul
+++ b/mailnews/addrbook/resources/content/addressbook-panel.xul
@@ -78,8 +78,8 @@
     <hbox id="panel-bar" class="toolbar" align="center">
 	  <label value="&lookIn.label;"/>
       <menulist id="addressbookList" 
-                oncommand="DirPaneSelectionChangeMenulist(); AbPanelOnChange(event)" flex="1"
-                persist="selectedAB">
+                oncommand="DirPaneSelectionChangeMenulist();" flex="1"
+                persist="value">
         <menupopup id="addressbookList-menupopup" 
           datasources="rdf:addressdirectory" 
                    ref="moz-abdirectory://"