Eliminate warnings, clean up assertion translation.

js/src/jsdhash.c

@@ -77,8 +77,8 @@
 #else
 
 #define ENTRY_STORE_EXTRA 0
-#define INCREMENT_RECURSION_LEVEL(table_) 1
-#define DECREMENT_RECURSION_LEVEL(table_) 0
+#define INCREMENT_RECURSION_LEVEL(table_)   ((void)1)
+#define DECREMENT_RECURSION_LEVEL(table_)   ((void)0)
 
 #endif /* defined(DEBUG) */
 

js/src/plify_jsdhash.sed

@@ -28,5 +28,6 @@ s/JS_PUBLIC_API(\([^()]*\))/\1/
 s/JS_DLL_CALLBACK/PR_CALLBACK/
 s/JS_STATIC_DLL_CALLBACK/PR_STATIC_CALLBACK/
 s/JS_NewDHashTable/PL_NewDHashTable/
+s/JS_ASSERT(0)/NS_NOTREACHED("0")/
 s/\( *\)JS_ASSERT(\(.*\));/\1NS_ASSERTION(\2,\n\1             "\2");/
 s/JS_/PR_/g

xpcom/glue/pldhash.c

@@ -78,8 +78,8 @@
 #else
 
 #define ENTRY_STORE_EXTRA 0
-#define INCREMENT_RECURSION_LEVEL(table_) 1
-#define DECREMENT_RECURSION_LEVEL(table_) 0
+#define INCREMENT_RECURSION_LEVEL(table_)   ((void)1)
+#define DECREMENT_RECURSION_LEVEL(table_)   ((void)0)
 
 #endif /* defined(DEBUG) */
 
@@ -632,8 +632,7 @@ PL_DHashTableOperate(PLDHashTable *table, const void *key, PLDHashOperator op)
         break;
 
       default:
-        NS_ASSERTION(0,
-                     "0");
+        NS_NOTREACHED("0");
         entry = NULL;
     }