bug 296237, remove assert in getElementById, use the console service to provide feedback, make the message localizable, v1.1 patch. patch by asqueella@gmail.com, r+sr=jst

content/base/src/nsDocument.cpp

@@ -99,7 +99,7 @@
 #include "nsIMultiPartChannel.h"
 #include "nsIRefreshURI.h"
 #include "nsIWebNavigation.h"
-#include "nsIConsoleService.h"
+#include "nsIScriptError.h"
 
 #include "nsNetUtil.h"     // for NS_MakeAbsoluteURI
 
@@ -2306,13 +2306,14 @@ PRBool
 nsDocument::CheckGetElementByIdArg(const nsAString& aId)
 {
   if (aId.IsEmpty()) {
-    nsCOMPtr<nsIConsoleService> consoleService
+    nsContentUtils::ReportToConsole(
-      (do_GetService("@mozilla.org/consoleservice;1"));
+        nsContentUtils::eDOM_PROPERTIES,
-
+        "EmptyGetElementByIdParam",
-    if (consoleService) {
+        nsnull, 0,
-      consoleService->LogStringMessage(NS_LITERAL_STRING(
+        nsnull,
-        "Empty string passed to getElementById().").get());
+        EmptyString(), 0, 0,
-    }
+        nsIScriptError::warningFlag,
+        "DOM");
     return PR_FALSE;
   }
   return PR_TRUE;

dom/locales/en-US/chrome/dom/dom.properties

@@ -17,3 +17,4 @@ UseOfRouteEventWarning=Use of routeEvent() is deprecated, see bug 330494.
 UseOfPreventBubbleWarning=Event=%S, use of preventBubble() is deprecated. Use W3C standard stopPropagation() instead.
 UseOfPreventCaptureWarning=Event=%S, use of preventCapture() is deprecated. Use W3C standard stopPropagation() instead.
 UnexpectedCanvasVariantStyle=canvas: an attempt to set strokeStyle or fillStyle to a value that is neither a string, a CanvasGradient, or a CanvasPattern was ignored.
+EmptyGetElementByIdParam=Empty string passed to getElementById().