Remove UI for the target="_blank" blocking for now. Bug 78037, patch by

jonasj@jonasj.dk (Jonas Jorgensen), r=doron,bzbarsky, sr=jag

suite/common/pref/pref-scripts.js

@@ -43,7 +43,6 @@ var data;
 function changeDisabledState(state){
   //Set the states of the groupbox children state based on the "javascript enabled" checkbox value
   document.getElementById("allowScripts").disabled = state;
-  document.getElementById("allowTargetNew").disabled = state;
   document.getElementById("allowWindowMoveResize").disabled = state;
   document.getElementById("allowWindowOpen").disabled = state;
   document.getElementById("allowImageSrcChange").disabled = state;
@@ -89,7 +88,6 @@ function Startup(){
   //If scriptData does not exist, then it is the first time the panel was shown and we default to false 
   if (!("scriptData" in data)){
     var changedList = ["allowWindowOpenChanged",
-                       "allowTargetNewChanged",
                        "allowWindowMoveResizeChanged",
                        "allowWindowStatusChangeChanged",
                        "allowWindowFlipChanged",
@@ -105,7 +103,6 @@ function Startup(){
     }
 
     document.getElementById("allowWindowOpen").checked = getPrefValueForCheckbox("dom.disable_open_during_load");
-    document.getElementById("allowTargetNew").checked = getPrefValueForCheckbox("browser.block.target_new_window");
     document.getElementById("allowWindowMoveResize").checked =  getPrefValueForCheckbox("dom.disable_window_move_resize");
     document.getElementById("allowWindowFlip").checked = getPrefValueForCheckbox("dom.disable_window_flip");
     document.getElementById("allowWindowStatusChange").checked = getPrefValueForCheckbox("dom.disable_window_status_change");
@@ -151,11 +148,6 @@ function doOnOk(){
       !getCheckboxValue('allowWindowOpen'));
   }
 
-  if (data.scriptData["allowTargetNewChanged"].value){
-    parent.hPrefWindow.setPref("bool", "browser.block.target_new_window",
-      !getCheckboxValue('allowTargetNew'));
-  }
-
   if (data.scriptData["allowWindowMoveResizeChanged"].value){
     parent.hPrefWindow.setPref("bool", "dom.disable_window_move_resize",
       !getCheckboxValue('allowWindowMoveResize'));

suite/common/pref/pref-scripts.xul

@@ -38,12 +38,7 @@
 <?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>
 <?xul-overlay href="chrome://communicator/content/communicatorOverlay.xul"?>
 
-<!DOCTYPE window [
-<!ENTITY % brandDTD SYSTEM "chrome://global/locale/brand.dtd" >
-%brandDTD;
-<!ENTITY % prefScriptsDTD SYSTEM "chrome://communicator/locale/pref/pref-scripts.dtd" >
-%prefScriptsDTD;
-]>
+<!DOCTYPE window SYSTEM "chrome://communicator/locale/pref/pref-scripts.dtd">
 
 <page id="scriptsAndWindowPanel" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
       onload="parent.initPanel('chrome://communicator/content/pref/pref-scripts.xul');"
@@ -60,7 +55,6 @@
                          "allowImageSrcChange",
                          "allowDocumentCookieSet",
                          "allowDocumentCookieGet",
-                         "allowTargetNew",
                          "allowHideStatusBar"];
     ]]>
   </script>
@@ -78,7 +72,6 @@
 
     <listbox id="AllowList" flex="1">
       <listitem type="checkbox" id="allowWindowOpen" label="&allowWindowOpen.label;"/>
-      <listitem type="checkbox" id="allowTargetNew" label="&allowTargetNew.label;"/>
       <listitem type="checkbox" id="allowWindowMoveResize" label="&allowWindowMoveResize.label;"/>          
       <listitem type="checkbox" id="allowWindowFlip" label="&allowWindowFlip.label;"/>          
       <listitem type="checkbox" id="allowHideStatusBar" label="&allowHideStatusBar.label;"/>          

suite/locales/en-US/chrome/common/pref/pref-scripts.dtd

@@ -8,9 +8,8 @@
 <!ENTITY navigator.accesskey         "r">
 
 <!ENTITY enableJavaScript.label          "Enable JavaScript for">
-<!ENTITY allowScripts.label              "Allow webpages to:">
+<!ENTITY allowScripts.label              "Allow scripts to:">
 <!ENTITY allowWindowOpen.label           "Open unrequested windows">
-<!ENTITY allowTargetNew.label            "Open a link in a new window (requires restarting &brandShortName;)">
 <!ENTITY allowWindowMoveResize.label     "Move or resize existing windows">
 <!ENTITY allowWindowFlip.label           "Raise or lower windows">
 <!ENTITY allowWindowStatusChange.label   "Change status bar text">