fix 316929 .msf files not deleted after imap folder deleted, sr=mscott

mailnews/base/util/nsMsgDBFolder.cpp

@@ -511,7 +511,7 @@ nsresult nsMsgDBFolder::ReadDBFolderInfo(PRBool force)
   {
     nsCOMPtr <nsIFileSpec> dbPath;
     
-    result = GetFolderCacheKey(getter_AddRefs(dbPath));
+    result = GetFolderCacheKey(getter_AddRefs(dbPath), PR_TRUE /* createDBIfMissing */);
     
     if (dbPath)
     {
@@ -1097,7 +1097,7 @@ NS_IMETHODIMP nsMsgDBFolder::ReadFromFolderCacheElem(nsIMsgFolderCacheElement *e
   return rv;
 }
 
-nsresult nsMsgDBFolder::GetFolderCacheKey(nsIFileSpec **aFileSpec)
+nsresult nsMsgDBFolder::GetFolderCacheKey(nsIFileSpec **aFileSpec, PRBool createDBIfMissing /* = PR_FALSE */)
 {
   nsresult rv;
   nsCOMPtr <nsIFileSpec> path;
@@ -1125,7 +1125,7 @@ nsresult nsMsgDBFolder::GetFolderCacheKey(nsIFileSpec **aFileSpec)
       // create the .msf file
       // see bug #244217 for details
       PRBool exists;
-      if (NS_SUCCEEDED(dbPath->Exists(&exists)) && !exists)
+      if (createDBIfMissing && NS_SUCCEEDED(dbPath->Exists(&exists)) && !exists)
         dbPath->Touch();
     }
   }

mailnews/base/util/nsMsgDBFolder.h

@@ -136,7 +136,7 @@ protected:
   nsresult OnHdrAddedOrDeleted(nsIMsgDBHdr *hdrChanged, PRBool added);
   nsresult CreateFileSpecForDB(const char *userLeafName, nsFileSpec &baseDir, nsIFileSpec **dbFileSpec);
 
-  nsresult GetFolderCacheKey(nsIFileSpec **aFileSpec);
+  nsresult GetFolderCacheKey(nsIFileSpec **aFileSpec, PRBool createDBIfMissing = PR_FALSE);
   nsresult GetFolderCacheElemFromFileSpec(nsIFileSpec *fileSpec, nsIMsgFolderCacheElement **cacheElement);
   nsresult AddDirectorySeparator(nsFileSpec &path);
   nsresult CheckIfFolderExists(const PRUnichar *newFolderName, nsIMsgFolder *parentFolder, nsIMsgWindow *msgWindow);

mailnews/imap/src/nsImapMailFolder.cpp

@@ -1041,8 +1041,9 @@ NS_IMETHODIMP nsImapMailFolder::RemoveSubFolder (nsIMsgFolder *which)
     nsCOMPtr<nsISupports> folderSupport = do_QueryInterface(which, &rv);
     if (NS_FAILED(rv)) return rv;
     folders->AppendElement(folderSupport);
+    rv = nsMsgDBFolder::DeleteSubFolders(folders, nsnull);
     which->Delete();
-    return nsMsgDBFolder::DeleteSubFolders(folders, nsnull);
+    return rv;
 }
 
 NS_IMETHODIMP nsImapMailFolder::CreateStorageIfMissing(nsIUrlListener* urlListener)