Bug 333040: Cannot search based on "Attachment Creator" - Patch by Fr�d�ric Buclin <LpSolit@gmail.com> r=mkanat a=myk

webtools/bugzilla/Bugzilla/Field.pm

@@ -142,6 +142,7 @@ use constant DEFAULT_FIELDS => (
     {name => 'attachments.ispatch',     desc => 'Attachment is patch'},
     {name => 'attachments.isobsolete',  desc => 'Attachment is obsolete'},
     {name => 'attachments.isprivate',   desc => 'Attachment is private'},
+    {name => 'attachments.submitter',   desc => 'Attachment creator'},
 
     {name => 'target_milestone',      desc => 'Target Milestone'},
     {name => 'creation_ts', desc => 'Creation date', in_new_bugmail => 1},

webtools/bugzilla/Bugzilla/Search.pm

@@ -818,6 +818,20 @@ sub init {
                                "ON $dtable.id = $atable.attach_id");
              $f = "$dtable.thedata";
          },
+         "^attachments\.submitter," => sub {
+             my $atable = "map_attachment_submitter_$chartid";
+             my $extra = "";
+             if (Bugzilla->params->{"insidergroup"}
+                 && !Bugzilla->user->in_group(Bugzilla->params->{"insidergroup"}))
+             {
+                 $extra = "AND $atable.isprivate = 0";
+             }
+             push(@supptables, "INNER JOIN attachments AS $atable " .
+                               "ON bugs.bug_id = $atable.bug_id $extra");
+             push(@supptables, "LEFT JOIN profiles AS attachers_$chartid " .
+                               "ON $atable.submitter_id = attachers_$chartid.userid");
+             $f = "attachers_$chartid.login_name";
+         },
          "^attachments\..*," => sub {
              my $table = "attachments_$chartid";
              my $extra = "";