Bug 192447: correctly disable the Advanced button when js is disabled.

original patch by norority.

browser/components/prefwindow/content/pref-features.js

@@ -51,6 +51,7 @@ function Startup()
   var imagesEnabled = document.getElementById("enableImages").checked;
   var imageBroadcaster = document.getElementById("imageBroadcaster");
   imageBroadcaster.setAttribute("disabled", !imagesEnabled);
+  javascriptEnabledChange()
 }
 
 function viewImages() 
@@ -65,10 +66,11 @@ function advancedJavaScript()
              "chrome,modal");
 }
 
-function javascriptEnabledChange(aEnable){
+function javascriptEnabledChange()
-  var label = document.getElementById("allowScripts");
+{
+  var isEnabled = document.getElementById("enableJavaScript").checked;
   var advancedButton = document.getElementById("advancedJavascript");
-  advancedButton.disabled = aEnable;
+  advancedButton.disabled = !isEnabled;
 }
 
 function togglePermissionEnabling() 

browser/components/prefwindow/content/pref-features.xul

@@ -89,7 +89,7 @@
     <hbox>
       <checkbox id="enableJavaScript" label="&enableJavaScript.label;" accesskey="&enableJavaScript.accesskey;"
                 prefstring="javascript.enabled"
-                oncommand="javascriptEnabledChange(!this.checked);"/>
+                oncommand="javascriptEnabledChange();"/>
       <spring flex="1"/>
       
       <checkbox id="allowWindowMoveResize"    prefstring="dom.disable_window_move_resize"         hidden="true"/>