From 9cd39d77d9c6b2e781c8d3c302eb787b764fedc7 Mon Sep 17 00:00:00 2001
From: "alecf%netscape.com" <alecf%netscape.com>
Date: Fri, 12 May 2000 07:20:21 +0000
Subject: [PATCH] start factoring out searchterm code to share with search
 dialog

---
 .../search/resources/content/FilterEditor.js  | 83 ++++++++++---------
 .../search/resources/content/FilterEditor.xul |  4 +-
 2 files changed, 44 insertions(+), 43 deletions(-)

diff --git a/mailnews/base/search/resources/content/FilterEditor.js b/mailnews/base/search/resources/content/FilterEditor.js
index e641d2b9bf8..d1928cb65ab 100644
--- a/mailnews/base/search/resources/content/FilterEditor.js
+++ b/mailnews/base/search/resources/content/FilterEditor.js
@@ -23,6 +23,15 @@
 
 // the actual filter that we're editing
 var gFilter;
+
+// cache the key elements we need
+var gFilterNameElement;
+var gActionElement;
+
+// search stuff (move to overlay)
+var gSearchRowContainer;
+var gSearchTermContainer;
+
 var nsIMsgSearchValidityManager = Components.interfaces.nsIMsgSearchValidityManager;
 
 function filterEditorOnLoad()
@@ -48,27 +57,16 @@ function onOk()
     window.close();
 }
 
+// move to overlay
 // set scope on all visible searhattribute tags
 function setScope(scope) {
-    var searchAttributes = document.getElementsByTagName("searchattribute");
-    for (var i = 0; i<searchAttributes.length; i++) {
-        searchAttributes[i].searchScope = scope;
+    var searchTermElements = gSearchTermContainer.childNodes;
+    for (var i=0; i<searchTerms.length; i++) {
+        searchTermElements[i].searchattribute.searchScope = scope;
     }
 }
 
 
-function scopeChanged(event)
-{
-    var menuitem = event.target;
-
-    var searchattr = document.getElementById("searchAttr");
-    try {
-      searchattr.searchScope = menuitem.data;
-    } catch (ex) {
-        
-    }
-}
-
 function getScopeFromFilterList(filterList)
 {
     var type = filterList.folder.server.type;
@@ -82,31 +80,35 @@ function getScope(filter) {
 
 function initializeDialog(filter)
 {
-    var filterName = document.getElementById("filterName");
-    filterName.value = filter.filterName;
+    gFilterNameElement = document.getElementById("filterName");
+    gFilterNameElement.value = filter.filterName;
 
-    var actionElement = document.getElementById("actionMenu");
-    actionElement.selectedItem=actionElement.getElementsByAttribute("data", filter.action)[0];
+    gActionElement = document.getElementById("actionMenu");
+    gActionElement.selectedItem=gActionElement.getElementsByAttribute("data", filter.action)[0];
 
-    
-    // now test by initializing the psuedo <searchterm>
     var scope = getScope(filter);
-    var filterRowContainer = document.getElementById("filterTermList");
-    var searchTerms = filter.searchTerms;
+    
+    initializeSearchRows(scope, filter.searchTerms)
+}
+
+// move to overlay
+function initializeSearchRows(scope, searchTerms)
+{
+    gSearchRowContainer = document.getElementById("searchTermList");
+    gSearchTermContainer = document.getElementById("searchterms");
+    dump("gSearchTermContainer = " + gSearchTermContainer + "\n");
     var numTerms = searchTerms.Count();
     for (var i=0; i<numTerms; i++) {
-      var filterRow = createFilterRow(i);
-      filterRowContainer.appendChild(filterRow);
+        createSearchRow(i);
 
       // now that it's been added to the document, we can initialize it.
-      var filterTermObject = document.getElementById("searchTerm" + i);
+      var searchTermElement = document.getElementById("searchTerm" + i);
 
-      if (filterTermObject) {
-          filterTermObject.searchScope = scope;
+      if (searchTermElement) {
+          searchTermElement.searchScope = scope;
           var searchTerm =
-              filter.searchTerms.QueryElementAt(i, Components.interfaces.nsIMsgSearchTerm);
-          if (searchTerm) filterTermObject.searchTerm = searchTerm;
-
+              searchTerms.QueryElementAt(i, Components.interfaces.nsIMsgSearchTerm);
+          if (searchTerm) searchTermElement.searchTerm = searchTerm;
       }
       else {
 
@@ -116,7 +118,8 @@ function initializeDialog(filter)
 
 }
 
-function createFilterRow(index)
+// move to overlay
+function createSearchRow(index)
 {
     var searchAttr = document.createElement("searchattribute");
     var searchOp = document.createElement("searchoperator");
@@ -139,13 +142,9 @@ function createFilterRow(index)
 
     // should this be done with XBL or just straight JS?
     // probably straight JS but I don't know how that's done.
-    var searchtermContainer = document.getElementById("searchterms");
     var searchTerm = document.createElement("searchterm");
-
-    // need to add it to the document before we can do anything about it
     searchTerm.id = "searchTerm" + index;
-    searchtermContainer.appendChild(searchTerm);
-    // now re-find the inserted element
+    gSearchTermContainer.appendChild(searchTerm);
     searchTerm = document.getElementById(searchTerm.id);
     
     searchTerm.searchattribute = searchAttr;
@@ -163,9 +162,7 @@ function createFilterRow(index)
     }
     searchTerm.booleanNodes = stringNodes;
     
-
-    // now return the row
-    return searchrow;
+    gSearchRowContainer.appendChild(searchrow);
 }
 
 // creates a <treerow> using the array treeCellChildren as 
@@ -190,7 +187,11 @@ function constructRow(treeCellChildren)
 }
 
 function saveFilter() {
-    // first save each row
+
+    var filterName = document.getElementById("filterName");
+    filterName.value = gFilter.filterName;
+
+
     var searchTermElements =
         document.getElementById("searchterms").childNodes;
     
diff --git a/mailnews/base/search/resources/content/FilterEditor.xul b/mailnews/base/search/resources/content/FilterEditor.xul
index 7aefb820007..f51144c9877 100644
--- a/mailnews/base/search/resources/content/FilterEditor.xul
+++ b/mailnews/base/search/resources/content/FilterEditor.xul
@@ -63,10 +63,10 @@ Rights Reserved.
       <treecol width="4*"/>
       <treecol width="0*"/>
         
-      <treechildren id="filterTermList">
+      <treechildren id="searchTermList">
 
 <!-- this is what the treerows will look like:
-        <treeitem id="filterListItem">
+        <treeitem id="searchListItem">
           <treerow>
             <treecell id="preSearchAttr"/>
             <treecell allowevents="true">