Bug 633681 - Clean up and remove no longer used code. r+a=mconnor

browser/base/content/browser-syncui.js

@@ -76,19 +76,16 @@ let gSyncUI = {
       obs.push("weave:notification:added");
     }
 
-    let self = this;
     obs.forEach(function(topic) {
-      Services.obs.addObserver(self, topic, true);
+      Services.obs.addObserver(this, topic, true);
-    });
+    }, this);
 
     // Find the alltabs-popup, only if there is a gBrowser
     if (gBrowser) {
       let popup = document.getElementById("alltabs-popup");
       if (popup) {
-        let self = this;
+        popup.addEventListener(
-        popup.addEventListener("popupshowing", function() {
+          "popupshowing", this.alltabsPopupShowing.bind(this), true);
-          self.alltabsPopupShowing();
-        }, true);
       }
 
       if (Weave.Notifications.notifications.length)
@@ -124,12 +121,6 @@ let gSyncUI = {
            firstSync == "notReady";
   },
 
-  _isLoggedIn: function() {
-    if (this._needsSetup())
-      return false;
-    return Weave.Service.isLoggedIn;
-  },
-
   updateUI: function SUI_updateUI() {
     let needsSetup = this._needsSetup();
     document.getElementById("sync-setup-state").hidden = !needsSetup;
@@ -150,6 +141,8 @@ let gSyncUI = {
 
   alltabsPopupShowing: function(event) {
     // Should we show the menu item?
+    //XXXphilikon We should remove the check for isLoggedIn here and have
+    //            about:sync-tabs auto-login (bug 583344)
     if (!Weave.Service.isLoggedIn || !Weave.Engines.get("tabs").enabled)
       return;