Bug 298190: The "200 bugs" limit in buglist.cgi should be a constant, not a magic number - Patch by Tiago R. Mello <timello@async.com.br> r=kiko,justdave a=justdave

webtools/bugzilla/Bugzilla/Constants.pm

@@ -83,6 +83,8 @@ use base qw(Exporter);
         
     GLOBAL_EVENTS
     EVT_FLAG_REQUESTED EVT_REQUESTED_FLAG
+
+    FULLTEXT_BUGLIST_LIMIT
 );
 
 @Bugzilla::Constants::EXPORT_OK = qw(contenttypes);
@@ -221,5 +223,8 @@ use constant EVT_REQUESTED_FLAG     => 101; # I have requested a flag
 
 use constant GLOBAL_EVENTS => EVT_FLAG_REQUESTED, EVT_REQUESTED_FLAG;
 
+#  Number of bugs to return in a buglist when performing
+#  a fulltext search.
+use constant FULLTEXT_BUGLIST_LIMIT => 200;
 
 1;

webtools/bugzilla/buglist.cgi

@@ -772,7 +772,7 @@ if (defined $cgi->param('limit')) {
     }
 }
 elsif ($fulltext) {
-    $query .= " " . $dbh->sql_limit(200);
+    $query .= " " . $dbh->sql_limit(FULLTEXT_BUGLIST_LIMIT);
     $vars->{'sorted_by_relevance'} = 1;
 }
 

webtools/bugzilla/template/en/default/global/messages.html.tmpl

@@ -128,8 +128,9 @@
   [% ELSIF message_tag == "buglist_sorted_by_relevance" %]
     [% terms.Bugs %] on this list are sorted by relevance, with the most
     relevant [% terms.bugs %] at the top.
-    [% IF bugs.size == 200 %]
-      Only the 200 most relevant [% terms.bugs %] are shown.
+    [% IF bugs.size == constants.FULLTEXT_BUGLIST_LIMIT %]
+      Only the [% constants.FULLTEXT_BUGLIST_LIMIT FILTER html %]
+      most relevant [% terms.bugs %] are shown.
     [% END %]
 
   [% ELSIF message_tag == "change_columns" %]