diff --git a/browser/base/content/aboutSyncTabs.js b/browser/base/content/aboutSyncTabs.js index 222548e4ef2..2d3a0bbfba5 100644 --- a/browser/base/content/aboutSyncTabs.js +++ b/browser/base/content/aboutSyncTabs.js @@ -137,7 +137,6 @@ let RemoteTabViewer = { , title: title , hiddenRows: [ "description" , "location" - , "folderPicker" , "loadInSidebar" , "keyword" ] }, window.top); diff --git a/browser/base/content/browser-places.js b/browser/base/content/browser-places.js index b85892c12cd..fd4153a550f 100644 --- a/browser/base/content/browser-places.js +++ b/browser/base/content/browser-places.js @@ -386,7 +386,6 @@ var PlacesCommandHook = { , hiddenRows: [ "description" , "location" , "loadInSidebar" - , "folderPicker" , "keyword" ] }, window); } diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index 739ac2b295d..ad0de317a38 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -3163,7 +3163,6 @@ var bookmarksButtonObserver = { , hiddenRows: [ "description" , "location" , "loadInSidebar" - , "folderPicker" , "keyword" ] }, window); } catch(ex) { } @@ -5792,7 +5791,6 @@ function contentAreaClick(event, isPanelClick) , loadBookmarkInSidebar: true , hiddenRows: [ "description" , "location" - , "folderPicker" , "keyword" ] }, window); event.preventDefault(); @@ -6839,8 +6837,9 @@ function AddKeywordForSearchField() { , postData: postData , charSet: charset , hiddenRows: [ "location" - , "loadInSidebar" - , "folderPicker" ] + , "description" + , "tags" + , "loadInSidebar" ] }, window); } diff --git a/browser/base/content/nsContextMenu.js b/browser/base/content/nsContextMenu.js index d935ce626bd..f428f406b68 100644 --- a/browser/base/content/nsContextMenu.js +++ b/browser/base/content/nsContextMenu.js @@ -1406,7 +1406,6 @@ nsContextMenu.prototype = { , hiddenRows: [ "description" , "location" , "loadInSidebar" - , "folderPicker" , "keyword" ] }, window.top); } diff --git a/browser/components/places/content/bookmarkProperties.js b/browser/components/places/content/bookmarkProperties.js index fb2ae8712fc..458949bdb4b 100644 --- a/browser/components/places/content/bookmarkProperties.js +++ b/browser/components/places/content/bookmarkProperties.js @@ -264,8 +264,6 @@ var BookmarkPropertiesPanel = { NS_ASSERT("itemId" in dialogInfo); this._itemId = dialogInfo.itemId; this._title = PlacesUtils.bookmarks.getItemTitle(this._itemId); - // Don't show folderPicker when editing - this._hiddenRows.push("folderPicker"); this._readOnly = !!dialogInfo.readOnly; switch (dialogInfo.type) { diff --git a/browser/components/places/content/controller.js b/browser/components/places/content/controller.js index 15f8fc0d48b..55813f0a0fd 100644 --- a/browser/components/places/content/controller.js +++ b/browser/components/places/content/controller.js @@ -309,7 +309,6 @@ PlacesController.prototype = { , hiddenRows: [ "description" , "keyword" , "location" - , "folderPicker" , "loadInSidebar" ] , uri: NetUtil.newURI(node.uri) , title: node.title @@ -721,6 +720,7 @@ PlacesController.prototype = { , type: itemType , itemId: itemId , readOnly: isRootItem + , hiddenRows: [ "folderPicker" ] }, window.top); }, diff --git a/browser/components/places/src/PlacesUIUtils.jsm b/browser/components/places/src/PlacesUIUtils.jsm index ea612f9c49e..ef68a3b823e 100644 --- a/browser/components/places/src/PlacesUIUtils.jsm +++ b/browser/components/places/src/PlacesUIUtils.jsm @@ -340,29 +340,36 @@ var PlacesUIUtils = { * See documentation at the top of bookmarkProperties.js * @param aWindow * Owner window for the new dialog. - * @param aMinimalUI [optional] - * Whether to open the dialog in "minimal ui" mode. Do not pass this - * for new callers. It'll be removed in a future release. + * @param aResizable [optional] + * Whether the dialog is allowed to resize. Do not pass this for new + * callers since it's deprecated. It'll be removed in future releases. * * @see documentation at the top of bookmarkProperties.js * @return true if any transaction has been performed, false otherwise. */ showBookmarkDialog: - function PUIU_showBookmarkDialog(aInfo, aParentWindow, aMinimalUI) { + function PUIU_showBookmarkDialog(aInfo, aParentWindow, aResizable) { + // This is a compatibility shim for add-ons. It will warn in the Error + // Console when used. if (!aParentWindow) { aParentWindow = this._getWindow(null); } // Preserve size attributes differently based on the fact the dialog has - // a folder picker or not. - let minimalUI = "hiddenRows" in aInfo && - aInfo.hiddenRows.indexOf("folderPicker") != -1; - let dialogURL = aMinimalUI ? + // a folder picker or not. If the picker is visible, the dialog should + // be resizable since it may not show enough content for the folders + // hierarchy. + let hasFolderPicker = !("hiddenRows" in aInfo) || + aInfo.hiddenRows.indexOf("folderPicker") == -1; + let resizable = aResizable !== undefined ? aResizable : hasFolderPicker; + // Use a different chrome url, since this allows to persist different sizes, + // based on resizability of the dialog. + let dialogURL = resizable ? "chrome://browser/content/places/bookmarkProperties2.xul" : "chrome://browser/content/places/bookmarkProperties.xul"; let features = - "centerscreen,chrome,modal,resizable=" + (aMinimalUI ? "yes" : "no"); + "centerscreen,chrome,modal,resizable=" + (resizable ? "yes" : "no"); aParentWindow.openDialog(dialogURL, "", features, aInfo); return ("performed" in aInfo && aInfo.performed); diff --git a/browser/components/sidebar/src/nsSidebar.js b/browser/components/sidebar/src/nsSidebar.js index e18ed305b99..3a3d41df17e 100644 --- a/browser/components/sidebar/src/nsSidebar.js +++ b/browser/components/sidebar/src/nsSidebar.js @@ -110,9 +110,7 @@ function (aTitle, aContentURL, aCustomizeURL, aPersist) , type: "bookmark" , hiddenRows: [ "description" , "keyword" - , "location" - , "folderPicker" - , "loadInSidebar" ] + , "location" ] , uri: uri , title: aTitle , loadBookmarkInSidebar: true