Bug 68174 - "Remove event handlers from within <template> (mail/ and mailnews/ part)" ((Gv1a-TB) <FilterListDialog.*> (+ NNTP server fix)) [p=sgautherie.bz@free.fr (Serge Gautherie) r=philor]

mail/base/content/FilterListDialog.js

@@ -177,9 +177,9 @@ function onCancel()
 
 function onFilterServerClick(selection)
 {
-    var itemURI = selection.getAttribute('id');
+    var itemURI = selection.getAttribute('itemUri');
 
-    if (!itemURI || itemURI == gCurrentServerURI)
+    if (itemURI == gCurrentServerURI)
       return;
 
     // Save the current filters to disk before switching because

mail/base/content/FilterListDialog.xul

@@ -76,20 +76,21 @@
           datasources="rdf:msgaccountmanager rdf:mailnewsfolders"
           sortResource="http://home.netscape.com/NC-rdf#FolderTreeName"
           sortDirection="ascending"
-          ref="msgaccounts:/">
+          ref="msgaccounts:/"
+          oncommand="onFilterServerClick(event.target);">
           <template>
             <rule iscontainer="true" isempty="false" nc:ServerType="nntp">
               <menupopup>
                 <menu uri="..." 
-                                oncommand="onFilterServerClick(event.target)"
                                 class="folderMenuItem menu-iconic" 
                                 IsServer="rdf:http://home.netscape.com/NC-rdf#IsServer"
                                 IsSecure="rdf:http://home.netscape.com/NC-rdf#IsSecure"
                                 ServerType="rdf:http://home.netscape.com/NC-rdf#ServerType"
-                                label="rdf:http://home.netscape.com/NC-rdf#Name">
+                                label="rdf:http://home.netscape.com/NC-rdf#Name"
+                                itemUri="rdf:*">
                   <menupopup class="menulist-menupopup">
                     <menuitem label="&choosethisnewsserver.label;"
-                      oncommand="onFilterServerClick(event.target.parentNode.parentNode)"/>
+                              itemUri="rdf:*"/>
                     <menuseparator/>
                   </menupopup>
                 </menu>
@@ -102,18 +103,19 @@
                  IsServer="rdf:http://home.netscape.com/NC-rdf#IsServer"
                  IsSecure="rdf:http://home.netscape.com/NC-rdf#IsSecure"
                  ServerType="rdf:http://home.netscape.com/NC-rdf#ServerType"
-                 label="rdf:http://home.netscape.com/NC-rdf#Name"/>
+                 label="rdf:http://home.netscape.com/NC-rdf#Name"
+                 itemUri="rdf:*"/>
               </menupopup>
             </rule>
             <rule nc:SupportsFilters="true">
               <menupopup>
                 <menuitem uri="..." value="..."
-                 oncommand="onFilterServerClick(event.target)"
                  class="folderMenuItem menuitem-iconic"
                  IsServer="rdf:http://home.netscape.com/NC-rdf#IsServer"
                  IsSecure="rdf:http://home.netscape.com/NC-rdf#IsSecure"
                  ServerType="rdf:http://home.netscape.com/NC-rdf#ServerType"
-                 label="rdf:http://home.netscape.com/NC-rdf#Name"/>
+                 label="rdf:http://home.netscape.com/NC-rdf#Name"
+                 itemUri="rdf:*"/>
               </menupopup>
             </rule>
           </template>