From b29cee2d0b357885bb59f22f3bf9ab07db1c9161 Mon Sep 17 00:00:00 2001 From: "terry%mozilla.org" Date: Thu, 17 Feb 2000 16:46:36 +0000 Subject: [PATCH] Was crashing when logging profile activity. --- webtools/bugzilla/editusers.cgi | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/webtools/bugzilla/editusers.cgi b/webtools/bugzilla/editusers.cgi index 03819ec35b0..1b5d396a716 100755 --- a/webtools/bugzilla/editusers.cgi +++ b/webtools/bugzilla/editusers.cgi @@ -659,8 +659,8 @@ if ($action eq 'update') { my $emailnotificationold = trim($::FORM{emailnotificationold} || ''); my $disabledtext = trim($::FORM{disabledtext} || ''); my $disabledtextold = trim($::FORM{disabledtextold} || ''); - my $groupsetold = trim($::FORM{groupsetold} || ''); - my $blessgroupsetold = trim($::FORM{blessgroupsetold} || ''); + my $groupsetold = trim($::FORM{groupsetold} || '0'); + my $blessgroupsetold = trim($::FORM{blessgroupsetold} || '0'); my $groupset = "0"; foreach (keys %::FORM) { @@ -681,6 +681,9 @@ if ($action eq 'update') { # them, be sure to test for WHERE='$product' or WHERE='$productold' if ($groupset ne $groupsetold) { + SendSQL("SELECT groupset FROM profiles WHERE login_name=" . + SqlQuote($userold)); + $groupsetold = FetchOneColumn(); SendSQL("UPDATE profiles SET groupset = groupset - (groupset & $opblessgroupset) + $groupset @@ -696,7 +699,7 @@ if ($action eq 'update') { ($u, $groupset) = (FetchSQLData()); if ($groupset ne $groupsetold) { SendSQL("INSERT INTO profiles_activity " . - "(userid,who,profiles_when,fieldid,oldvalue,newvalue)" . + "(userid,who,profiles_when,fieldid,oldvalue,newvalue) " . "VALUES " . "($u, $::userid, now(), $fieldid, " . " $groupsetold, $groupset)");