Bug 309430 - "potential oom crash [@ xptiInterfaceInfoManager::GetInterfaceInfoManagerNoAddRef]" [p=dewildt@gmail.com (Daniel de Wildt) / ryanvm@gmail.com (Ryan VanderMeulen) r=dougt a1.9=schrep]

xpcom/reflect/xptinfo/src/xptiInterfaceInfoManager.cpp

@@ -69,8 +69,14 @@ xptiInterfaceInfoManager::GetInterfaceInfoManagerNoAddRef()
         }
 
         gInterfaceInfoManager = new xptiInterfaceInfoManager(searchPath);
-        if(gInterfaceInfoManager)
-            NS_ADDREF(gInterfaceInfoManager);
+        if(!gInterfaceInfoManager)
+        {
+            NS_ERROR("can't instantiate xptiInterfaceInfoManager");
+            return nsnull;
+        }
+
+        NS_ADDREF(gInterfaceInfoManager);
+
         if(!gInterfaceInfoManager->IsValid())
         {
             NS_RELEASE(gInterfaceInfoManager);