Bug 496032. Buttons should should lay out their contents using IsBlockInside not IsBlockOutside. r+sr=bzbarsky

--HG-- extra : rebase_source : bd35093b32239a2803868ab8d684f56db318fbeb
2009-06-12 13:48:07 +12:00 · 2009-06-12 13:48:07 +12:00 · c165addeed
--- a/layout/base/nsCSSFrameConstructor.cpp
+++ b/layout/base/nsCSSFrameConstructor.cpp
@ -3180,7 +3180,7 @@ nsCSSFrameConstructor::ConstructButtonFrame(nsFrameConstructorState& aState,
 #endif

    rv = ProcessChildren(aState, content, styleContext, blockFrame, PR_TRUE,
-                         childItems, aStyleDisplay->IsBlockOutside());
+                         childItems, aStyleDisplay->IsBlockInside());
    if (NS_FAILED(rv)) return rv;
  
    // Set the areas frame's initial child lists
--- a/layout/reftests/bugs/496032-1-ref.html
+++ b/layout/reftests/bugs/496032-1-ref.html
@ -0,0 +1,12 @@
+<!DOCTYPE HTML>
+<html>
+<head>
+<style>
+div { color:lime; }
+div:first-letter { font-size:200%; }
+</style>
+</head>
+<body>
+<button><div>Hello</div></button>
+</body>
+</html>
--- a/layout/reftests/bugs/496032-1.html
+++ b/layout/reftests/bugs/496032-1.html
@ -0,0 +1,13 @@
+<!DOCTYPE HTML>
+<html>
+<head>
+<style>
+button { display:inline-block; }
+button:first-letter { font-size:200%; }
+button:first-line { color:lime; }
+</style>
+</head>
+<body>
+<button>Hello</button>
+</body>
+</html>
--- a/layout/reftests/bugs/reftest.list
+++ b/layout/reftests/bugs/reftest.list
@ -1244,3 +1244,4 @@ fails-if(MOZ_WIDGET_TOOLKIT!="cocoa") == 488692-1.html 488692-1-ref.html # needs
 == 494667-1.html 494667-1-ref.html
 == 494667-2.html 494667-2-ref.html
 == 495274-1.html 495274-1-ref.html
+== 496032-1.html 496032-1-ref.html