Bug 520743 - [xpcshell-tests] some Places unit tests fail when 'werror' is on, part 1. r=mak

browser/components/places/tests/unit/test_browserGlue_corrupt.js

@@ -58,7 +58,7 @@ function run_test() {
     do_check_false(db.exists());
   }
   // Create a corrupt database.
-  corruptDB = gTestDir.clone();
+  let corruptDB = gTestDir.clone();
   corruptDB.append("corruptDB.sqlite");
   corruptDB.copyTo(gProfD, "places.sqlite");
   do_check_true(db.exists());

browser/components/places/tests/unit/test_browserGlue_corrupt_nobackup.js

@@ -83,7 +83,7 @@ function run_test() {
     do_check_false(db.exists());
   }
   // Create a corrupt database.
-  corruptDB = gTestDir.clone();
+  var corruptDB = gTestDir.clone();
   corruptDB.append("corruptDB.sqlite");
   corruptDB.copyTo(gProfD, "places.sqlite");
   do_check_true(db.exists());

browser/components/places/tests/unit/test_browserGlue_corrupt_nobackup_default.js

@@ -83,7 +83,7 @@ function run_test() {
     do_check_false(db.exists());
   }
   // Create a corrupt database.
-  corruptDB = gTestDir.clone();
+  var corruptDB = gTestDir.clone();
   corruptDB.append("corruptDB.sqlite");
   corruptDB.copyTo(gProfD, "places.sqlite");
   do_check_true(db.exists());

browser/components/places/tests/unit/test_browserGlue_migrate.js

@@ -73,7 +73,7 @@ function run_test() {
 
   // A migrator would run before nsBrowserGlue, so we mimic that behavior
   // adding a bookmark.
-  bs = Cc["@mozilla.org/browser/nav-bookmarks-service;1"].
+  let bs = Cc["@mozilla.org/browser/nav-bookmarks-service;1"].
            getService(Ci.nsINavBookmarksService);
   bs.insertBookmark(bs.bookmarksMenuFolder, uri("http://mozilla.org/"),
                     bs.DEFAULT_INDEX, "migrated");

browser/components/places/tests/unit/test_placesTxn.js

@@ -789,7 +789,7 @@ function run_test() {
     folderWChildItemTxn.undoTransaction();
     do_check_false(bmsvc.isBookmarked(uri("http://www.childItem.com")));
     folderWChildItemTxn.redoTransaction();
-    newchildItemId = (bmsvc.getBookmarkIdsForURI(uri("http://www.childItem.com"), {}))[0];
+    var newchildItemId = (bmsvc.getBookmarkIdsForURI(uri("http://www.childItem.com"), {}))[0];
     do_check_eq(observer._itemAddedIndex, 0);
     do_check_eq(observer._itemAddedId, newchildItemId);
     do_check_true(bmsvc.isBookmarked(uri("http://www.childItem.com")));