From d3648bb2991441ac9266a2b24d8b40e07434b2ab Mon Sep 17 00:00:00 2001 From: "troy%netscape.com" Date: Wed, 18 Nov 1998 05:31:03 +0000 Subject: [PATCH] Changed Init() to addref mAppShell and mPrefs, because that's what the other overloaded Init() does and because the destructor will do a release --- webshell/tests/viewer/nsBrowserWindow.cpp | 6 +++--- webshell/tests/viewer/nsBrowserWindow.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/webshell/tests/viewer/nsBrowserWindow.cpp b/webshell/tests/viewer/nsBrowserWindow.cpp index 01f55eac8f1..0a8ff5db3d4 100644 --- a/webshell/tests/viewer/nsBrowserWindow.cpp +++ b/webshell/tests/viewer/nsBrowserWindow.cpp @@ -936,13 +936,11 @@ nsBrowserWindow::Init(nsIAppShell* aAppShell, PRBool aAllowPlugins) { mChromeMask = aChromeMask; - mAllowPlugins = aAllowPlugins; - mAppShell = aAppShell; NS_IF_ADDREF(mAppShell); - mPrefs = aPrefs; NS_IF_ADDREF(mPrefs); + mAllowPlugins = aAllowPlugins; // Create top level window nsresult rv = nsRepository::CreateInstance(kWindowCID, nsnull, kIWindowIID, @@ -1015,7 +1013,9 @@ nsBrowserWindow::Init(nsIAppShell* aAppShell, { mChromeMask = aChromeMask; mAppShell = aAppShell; + NS_IF_ADDREF(mAppShell); mPrefs = aPrefs; + NS_IF_ADDREF(mPrefs); mAllowPlugins = aAllowPlugins; // Create top level window diff --git a/webshell/tests/viewer/nsBrowserWindow.h b/webshell/tests/viewer/nsBrowserWindow.h index 6661db16f41..e08e4458060 100644 --- a/webshell/tests/viewer/nsBrowserWindow.h +++ b/webshell/tests/viewer/nsBrowserWindow.h @@ -205,8 +205,8 @@ public: nsILabel * mLabel; //for creating more instances - nsIAppShell* mAppShell; //not addref'ed! - nsIPref* mPrefs; //not addref'ed! + nsIAppShell* mAppShell; + nsIPref* mPrefs; PRBool mAllowPlugins; // Global window collection