Bug 280391 - implement SVGSVGElement.getElementById. r=jwatt,bzbarsky

This commit is contained in:
Robert Longson 2011-11-08 15:00:29 +00:00
Родитель 5c30263b71
Коммит d68296c760
3 изменённых файлов: 80 добавлений и 1 удалений

Просмотреть файл

@ -62,6 +62,7 @@
#include "nsSVGSVGElement.h"
#include "nsContentErrors.h" // For NS_PROPTABLE_PROP_OVERWRITTEN
#include "nsContentUtils.h"
#include "nsStyleUtil.h"
#include "nsEventDispatcher.h"
#include "nsSMILTimeContainer.h"
@ -666,7 +667,17 @@ nsSVGSVGElement::CreateSVGTransformFromMatrix(nsIDOMSVGMatrix *matrix,
NS_IMETHODIMP
nsSVGSVGElement::GetElementById(const nsAString & elementId, nsIDOMElement **_retval)
{
return NS_ERROR_NOT_IMPLEMENTED;
NS_ENSURE_ARG_POINTER(_retval);
*_retval = nsnull;
nsresult rv = NS_OK;
nsAutoString selector(NS_LITERAL_STRING("#"));
nsStyleUtil::AppendEscapedCSSIdent(PromiseFlatString(elementId), selector);
nsIContent* element = nsGenericElement::doQuerySelector(this, selector, &rv);
if (NS_SUCCEEDED(rv) && element) {
return CallQueryInterface(element, _retval);
}
return rv;
}
//----------------------------------------------------------------------

Просмотреть файл

@ -68,6 +68,7 @@ _TEST_FILES = \
dataTypes-helper.svg \
getCTM-helper.svg \
test_getCTM.html \
test_getElementById.xhtml \
test_getSubStringLength.xhtml \
getSubStringLength-helper.svg \
test_isSupported.xhtml \

Просмотреть файл

@ -0,0 +1,67 @@
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>Test getElementById behaviour</title>
<script type="text/javascript" src="/MochiKit/packed.js"></script>
<script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<script type="text/javascript" src="matrixUtils.js"></script>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css" />
</head>
<body>
<p id="display"></p>
<div id="content">
<svg xmlns="http://www.w3.org/2000/svg" width="100%" height="1" id="svg">
<!-- decoy element, same Id but not a <g> -->
<rect id="g"/>
<svg id="inner">
<!-- the one we want to find -->
<g id="g"/>
<!-- check we don't get confused by CSS selectors -->
<g id="foo bar"/>
<g id="goo > car"/>
<g id="hoo~dar"/>
<g id="ioo+ear"/>
</svg>
<g id="g2"/>
</svg>
</div>
<pre id="test">
<script class="testbody" type="text/javascript">
<![CDATA[
SimpleTest.waitForExplicitFinish();
function main()
{
var svgns = "http://www.w3.org/2000/svg";
var svg = document.getElementById("inner");
is(svg.getElementById("g").nodeName, "g", "expected to find g element child");
is(svg.getElementById("foo bar").nodeName, "g", "expected to find foo bar element child");
is(svg.getElementById("goo > car").nodeName, "g", "expected to find goo > car element child");
is(svg.getElementById("hoo~dar").nodeName, "g", "expected to find hoo~dar element child");
is(svg.getElementById("ioo+ear").nodeName, "g", "expected to find ioo+ear element child");
is(svg.getElementById("g2"), null, "did not expect to find an element with id g2");
// no element with Id = "g3" in the document at all
is(svg.getElementById("g3"), null, "did not expect to find an element with id g3");
svg = document.createElementNS(svgns, "svg");
var c = document.createElementNS(svgns, "circle");
c.setAttribute("id", "c");
svg.appendChild(c);
is(svg.getElementById("c").nodeName, "circle", "expected to find circle element child");
SimpleTest.finish();
}
window.addEventListener("load", main, false);
]]>
</script>
</pre>
</body>
</html>