fix bug 24516, cookies file was being read one byte at a time, r=neeti

extensions/cookie/nsCookie.cpp

@@ -342,15 +342,31 @@ cookie_Put(nsOutputFileStream strm, const nsString& aLine)
     return NS_ERROR_FAILURE;
   }
 
-  /* output each character */
+  /* output entire line */
-  char* p = cp;
+  strm.write(cp, aLine.Length());
-  while (*p) {
-    strm.put(*(p++));
-  }
   nsCRT::free(cp);
   return NS_OK;
 }
 
+nsresult cookie_Get(nsInputFileStream strm, char& c) {
+#define BUFSIZE 128
+  static char buffer[BUFSIZE];
+  static PRInt32 next = BUFSIZE, count = BUFSIZE;
+
+  if (next == count) {
+    if (count < BUFSIZE) {
+      return NS_ERROR_FAILURE;
+    }
+    count = strm.read(buffer, BUFSIZE);
+    next = 0;
+    if (count == 0) {
+      return NS_ERROR_FAILURE;
+    }
+  }
+  c = buffer[next++];
+  return NS_OK;
+}
+
 /*
  * get a line from a file
  * return -1 if end of file reached
@@ -363,18 +379,15 @@ cookie_GetLine(nsInputFileStream strm, nsAutoString& aLine) {
   aLine.Truncate();
   char c;
   for (;;) {
-    c = strm.get();
+    if NS_FAILED(cookie_Get(strm, c)) {
+      return -1;
+    }
     if (c == '\n') {
       break;
     }
 
-    /* note that eof is not set until we read past the end of the file */
-    if (strm.eof()) {
-      return -1;
-    }
     if (c != '\r') {
       aLine.Append(c);
-//    aLine += c;
     }
   }
   return 0;