Bug #43658 (Mac classic skin polish fixes) - Updated mac classic skin, adding background to slider, modifying autorepeat images, and adding sidebar collapse images to CSS. Bug #45336/#45725 (Mail app crashes after startup) Fixed this by removing border-top style from sidebar.css in .iframe-panel. Bug #44744 - Fixed checkmark spacing in menus in Windows Classic skin.

2000-07-20 01:21:15 +00:00 · 2000-07-20 01:21:15 +00:00 · e4e648afe0
--- a/themes/classic/communicator/mac/button.css
+++ b/themes/classic/communicator/mac/button.css
@ -123,28 +123,29 @@
    {
      padding             : 2px 8px 2px 7px !important;
      border              : 1px solid #DDDDDD !important;
+      color				  : #777777;
    }
      

 /** "Green" buttons, e.g. "Search"
 *  class="button-toolbar-3"
 **
- * The commented out areas make it revert to old classic look from mac button look
+ * The commented areas make it revert from mac button look to old classic look 
 **/  
  .button-toolbar-3 
    {
-/*      behavior				: url(chrome://global/content/xulBindings.xml#buttonleft);
+      margin                : 0px 0px 0px 3px;
+      font-weight           : bold;
+      user-focus:			: ignore;
+/*    behavior				: url(chrome://global/content/xulBindings.xml#buttonleft);
+	  background-color      : #99CCCC 
      border-left           : 1px solid #DDDDDD !important;
      border-top            : 1px solid #DDDDDD !important;
      border-right          : 1px solid black !important;
      border-bottom         : 1px solid black !important;
-*/      margin                : 0px 0px 0px 3px;
-      font-weight           : bold;
-      background-color      : #99CCCC;
-      user-focus:			: ignore;
-/*      background-image		: none;
+	  background-image		: none;
      min-width				: 8em;
-            -moz-border-radius  : 3px 2px 2px 3px;
+      -moz-border-radius    : 3px 2px 2px 3px;
 */    }  
    
  .button-toolbar-3 > .button-internal-box
--- a/themes/classic/communicator/sidebar/mac/sidebar.css
+++ b/themes/classic/communicator/sidebar/mac/sidebar.css
@ -96,7 +96,9 @@
 .iframe-panel
  {
    border-left           : 1px solid #FFFFFF;
-    border-top            : 1px solid #FFFFFF;
    border-right          : 1px solid #9D9D9D;
    border-bottom         : 1px solid #9D9D9D;
-  }  
+/*  border-top            : 1px solid #FFFFFF;      DO NOT UNCOMMENT!!!  THERE IS A BUG WHERE, 
+													FOR SOME REASON, BORDER-TOP CAUSES CERTAIN APPS 
+													(E.G. MAIL) TO CRASH!!! Related to Bug #45336*/
+  }  
--- a/themes/classic/global/mac/MANIFEST
+++ b/themes/classic/global/mac/MANIFEST
@ -90,3 +90,5 @@ arrow-med-down-hover.gif
 arrow-med-up-hover.gif
 menulist-select-dot-active.gif
 menulist-select-dot.gif
+slider-bg-horiz.gif
+slider-bg-vert.gif
--- a/themes/classic/global/mac/classicBindings.xml
+++ b/themes/classic/global/mac/classicBindings.xml
@ -73,7 +73,7 @@
      <xul:scrollbarbutton type="decrement" inherits="align:sborient">
          <xul:image inherits="src"/>
 	  </xul:scrollbarbutton>
-      <xul:slider flex="1" inherits="curpos,maxpos,pageincrement,increment">
+      <xul:slider flex="1" inherits="curpos,maxpos,pageincrement,increment,align">
      	<xul:thumb inherits="align,src" flex="1"/>
      </xul:slider>
      <xul:scrollbarbutton type="increment" inherits="align:sborient">
--- a/themes/classic/global/mac/menu.css
+++ b/themes/classic/global/mac/menu.css
@ -214,7 +214,7 @@ menuitem[checked="true"][menuactive="true"]
 }

 autorepeatbutton {
-  text-align: left;
+  text-align: center;
  vertical-align: middle;
 }

@ -222,10 +222,10 @@ autorepeatbutton:hover {
  background-color      : #333399;
 }

-.autorepeatbutton-up:hover {
+autorepeatbutton:hover > .autorepeatbutton-up {
    list-style-image: url("chrome://global/skin/arrow-med-up-hover.gif")
 }

-.autorepeatbutton-down:hover {
+autorepeatbutton:hover > .autorepeatbutton-down {
    list-style-image: url("chrome://global/skin/arrow-med-down-hover.gif")
 }
--- a/themes/classic/global/mac/menulist.css
+++ b/themes/classic/global/mac/menulist.css
@ -27,13 +27,13 @@
  menulist > .menu-icon 
    {
      border			  : none;
-      padding             : none;
+      padding             : 0px;
    }  

  menulist[open="true"] > .menu-icon 
    {
 	  border			  : none;
-      padding             : none;
+      padding             : 0px;
    }
    
 /* text display frame */
@ -134,7 +134,7 @@
  	{
  	  font: 8pt geneva;
  	  min-width: 0px;
-  	  max-width: auto;
+  	  max-width: none;
  	  padding: 0px 4px;
  	}

--- a/themes/classic/global/mac/scrollbars.css
+++ b/themes/classic/global/mac/scrollbars.css
@ -8,12 +8,15 @@ scrollbar {
 }

 slider {
-   behavior: url("chrome://global/skin/classicBindings.xml#scrollbar");
   user-focus: ignore;
   user-select: none;
   background-color: #AAAAAA;
+   background-image: url("chrome://global/skin/slider-bg-horiz.gif");
 }

+slider[align="vertical"] {
+   background-image: url("chrome://global/skin/slider-bg-vert.gif");
+}

 scrollbarbutton {
  display: inline;
--- a/themes/classic/global/mac/splitter.css
+++ b/themes/classic/global/mac/splitter.css
@ -4,26 +4,78 @@ splitter
  {
    cursor                : e-resize;
    background-color      : #DDDDDD;
-  }
-
-splitter[state="dragging"]
-  {
-    background-color      : #9D9D9D;
+    vertical-align		  : middle;
  }

 grippy, grippy[collapse="before"]
  {
-	  margin                : 0px;
+    behavior              : url("chrome://global/skin/classicBindings.xml#grippy");
+	margin                : 0px;
    border-left           : 1px solid #FFFFFF;
    border-top            : 1px solid #FFFFFF;
    border-right          : 1px solid #9D9D9D;
    border-bottom         : 1px solid #9D9D9D;
-	  padding               : 0px;
-	  list-style-image      : url("chrome://global/skin/grippy-vertical-before.gif");
-	  cursor                : pointer;
+	padding               : 0px;
+	list-style-image      : url("chrome://global/skin/grippy-horizontal-before.gif");
+	cursor                : pointer;
  }

 grippy:hover
  {
 	  background-color      : #CCCCFF;
  }
+
+grippy[collapse="after"]
+  {
+	  list-style-image      : url("chrome://global/skin/grippy-horizontal-after.gif");
+  }  
+
+.grippy-box
+  {
+    border				  : none;
+  }  
+
+.grippy-image
+  {
+    list-style-image      : inherit;
+  }
+
+splitter[state="dragging"],
+splitter:hover:active
+  {
+    background-color      : #888888;
+    background-image      : url("chrome://global/skin/splitter-drag-bg.gif");
+  }
+
+/* vertical splitters */
+  window > splitter, box > splitter 
+    {
+    	width               : 6px;
+    }
+  
+/* horizontal splitters */  
+  /* XXX we should comment out the 'align' support to force people to migrate 
+         to 'orient' */
+  rows > splitter,
+  window[orient="vertical"] > splitter,
+  box[orient="vertical"] > splitter,
+  window[align="vertical"] > splitter,
+  box[align="vertical"] > splitter
+    {
+      cursor              : n-resize;
+    }
+
+  window[orient="vertical"] > splitter > grippy,
+  window[orient="vertical"] > splitter > grippy[collapse="before"],
+  box[orient="vertical"] > splitter > grippy,
+  box[orient="vertical"] > splitter > grippy[collapse="before"]
+    {
+      list-style-image    : url("chrome://global/skin/grippy-vertical-before.gif");
+    }
+    
+  window[orient="vertical"] > splitter > grippy[collapse="after"],
+  box[orient="vertical"] > splitter > grippy[collapse="after"]
+    {
+      list-style-image    : url("chrome://global/skin/grippy-vertical-after.gif");
+    }
+    
--- a/themes/classic/global/win/menu.css
+++ b/themes/classic/global/win/menu.css
@ -109,16 +109,12 @@ popup > menuitem[menuactive="true"]
 .menu-iconic-left 
  {
    color                 : inherit;
-    margin                : 0px 2px 2px 0px;
+    margin                : 0px 4px 0px 3px;
    width                 : 13px;
    text-align            : center;
    list-style-image      : inherit;
  }

-/*.menu-iconic-left[menuactive="true"]
-  {
-  }*/  
-  
 .menubar-left 
  {
    color                 : inherit;
@ -128,12 +124,12 @@ popup > menuitem[menuactive="true"]
 .menu-iconic-text, .menu-iconic-accel, .menu-text, .menu-accel 
  {
    color                 : inherit;
-    margin                : 0px 2px 0px 0px;
+    margin                : 2px 2px 2px 0px;
  }

 .menu-text 
  {
-    margin                : 2px 2px 2px 15px;
+    margin                : 2px 2px 2px 20px;
  }

 .menu-accel 
@ -157,6 +153,11 @@ menuitem[checked="true"]
    list-style-image      : url("chrome://global/skin/menu-check.gif");
  }

+menuitem[checked="true"][menuactive="true"]
+  {
+  	list-style-image	  : url("chrome://global/skin/menu-check-hover.gif");
+  }
+
 menuitem[checked="true"][disabled="true"] 
  {
    list-style-image      : url("chrome://global/skin/menu-check-disabled.gif");
@ -186,7 +187,7 @@ menuitem[checked="true"][disabled="true"]
    border                : 1px solid windowframe;
    color                 : infotext;
    font                  : smaller;
-    padding               : 0px 1px 0px 2px;
+    padding               : 2px;
  }

 .tooltip > .popup-internal-box
--- a/themes/classic/global/win/splitter.css
+++ b/themes/classic/global/win/splitter.css
@ -13,7 +13,6 @@ grippy, grippy[collapse="before"]
    border                : 1px solid threedshadow;
 	  list-style-image      : url("chrome://global/skin/grippy-horizontal-before.gif");
 	  cursor                : pointer;
-    background-color      : 
  }

 grippy:hover
@ -77,4 +76,4 @@ splitter:hover:active
    {
      list-style-image    : url("chrome://global/skin/grippy-vertical-after.gif");
    }
-    
+