r=jst. Fixing refcounting of ID attribute atoms. Additional work to earlier checkin for fixing bug 10292. Also, added support for getElementByID() in XML documents.

content/base/src/nsNodeInfo.cpp

@@ -196,6 +196,7 @@ nsNodeInfo::GetIDAttributeAtom(nsIAtom** aResult)
 {
   NS_ENSURE_ARG_POINTER(aResult);
   *aResult = mInner.mIDAttributeAtom;
+  NS_IF_ADDREF(*aResult);
 
   return NS_OK;
 }

content/xml/document/src/nsXMLDocument.cpp

@@ -899,6 +899,17 @@ MatchName(nsIContent *aContent, const nsAReadableString& aName)
       return aContent;
     }
   }
+  else {
+    nsCOMPtr<nsIXMLContent> xmlContent = do_QueryInterface(aContent);    
+    nsCOMPtr<nsIAtom> IDValue;
+    if (xmlContent && NS_SUCCEEDED(xmlContent->GetID(*getter_AddRefs(IDValue))) && IDValue) {
+      const PRUnichar* IDValStr = nsnull;
+      IDValue->GetUnicode(&IDValStr);       
+      if (aName.Equals(IDValStr)) {
+        return aContent;
+      }
+    }
+  }
   
   PRInt32 i, count;
   aContent->ChildCount(count);

htmlparser/src/nsHTMLTokens.cpp

@@ -144,6 +144,7 @@ nsresult CStartToken::GetIDAttributeAtom(nsIAtom** aResult)
 {
   NS_ENSURE_ARG_POINTER(aResult);
   *aResult = mIDAttributeAtom;
+  NS_IF_ADDREF(*aResult);
 
   return NS_OK;
 }

htmlparser/src/nsParserNode.cpp

@@ -400,6 +400,7 @@ nsCParserNode::GetIDAttributeAtom(nsIAtom** aResult) const
 {
   NS_ENSURE_ARG_POINTER(aResult);
   *aResult = mIDAttributeAtom;
+  NS_IF_ADDREF(*aResult);
 
   return NS_OK;
 }

layout/base/src/nsNodeInfo.cpp

@@ -196,6 +196,7 @@ nsNodeInfo::GetIDAttributeAtom(nsIAtom** aResult)
 {
   NS_ENSURE_ARG_POINTER(aResult);
   *aResult = mInner.mIDAttributeAtom;
+  NS_IF_ADDREF(*aResult);
 
   return NS_OK;
 }

layout/xml/document/src/nsXMLDocument.cpp

@@ -899,6 +899,17 @@ MatchName(nsIContent *aContent, const nsAReadableString& aName)
       return aContent;
     }
   }
+  else {
+    nsCOMPtr<nsIXMLContent> xmlContent = do_QueryInterface(aContent);    
+    nsCOMPtr<nsIAtom> IDValue;
+    if (xmlContent && NS_SUCCEEDED(xmlContent->GetID(*getter_AddRefs(IDValue))) && IDValue) {
+      const PRUnichar* IDValStr = nsnull;
+      IDValue->GetUnicode(&IDValStr);       
+      if (aName.Equals(IDValStr)) {
+        return aContent;
+      }
+    }
+  }
   
   PRInt32 i, count;
   aContent->ChildCount(count);

parser/htmlparser/src/nsHTMLTokens.cpp

@@ -144,6 +144,7 @@ nsresult CStartToken::GetIDAttributeAtom(nsIAtom** aResult)
 {
   NS_ENSURE_ARG_POINTER(aResult);
   *aResult = mIDAttributeAtom;
+  NS_IF_ADDREF(*aResult);
 
   return NS_OK;
 }

parser/htmlparser/src/nsParserNode.cpp

@@ -400,6 +400,7 @@ nsCParserNode::GetIDAttributeAtom(nsIAtom** aResult) const
 {
   NS_ENSURE_ARG_POINTER(aResult);
   *aResult = mIDAttributeAtom;
+  NS_IF_ADDREF(*aResult);
 
   return NS_OK;
 }