fix 29333 make the initial construction passing "" for performance and legal nsString usage. r=rickg a=bobj

string/obsolete/nsString2.cpp

@@ -682,7 +682,7 @@ char* nsString::ToNewCString() const {
  * http://www.cis.ohio-state.edu/htbin/rfc/rfc2279.html
  */
 char* nsString::ToNewUTF8String() const {
-  nsCString temp(*this);
+  nsCString temp("");
   temp.SetCapacity(8); //ensure that we get an allocated buffer instead of the common empty one.
 
   // Caculate how many bytes we need

xpcom/ds/nsString2.cpp

@@ -682,7 +682,7 @@ char* nsString::ToNewCString() const {
  * http://www.cis.ohio-state.edu/htbin/rfc/rfc2279.html
  */
 char* nsString::ToNewUTF8String() const {
-  nsCString temp(*this);
+  nsCString temp("");
   temp.SetCapacity(8); //ensure that we get an allocated buffer instead of the common empty one.
 
   // Caculate how many bytes we need

xpcom/string/obsolete/nsString2.cpp

@@ -682,7 +682,7 @@ char* nsString::ToNewCString() const {
  * http://www.cis.ohio-state.edu/htbin/rfc/rfc2279.html
  */
 char* nsString::ToNewUTF8String() const {
-  nsCString temp(*this);
+  nsCString temp("");
   temp.SetCapacity(8); //ensure that we get an allocated buffer instead of the common empty one.
 
   // Caculate how many bytes we need