Bug 596799 - document.getElementById("sync-button") is null. r=gavin, a=blocking-beta7

Make sure that the Sync button is only accessed when it actually exists in the toolbar. Also fix its entry in browserShared.inc.

browser/base/content/browser-syncui.js

@@ -108,13 +108,17 @@ let gSyncUI = {
     document.getElementById("sync-setup-state").hidden = !needsSetup;
     document.getElementById("sync-syncnow-state").hidden = needsSetup;
 
-    if (gBrowser) {
+    if (!gBrowser)
-      document.getElementById("sync-button").removeAttribute("status");
+      return;
-      this._updateLastSyncTime();
+
-    }
+    let button = document.getElementById("sync-button");
-    if (needsSetup) {
+    if (!button)
-      document.getElementById("sync-button").removeAttribute("tooltiptext");
+      return;
-    }
+
+    button.removeAttribute("status");
+    this._updateLastSyncTime();
+    if (needsSetup)
+      button.removeAttribute("tooltiptext");
   },
 
   alltabsPopupShowing: function(event) {
@@ -147,9 +151,14 @@ let gSyncUI = {
 
   // Functions called by observers
   onActivityStart: function SUI_onActivityStart() {
-    //XXXzpao Followup: Do this with a class. (bug 583384)
+    if (!gBrowser)
-    if (gBrowser)
+      return;
-      document.getElementById("sync-button").setAttribute("status", "active");
+
+    let button = document.getElementById("sync-button");
+    if (!button)
+      return;
+
+    button.setAttribute("status", "active");
   },
 
   onSyncFinish: function SUI_onSyncFinish() {
@@ -312,6 +321,9 @@ let gSyncUI = {
       return;
 
     let syncButton = document.getElementById("sync-button");
+    if (!syncButton)
+      return;
+
     let lastSync;
     try {
       lastSync = Services.prefs.getCharPref("services.sync.lastSync");

browser/themes/browserShared.inc

@@ -1,3 +1,3 @@
 %filter substitution
 
-%define primaryToolbarButtons #back-button, #forward-button, #reload-button, #stop-button, #home-button, #print-button, #downloads-button, #history-button, #bookmarks-button, #bookmarks-menu-button, #new-tab-button, #new-window-button, #cut-button, #copy-button, #paste-button, #fullscreen-button, #zoom-out-button, #zoom-in-button, #sync-buttons
+%define primaryToolbarButtons #back-button, #forward-button, #reload-button, #stop-button, #home-button, #print-button, #downloads-button, #history-button, #bookmarks-button, #bookmarks-menu-button, #new-tab-button, #new-window-button, #cut-button, #copy-button, #paste-button, #fullscreen-button, #zoom-out-button, #zoom-in-button, #sync-button