From ed9f5a55cd9bb8a4175a997d6fc4b2cff836e726 Mon Sep 17 00:00:00 2001
From: "daniel.boelzle%sun.com" <daniel.boelzle%sun.com>
Date: Fri, 18 Jan 2008 12:36:40 +0000
Subject: [PATCH] Bug 412853  many strict warnings [anonymous function does not
 always return a value]; r=philipp

---
 calendar/base/content/calendar-task-tree.xml     | 3 ++-
 calendar/base/src/calCalendarManager.js          | 1 +
 calendar/providers/memory/calMemoryCalendar.js   | 1 +
 calendar/providers/storage/calStorageCalendar.js | 3 ++-
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/calendar/base/content/calendar-task-tree.xml b/calendar/base/content/calendar-task-tree.xml
index 1711a8f29e2..79c698adab9 100644
--- a/calendar/base/content/calendar-task-tree.xml
+++ b/calendar/base/content/calendar-task-tree.xml
@@ -285,7 +285,8 @@
                   // need to act accordingly.
                   if (this.binding.mFilterFunction &&
                       !this.binding.mFilterFunction(aNewItem)) {
-                      return this.removeItem(aNewItem);
+                      this.removeItem(aNewItem);
+                      return;
                   }
                   // same holds true for the completed filter, which is
                   // currently modeled as an explicit boolean.
diff --git a/calendar/base/src/calCalendarManager.js b/calendar/base/src/calCalendarManager.js
index bd7e54413a4..686d0cbc4c4 100644
--- a/calendar/base/src/calCalendarManager.js
+++ b/calendar/base/src/calCalendarManager.js
@@ -471,6 +471,7 @@ calCalendarManager.prototype = {
                                 "_blank",
                                 "chrome,dialog=yes,alwaysRaised=yes",
                                 paramBlock);
+            return null;
         }
     },
 
diff --git a/calendar/providers/memory/calMemoryCalendar.js b/calendar/providers/memory/calMemoryCalendar.js
index e72acef4286..a715ec60686 100644
--- a/calendar/providers/memory/calMemoryCalendar.js
+++ b/calendar/providers/memory/calMemoryCalendar.js
@@ -255,6 +255,7 @@ calMemoryCalendar.prototype = {
                                            modifiedItem);
         // notify observers
         this.mObservers.notify("onModifyItem", [modifiedItem, aOldItem]);
+        return null;
     },
 
     // void deleteItem( in calIItemBase aItem, in calIOperationListener aListener );
diff --git a/calendar/providers/storage/calStorageCalendar.js b/calendar/providers/storage/calStorageCalendar.js
index 4b7191dcb39..1b3f1fae300 100644
--- a/calendar/providers/storage/calStorageCalendar.js
+++ b/calendar/providers/storage/calStorageCalendar.js
@@ -422,7 +422,7 @@ calStorageCalendar.prototype = {
                                               null,
                                               "Calendar is readonly");
             }
-            return;
+            return null;
         }
         if (!aNewItem) {
             throw Components.results.NS_ERROR_INVALID_ARG;
@@ -486,6 +486,7 @@ calStorageCalendar.prototype = {
 
         // notify observers
         this.mObservers.notify("onModifyItem", [modifiedItem, aOldItem]);
+        return null;
     },
 
     // void deleteItem( in string id, in calIOperationListener aListener );