prep work to land nsString2

base/src/nsString.cpp

@@ -419,6 +419,16 @@ PRUnichar& nsString::Last() const{
   else return gBadChar;
 }
 
+PRBool nsString::SetCharAt(PRUnichar aChar,PRInt32 anIndex){
+  PRBool result=PR_FALSE;
+  if(anIndex<mLength){
+    PRUnichar* theStr=(PRUnichar*)mStr;
+    theStr[anIndex]=aChar;
+    result=PR_TRUE;
+  }
+  return result;
+}
+
 /**
  * Create a new string by appending given string to this
  * @update	gess 7/27/98

base/src/nsString.h

@@ -171,6 +171,9 @@ PRUnichar& First() const;
  */
 PRUnichar& Last() const;
 
+PRBool SetCharAt(PRUnichar aChar,PRInt32 anIndex);
+
+
 /**********************************************************************
   String creation methods...
  *********************************************************************/

rdf/base/src/nsRDFXMLDataSource.cpp

@@ -983,12 +983,12 @@ rdf_EscapeAngleBrackets(nsString& s)
 {
     PRInt32 index;
     while ((index = s.Find('<')) != -1) {
-        s[index] = '&';
+        s.SetCharAt('&',index);
         s.Insert(nsAutoString("lt;"), index + 1);
     }
 
     while ((index = s.Find('>')) != -1) {
-        s[index] = '&';
+        s.SetCharAt('&',index);
         s.Insert(nsAutoString("gt;"), index + 1);
     }
 }
@@ -998,7 +998,7 @@ rdf_EscapeAmpersands(nsString& s)
 {
     PRInt32 index = 0;
     while ((index = s.Find('&', index)) != -1) {
-        s[index] = '&';
+        s.SetCharAt('&',index);
         s.Insert(nsAutoString("amp;"), index + 1);
         index += 4;
     }

rdf/datasource/src/nsBookmarkDataSource.cpp

@@ -277,7 +277,7 @@ BookmarkParser::ParseBookmark(const nsString& aLine, nsIRDFResource* aContainer)
         static const char kEscape22[] = "%22";
         PRInt32 offset;
         while ((offset = url.Find(kEscape22)) >= 0) {
-            url[offset] = PRUnichar(' ');
+            url.SetCharAt(' ',offset);
             url.Cut(offset + 1, sizeof(kEscape22) - 2);
         }
     }

string/obsolete/nsString.cpp

@@ -419,6 +419,16 @@ PRUnichar& nsString::Last() const{
   else return gBadChar;
 }
 
+PRBool nsString::SetCharAt(PRUnichar aChar,PRInt32 anIndex){
+  PRBool result=PR_FALSE;
+  if(anIndex<mLength){
+    PRUnichar* theStr=(PRUnichar*)mStr;
+    theStr[anIndex]=aChar;
+    result=PR_TRUE;
+  }
+  return result;
+}
+
 /**
  * Create a new string by appending given string to this
  * @update	gess 7/27/98

string/obsolete/nsString.h

@@ -171,6 +171,9 @@ PRUnichar& First() const;
  */
 PRUnichar& Last() const;
 
+PRBool SetCharAt(PRUnichar aChar,PRInt32 anIndex);
+
+
 /**********************************************************************
   String creation methods...
  *********************************************************************/

xpcom/ds/nsString.cpp

@@ -419,6 +419,16 @@ PRUnichar& nsString::Last() const{
   else return gBadChar;
 }
 
+PRBool nsString::SetCharAt(PRUnichar aChar,PRInt32 anIndex){
+  PRBool result=PR_FALSE;
+  if(anIndex<mLength){
+    PRUnichar* theStr=(PRUnichar*)mStr;
+    theStr[anIndex]=aChar;
+    result=PR_TRUE;
+  }
+  return result;
+}
+
 /**
  * Create a new string by appending given string to this
  * @update	gess 7/27/98

xpcom/ds/nsString.h

@@ -171,6 +171,9 @@ PRUnichar& First() const;
  */
 PRUnichar& Last() const;
 
+PRBool SetCharAt(PRUnichar aChar,PRInt32 anIndex);
+
+
 /**********************************************************************
   String creation methods...
  *********************************************************************/

xpcom/string/obsolete/nsString.cpp

@@ -419,6 +419,16 @@ PRUnichar& nsString::Last() const{
   else return gBadChar;
 }
 
+PRBool nsString::SetCharAt(PRUnichar aChar,PRInt32 anIndex){
+  PRBool result=PR_FALSE;
+  if(anIndex<mLength){
+    PRUnichar* theStr=(PRUnichar*)mStr;
+    theStr[anIndex]=aChar;
+    result=PR_TRUE;
+  }
+  return result;
+}
+
 /**
  * Create a new string by appending given string to this
  * @update	gess 7/27/98

xpcom/string/obsolete/nsString.h

@@ -171,6 +171,9 @@ PRUnichar& First() const;
  */
 PRUnichar& Last() const;
 
+PRBool SetCharAt(PRUnichar aChar,PRInt32 anIndex);
+
+
 /**********************************************************************
   String creation methods...
  *********************************************************************/