Bug 286003: Direct access to summarize-time.cgi when time tracking is off generates an error - Patch by Shane H. W. Travis <shane.h.w.travis@gmail.com> r=jouni a=justdave

webtools/bugzilla/summarize_time.cgi

@@ -360,8 +360,10 @@ my $cgi = Bugzilla->cgi;
 
 Bugzilla->switch_to_shadow_db();
 
-ThrowUserError("timetracking_access_denied") unless 
+UserInGroup(Param("timetrackinggroup"))
-    UserInGroup(Param("timetrackinggroup"));
+    || ThrowUserError("auth_failure", {group  => "time-tracking",
+                                       action => "access",
+                                       object => "timetracking_summaries"});
 
 my @ids = split(",", $cgi->param('id'));
 map { ValidateBugID($_) } @ids;

webtools/bugzilla/template/en/default/global/user-error.html.tmpl

@@ -160,6 +160,8 @@
       whine reports
     [% ELSIF object == "sanity_check" %]
       a sanity check
+    [% ELSIF object == "timetracking_summaries" %]
+      time-tracking summary reports
     [% ELSIF object == "user" %]
       the user you specified
     [% ELSIF object == "users" %]