(215094) yes, ben, you are expected to free strings after they're allocated. Except in this case we don't need to do a string copy anymore now that we made the INI parser take a const char*, so just use .get() on the path we got earlier.

browser/components/migration/src/nsOperaProfileMigrator.cpp

@@ -992,11 +992,7 @@ nsOperaProfileMigrator::CopySmartKeywords(nsIBookmarksService* aBMS,
 
   nsCAutoString path;
   smartKeywords->GetNativePath(path);
-  char* pathCopy = ToNewCString(path);
+  nsINIParser* parser = new nsINIParser(path.get());
-  if (!pathCopy)
-    return NS_ERROR_OUT_OF_MEMORY;
-
-  nsINIParser* parser = new nsINIParser(pathCopy);
   if (!parser)
     return NS_ERROR_OUT_OF_MEMORY;