#40761, "Make the filters UI accessible"

r=ssu, sr=sspitzer, a=asa

mailnews/base/search/resources/content/FilterEditor.xul

@@ -55,7 +55,7 @@ Contributor(s):
   <script type="application/x-javascript" src="chrome://messenger/content/widgetglue.js"/>
 
   <hbox align="start">
-    <label value="&filterName.label;"/>
+    <label value="&filterName.label;" accesskey="&filterName.accesskey;" control="filterName"/>
     <textbox flex="50%" id="filterName"/>
     <spacer flex="50%"/>
   </hbox>
@@ -70,7 +70,7 @@ Contributor(s):
   <separator/>
 
   <vbox>
-    <label value="&filterActionDesc.label;"/>
+    <label value="&filterActionDesc.label;" accesskey="&filterActionDesc.accesskey;" control="actionMenu"/>
     <hbox align="start">
       <menulist class="indent" id="actionMenu" oncommand="onActionChanged(event)">
         <menupopup>
@@ -90,7 +90,7 @@ Contributor(s):
             <!-- see MailNewsTypes2.idl -->
             <menuitem value="6" label="&highestPriorityCmd.label;"/>
             <menuitem value="5" label="&highPriorityCmd.label;"/>
-            <menuitem value="4" label="&normalPriorityCmd.label;"/>
+            <menuitem value="4" label="&normalPriorityCmd.label;" selected="true" />
             <menuitem value="3" label="&lowPriorityCmd.label;"/>
             <menuitem value="2" label="&lowestPriorityCmd.label;"/>
           </menupopup>
@@ -109,6 +109,7 @@ Contributor(s):
       </deck>
       <spacer flex="100%"/>
       <button id="newFolderButton" label="&newFolderButton.label;" 
+              accesskey="&newFolderButton.accesskey;" 
               oncommand="MsgNewFolder(SearchNewFolderOkCallback);"/>
     </hbox>
   </vbox>

mailnews/base/search/resources/content/FilterListDialog.xul

@@ -44,7 +44,8 @@ Contributor(s):  H
   <keyset id="dialogKeys"/>
 
   <hbox align="center">
-    <label value="&filtersForPrefix.label;"/>
+    <label value="&filtersForPrefix.label;" accesskey="&filtersForPrefix.accesskey;"
+           control="serverMenu"/>
       <menulist oncommand="onServerClick(event);" id="serverMenu">
         <menupopup datasources="rdf:msgaccountmanager rdf:mailnewsfolders"
                    containment="http://home.netscape.com/NC-rdf#child" ref="msgaccounts:/">
@@ -121,12 +122,17 @@ Contributor(s):  H
         </vbox>
 
         <vbox>
-          <button id="newButton" label="&newButton.label;" oncommand="onNewFilter(null);"/>
-          <button id="editButton" label="&editButton.label;" oncommand="onEditFilter();"/>
-          <button id="deleteButton" label="&deleteButton.label;" oncommand="onDeleteFilter();"/>
+          <button id="newButton" label="&newButton.label;" accesskey="&newButton.accesskey;"
+                  oncommand="onNewFilter(null);"/>
+          <button id="editButton" label="&editButton.label;" accesskey="&editButton.accesskey;" 
+                  oncommand="onEditFilter();"/>
+          <button id="deleteButton" label="&deleteButton.label;" accesskey="&deleteButton.accesskey;" 
+                  oncommand="onDeleteFilter();"/>
           <spacer flex="1"/>
-          <button id="reorderUpButton" label="&reorderUpButton.label;" oncommand="onUp(event);"/>
-          <button id="reorderDownButton" label="&reorderDownButton.label;" oncommand="onDown(event);"/>
+          <button id="reorderUpButton" label="&reorderUpButton.label;" accesskey="&reorderUpButton.accesskey;" 
+                  oncommand="onUp(event);"/>
+          <button id="reorderDownButton" label="&reorderDownButton.label;" accesskey="&reorderDownButton.accesskey;" 
+                  oncommand="onDown(event);"/>
           <spacer flex="1"/>
         </vbox>
       </row>

mailnews/base/search/resources/locale/en-US/FilterEditor.dtd

@@ -24,6 +24,7 @@
 <!ENTITY ignoreThread.label "Ignore thread">
 <!ENTITY watchThread.label "Watch thread">
 <!ENTITY filterName.label "Filter name:">
+<!ENTITY filterName.accesskey "i">
 
 <!ENTITY lowestPriorityCmd.label "lowest">
 <!ENTITY lowPriorityCmd.label "low">
@@ -31,8 +32,10 @@
 <!ENTITY highPriorityCmd.label "high">
 <!ENTITY highestPriorityCmd.label "highest">
 
-<!ENTITY conditionDesc.label "For incoming messages that match:">
+<!ENTITY conditionDesc.label "For incoming messages that:">
 <!ENTITY filterActionDesc.label "Perform this action:">
+<!ENTITY filterActionDesc.accesskey "P">
 
 <!ENTITY newFolderButton.label "New folder...">
+<!ENTITY newFolderButton.accesskey "N">
 

mailnews/base/search/resources/locale/en-US/FilterListDialog.dtd

@@ -2,9 +2,15 @@
 <!ENTITY nameColumn.label "Filter Name">
 <!ENTITY activeColumn.label "Enabled">
 <!ENTITY newButton.label "New...">
+<!ENTITY newButton.accesskey "N">
 <!ENTITY editButton.label "Edit...">
+<!ENTITY editButton.accesskey "E">
 <!ENTITY deleteButton.label "Delete">
+<!ENTITY deleteButton.accesskey "D">
 <!ENTITY reorderUpButton.label "Move Up">
+<!ENTITY reorderUpButton.accesskey "M">
 <!ENTITY reorderDownButton.label "Move Down">
+<!ENTITY reorderDownButton.accesskey "o">
 <!ENTITY filterHeader.label "Enabled filters are run automatically in the order shown below.">
 <!ENTITY filtersForPrefix.label "Filters for:">
+<!ENTITY filtersForPrefix.accesskey "F">