c0b8dd79be
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
507daffc50
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
b0f322f21c
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
4200234b9a
Fix compiler warnings in nsCaret.cpp. Bug 470574, r+sr=dbaron
2008-12-28 04:08:22 -08:00
4a05d428b8
Make display of the directional hook on the caret dependent on the bidi.browser.ui pref. Bug 418513, r=uriber, sr=roc (for core) r=mano, gavin.sharp (for browser)
2008-12-14 01:05:39 -08:00
9c1776c82c
Bug 450930. Fire a DOM event when painting so that content and chrome can track what's being repainted. r=smaug,sr=dbaron
2008-09-18 21:47:21 +12:00
99687ce381
Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie)
2008-09-15 17:40:25 +02:00
f8ec0c0915
Bug 453826 - MOZ_XUL define required for nsCaret::IsMenuPopupHidingCaret. r+sr=roc
2008-09-08 15:23:38 +03:00
744e4d736c
Bug 449955 – Remove #ifdef of nsCaret.cpp for IME r+sr=roc
2008-08-13 10:55:39 +09:00
e0bca1e0bb
Bug 419532 – deCOMtaminate nsICaret. r+sr=roc
2008-07-16 12:52:01 +02:00
f47a69b4b6
Bug 409331. Instead of QIing to nsBlockFrame in various places, call an nsLayoutUtils method to do it. r+sr=roc
2008-07-14 10:10:23 +12:00
f6a38ccad6
Bug 118308, NS_THEME_TEXTFIELD_CARET implementation (GTK), r+sr=roc
2008-06-23 11:50:52 +03:00
a1b1cbdae8
Remove unnecessary argument from SetBidiEnabled. Bug 435856, r+sr=roc
2008-06-16 02:28:17 -07:00
641fdc2f6c
Bug 430785: Caret not visible with right-clicking on a text input, patch by Martijn Wargers <martijn.martijn@gmail.com>, r+sr=roc, a=damon
2008-04-30 09:54:16 -07:00
4c64c1f12b
Bug 335359. Make the caret thicker when it's at a Kanji character. r+sr=mrbkap,a=damon
2008-04-22 20:13:55 -07:00
453bf95759
Bug 420987. The caret size should be specified in CSS pixels and it should be rounded like borders --- rounding down to the nearest device pixel, but not down to zero. r+sr=mrbkap,a=schrep
2008-04-14 14:09:23 -07:00
8110509627
Bug 427163 - "Crash [@ nsContentUtils::ContentIsDescendantOf] with contenteditable, right-clicking and document.write" (add null check) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a1.9=damons]
2008-04-08 23:16:09 -07:00
f7dae3fbcd
Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+]
2008-04-08 11:52:48 -07:00
01955f3c26
Bug 420499 - "Caret browsing mode wrongly engaged" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+]
2008-04-01 01:35:11 -07:00
f689eda5dc
Bug 400057. Make nsBlockInFlowLineIterator useful for finding the line containing a frame, searching across block continuations and their overflow lines. Use it in various places, especially in textrun construction. r+sr=dbaron
2008-02-27 01:53:48 -08:00
90c8b5b9c8
Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r=peterv r+sr=roc a1.9=beltzner]
2008-02-26 17:49:46 -08:00
1887860ac2
Bug 368760, r=mats, sr=roc, a=blocking1.9+
2007-11-22 12:47:33 -08:00
4b8be080e0
Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=cpearce r=peterv sr=roc a1.9=schrep]
2007-11-12 21:42:52 -08:00
8d1d14b755
Bug 403048. Be more careful about looking for the line containing the caret. r+sr=mrbkap
2007-11-08 17:59:20 -08:00
8236617207
Bug 336408 - Allow the caret to be positioned at the end of trimmed whitespace, as if the whitespace wasn't trimmed [p=roc r=smontagu sr=mrbkap a=blocking1.9+]
2007-11-07 20:07:00 -08:00
4cbdc93612
Clean up prbool misuse in layout. bug 398312, r+sr+a=dbaron
2007-10-09 17:00:05 -07:00
d775975b5f
remove XP_MAC usage. b=281889 r=cbarrett sr=roc a=roc
2007-10-01 16:20:37 -07:00
d41ee10a92
Bug 390423 - Simplify the signature of nsIFrame::GetPointFromOffset, patch by Ben Karel <web+moz@eschew.org>, r=aaronlev/elif, sr=roc, a1.9=dbaron
2007-08-16 20:43:00 -07:00
2430943621
Redragging over empty text field doesn't show drag caret, except for the last text field. bug 390228, r+sr=roc a=dbaron
2007-08-13 14:33:25 -07:00
1d557106a1
Clamp the caret's position so that we always draw within the nearest scrollframe. Not doing this allows the scrollframe to clip the caret, causing it to not show up at all. bug 335560, r+sr=roc
2007-08-13 13:51:16 -07:00
1231cc3a4e
Fix for bug 387380 (No visible caret when caret browsing). r=smaug, sr=jst, a=dbaron.
2007-08-10 06:19:13 -07:00
e82dbc2268
Bug 390740: Pass lang-group into GetMetricsFor more consistently (general patch). r+sr=roc, a=dbaron
2007-08-07 12:07:43 -07:00
12e960c504
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
02b7a30529
Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking.
2007-06-27 19:48:16 -07:00
0919df3f05
Backing out to fix orange.
2007-06-27 16:21:05 -07:00
e15f728720
Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking.
2007-06-27 15:29:45 -07:00
0054412272
Bug 374866. Reftests for text-transform. r=dbaron
2007-03-22 16:01:14 -07:00
8de1814d8c
Bug 435856: LTR overwrite after printing a page. r+sr=roc, a=ss
2008-07-22 11:59:15 +00:00
176fd05c12
Bug 430785: Caret not visible with right-clicking on a text input, patch by Martijn Wargers <martijn.martijn@gmail.com>, r+sr=roc, a=damon
2008-04-30 16:54:17 +00:00
60c713ed14
Bug 335359. Make the caret thicker when it's at a Kanji character. r+sr=mrbkap,a=damon
2008-04-23 03:13:55 +00:00
9ab6b3a40a
Bug 420987. The caret size should be specified in CSS pixels and it should be rounded like borders --- rounding down to the nearest device pixel, but not down to zero. r+sr=mrbkap,a=schrep
2008-04-14 21:09:23 +00:00
d7895294f4
Bug 427163 - "Crash [@ nsContentUtils::ContentIsDescendantOf] with contenteditable, right-clicking and document.write" (add null check) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a1.9=damons]
2008-04-09 06:16:09 +00:00
f619ec1731
Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+]
2008-04-08 18:53:07 +00:00
5bb459f598
Bug 420499 - "Caret browsing mode wrongly engaged" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+]
2008-04-01 08:35:11 +00:00
be29ddf7da
Bug 400057. Make nsBlockInFlowLineIterator useful for finding the line containing a frame, searching across block continuations and their overflow lines. Use it in various places, especially in textrun construction. r+sr=dbaron
2008-02-27 09:53:48 +00:00
4bd197233d
Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r=peterv r+sr=roc a1.9=beltzner]
2008-02-27 01:49:47 +00:00
c6fb8a53db
Bug 368760, r=mats, sr=roc, a=blocking1.9+
2007-11-22 20:47:35 +00:00
f30cd776a9
Bug 394473 - "caret/cursor in View Source is invisible since 20070628 {not rendered, seen, can't, cannot, shown, displayed}" [p=cpearce r=peterv sr=roc a1.9=schrep]
2007-11-13 05:42:52 +00:00
7a270ccb91
Bug 403048. Be more careful about looking for the line containing the caret. r+sr=mrbkap
2007-11-09 01:59:20 +00:00
dce353762e
Bug 336408 - Allow the caret to be positioned at the end of trimmed whitespace, as if the whitespace wasn't trimmed [p=roc r=smontagu sr=mrbkap a=blocking1.9+]
2007-11-08 04:07:00 +00:00
Benjamin Smedberg
Simon Montagu
Robert O'Callahan
Arpad Borsos
Oleg Romashin
Masayuki Nakano
John Daniels
Karuna (karunasagark@gmail.com)
Michael Ventnor
gavin@gavinsharp.com
roc+@cs.cmu.edu
reed@reedloden.com
Olli.Pettay@helsinki.fi
tglek@mozilla.com
joshmoz@gmail.com
philringnalda@gmail.com
mrbkap@gmail.com
peterv@propagandism.org
sharparrow1@yahoo.com
jwalden@mit.edu
smontagu%smontagu.org
gavin%gavinsharp.com
roc+%cs.cmu.edu
reed%reedloden.com
Olli.Pettay%helsinki.fi