c0b8dd79be
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
507daffc50
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
b0f322f21c
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
b985c7a438
Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc
2007-02-24 18:33:33 +00:00
fea47b91b7
Remove some no longer needed code. Bug 368273, r+sr=dbaron
2007-01-30 05:52:27 +00:00
116da6be23
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
3c7c571960
Remove the special painting code for a 165-twips checkbox. Move the remaining parts of nsFormControlHelper to its consumers and remove nsFormControlHelper.{cpp,h} from the tree. b=343495 r+sr=roc (r=me on roc's part)
2006-07-06 10:43:51 +00:00
d1cb1a6431
Give HTMLButtonControlFrames their own frame type. Bug 335419, r+sr=dbaron
2006-04-25 19:56:45 +00:00
64bd04b75c
Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc
2006-04-10 00:16:29 +00:00
dba51376ea
Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc
2006-03-26 21:30:36 +00:00
f33ad65b06
backing out roc's patch for bug 328926 due to crash running tests on vc8 machines.
2006-03-15 06:43:36 +00:00
f4d2e578db
Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc
2006-03-15 03:14:02 +00:00
d0abdc1385
Bug 328926. Remove aPresContext from nsIFrame::Init and nsIFrame::DidSetStyleContext. r+sr=roc, patch by Marc Liddell
2006-03-09 18:55:21 +00:00
5451e97878
Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others
2006-01-26 02:29:17 +00:00
4541761c29
Avoid reframing inside button frames and move the frame creation entirely into the frame constructor, bug 51767, r=mats sr=roc
2006-01-13 07:58:12 +00:00
0f489187a0
Bug 321294: Remove unused ReplaceFrame codepaths.
...
r/sr=roc
2006-01-10 22:58:37 +00:00
ae7c6937c0
Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc
2005-12-12 23:53:06 +00:00
91c39e17ee
Treat inline and block buttons more uniformly. Bug 304004, r+sr=dbaron
2005-11-22 23:39:48 +00:00
b1e6622e4e
Bug 108310. Make GetFrameForPoint take frame-relative coordinates, not bogus relative-to-some-view-or-other, and simplify the signature. r+sr=roc, patch by Eli Friedman.
2005-09-19 02:15:54 +00:00
c4b8dd4f16
Fixing bug 289940. Make chrome event handlers only receive trusted events by default. r=jonas@sicking.cc, sr=peterv@propagandism.org, a=chofmann@mozilla.org
2005-04-28 23:48:28 +00:00
57e2a66ece
Bug 267037. Buttons should delegate child frames to the wrapped block, and tell the style system that legends are always blocks. Fixes a couple of crashes. r+sr=bzbarsky
2005-03-07 19:08:26 +00:00
b626abc29c
Remove prescontext args for some nsIFrame methods
...
(Append/Insert/Remove/ReplaceFrames) and for some methods in table land. Patch
by Vidar Braut Haarr <bugmail@q1n.org>, r+sr=bzbarsky
2005-02-07 01:58:25 +00:00
416f37d27d
Bug 276100 GetOriginToView has unused PresContext argument p=bugmail@q1n.org r+sr=dbaron
2005-01-01 17:26:29 +00:00
1de9caa417
no bug - remove unused header includes, and remove an unused local variable.
...
r+sr=bz
2004-10-14 18:48:42 +00:00
cc807b07b1
Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
2004-07-31 23:15:21 +00:00
784ccdb144
Cleanup font usage in form input controls, b=251637, r=jshin, sr=bzbarsky
2004-07-21 01:05:44 +00:00
85ce8c146b
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:30:37 +00:00
bc07b888e1
Bug 227838. Remove unused RequiresWidget method from nsIFormControlFrame. r+sr=bzbarsky
2004-04-13 03:11:05 +00:00
f92415768a
DeCOMify nsIFrame::IsPercentageBase and rename to IsContainingBlock. b=237169 r+sr=bzbarsky a=brendan
2004-03-12 04:40:17 +00:00
1ed57cf47b
Bug 53966. Remove unnecessary view creation from nsImageControlFrame, and remove unused fields and functions from nsImageControlFrame/nsHTMLButtonControlFrame. r+sr=bzbarsky
2004-02-28 15:01:38 +00:00
745944525d
Get rid of nsIFrameManager abstract interface to the frame manager. Bug 233972, r+sr=roc.
2004-02-23 21:29:06 +00:00
a579ee29b7
Make sure to properly delegate all framelist updates to our anonymous div. Bug
...
226016/98239, r+sr=dbaron
2003-11-18 02:12:24 +00:00
50383ff50a
Bug 190735. DeCOMtaminate nsIFrame::GetFrameType. r+sr=bzbarsky
2003-10-31 20:19:18 +00:00
87e58454c4
Make shrink-wrap reflow for buttons correctly reflow the kids a second time at
...
the constrained shrink-wrap width. Bug 26650 and dependencies, patch by
arunan_bala@hotmail.com (Arunan Bala), r=jkeiser, sr=bzbarsky
2003-02-22 19:48:29 +00:00
cc390fbe51
Remove nsIStyleContext (bug 114713), r/sr=dbaron. Changed lots of methods to use nsStyleContext* or already_AddRefed<nsStyleContext> as return values, depending on whether a reference is returned. Turn on nsRefPtr (bug 104346), and change nsDerivedSafe to not declare AddRef and Release explicitly virtual, r=jag, sr=dbaron.
2003-02-22 00:32:13 +00:00
a5fcfea19e
Replace computation of max-element-size (height and width) with max-element-width alone, since the max-element-height is practically unused and not meaningful for layout. b=186953 r+sr=bzbarsky
2003-01-09 14:26:32 +00:00
6c504f96e1
Make GetType() return int instead of nsresult (bug 167762), r=peterl@netscape.com, sr=kin@netscape.com
2002-12-18 23:38:09 +00:00
656772f1ec
<button> should be a containing block. Bug 180301, r=jkeiser, sr=dbaron
2002-11-19 03:39:44 +00:00
20bae565b3
Align text inputs, buttons, comboboxes to baseline with respect to the
...
text around them (bug 167236). Fix width sizing issues for <input
type="button/reset/submit"> (bugs 79927, 36364). Fix nonuniform heights
of form controls (bug 70251). Patch is on bug 167236, r=jkeiser,
sr=roc+moz, moa=rods
2002-11-12 19:17:51 +00:00
7fb6b65f5c
Make default wrap soft again, fix up text reflow, remove cruft from button reflow (bug 164641), r=rods@netscape.com, sr=kin@netscape.com
2002-09-16 06:23:52 +00:00
232e591f4c
Clean up unneeded includes of nsStyleUtil.h, and some other include cleanup in MathML. r=rbs b=71257 (|#include| changes only)
2002-08-16 11:52:20 +00:00
6c8141be88
Remove nsFormFrame forever. bug 125578, r=alexsavulov@netscape.com, sr=jst@netscape.com
2002-06-04 00:44:04 +00:00
c510ff0346
Fixing bug 146034. Getting rid of nsHTMLIIDs.{h,cpp}. r=jfrancis@netscape.com, sr=rpotts@netscape.com
2002-05-23 00:00:34 +00:00
95771efc1f
Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa
2002-03-23 22:26:36 +00:00
eb860919bf
Backing out Bernd's checkin for bug 110596 to fix crashes / weird display. b=118991 r=bernd
2002-01-09 19:17:46 +00:00
c7343d789e
add form frames to debug reflow bug 115096 r=karnaze sr=attinasi
2002-01-07 19:55:56 +00:00
0dce65ed23
Use NS_LITERAL_STRING instead of NS_ConvertASCIItoUCS2 where possible
...
(i.e. where the string is a literal). Bug 104159, r=jag, sr=alecf
2001-11-14 01:33:42 +00:00
5bf2cf4e7e
Checking in John Keiser's <jkeiser@iname.com> fix for *tons* of form submission and <select> related bugs, see tracking bug 34297 for details. r=rods@netscape.com, sr=jst@netscape.com
2001-11-02 07:40:01 +00:00
f385eb981a
Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089.
2001-09-28 20:14:13 +00:00
c8447eabc7
Make the default "submit"
...
Bug 59035 r=kmcclusk sr=attinasi
2001-09-19 13:00:23 +00:00
Benjamin Smedberg
dbaron%dbaron.org
bzbarsky%mit.edu
mats.palmgren%bredband.net
roc+%cs.cmu.edu
pavlov%pavlov.net
bmlk%gmx.de
cvshook%sicking.cc
jst%mozilla.jstenback.com
neil%parkwaycc.co.uk
cbiesinger%web.de
bryner%brianryner.com
rbs%maths.uq.edu.au
gerv%gerv.net
uid502
bryner%netscape.com
jkeiser%netscape.com
dbaron%fas.harvard.edu
jst%netscape.com
bernd.mielke%snafu.de
rods%netscape.com