Zack Weinberg
e65a77e1b7
Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc
2009-09-12 17:49:24 +01:00
Karl Tomlinson
1a34a67e20
b=481751 block-height line-height for text input and strut baseline for textarea r=bz,sr=dbaron
...
--HG--
extra : rebase_source : 1241360066ea9387d15c71936da9468399240640
2009-05-19 10:13:12 +12:00
L. David Baron
69c05abf68
Fix miscellaneous typos in comments that I've had in my tree for ages.
2009-04-22 10:13:48 -07:00
Benjamin Smedberg
c0b8dd79be
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
507daffc50
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
Benjamin Smedberg
b0f322f21c
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
957c98a91c
Change the binding parent for native anonymous content to work like the binding parent for XBL anonymous content, and be the parent of the anonymous content subtree rather than the root of the anonymous content subtree. (Bug 436453) r=bzbarsky,smaug,surkov sr=bzbarsky
2008-07-22 21:50:20 -07:00
Zack Weinberg
d8e5c0aeb0
Delete nsLayoutUtils::GetAbsoluteCoord(); fold logic into callers and simplify. (Bug 437335) r+sr=dbaron
2008-07-17 16:37:12 -07:00
Robert O'Callahan
27d74c4b83
Backing out bug 421436 due to regression bug 439462
2008-06-17 10:39:30 +12:00
Robert O'Callahan
f6e9dd5432
Bug 421436. Remove hack that gives <br> 1-appunit width in standards mode; it's no longer necessary and it can cause subtle bugs. r+sr=dbaron
2008-06-14 20:48:07 +12:00
Robert O'Callahan
849b8d073a
Bug 439004. Check whether there's logically empty content already placed on the line instead of just checking whether the line has advanced horizontally. r+sr=dbaron.
2008-06-14 20:28:07 +12:00
aaronleventhal@moonset.net
1c3b3f46dd
Bug 409473. New crash caused by bug 405248. r+sr=roc, a=blocking1.9
2008-01-14 06:34:40 -08:00
roc+@cs.cmu.edu
22e433ebeb
Bug 392829. Clean up nsLineLayout code that's not used (or at least used differently). r+sr+a=dbaron
2007-10-01 19:36:26 -07:00
roc+@cs.cmu.edu
fbc8cc858c
Bug 96041. Compute precise glyph extents for high-quality text, and when requested. r=vlad,r+sr=dbaron
2007-09-23 19:19:14 -07:00
roc+@cs.cmu.edu
0fbb25da89
Backing out due to test bustage
2007-09-22 06:28:16 -07:00
roc+@cs.cmu.edu
8b73dd10a0
Bug 96041. Compute true glyph bounding metrics. r=vlad,dbaron,sr=dbaron
2007-09-22 05:43:52 -07:00
roc+@cs.cmu.edu
e8b5cda925
Bug 389421. Rework word selection, in particular so that layout.word_select.stop_at_punctuation is applied to boundaries between punctuation and non-punctuation, and all Unicode punctuation is treated as punctuation.
2007-08-29 20:10:19 -07:00
jwalden@mit.edu
12e960c504
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
dbaron@dbaron.org
4a3c78ca95
Make text-indent contribute to intrinsic widths, and handle negative text-indent and negative margin properly by distinguishing forced and optional breaks when accumulating minimum widths. b=368155 r+sr=roc
2007-06-21 15:32:47 -07:00
dbaron@dbaron.org
1b75b98223
Don't propagate line layout in reflow state when we're not in the line. b=320502 r+sr=roc
2007-05-17 23:04:04 -07:00
bzbarsky@mit.edu
6adcfb8d84
Make computed style handle eStyleUnit_Chars. Bug 371043, r+sr=dbaron
2007-05-04 23:09:50 -07:00
bzbarsky@mit.edu
96cd2eee3b
Make computed style handle "normal" for line-height by computing an actualnumeric height. Bug 371041, r+sr=dbaron
2007-05-04 22:30:10 -07:00
roc+@cs.cmu.edu
0054412272
Bug 374866. Reftests for text-transform. r=dbaron
2007-03-22 16:01:14 -07:00
aaronleventhal%moonset.net
9de9f3ffd2
Bug 409473. New crash caused by bug 405248. r+sr=roc, a=blocking1.9
2008-01-14 14:34:40 +00:00
roc+%cs.cmu.edu
088741b953
Bug 392829. Clean up nsLineLayout code that's not used (or at least used differently). r+sr+a=dbaron
2007-10-02 02:36:26 +00:00
roc+%cs.cmu.edu
dcd17482e7
Bug 96041. Compute precise glyph extents for high-quality text, and when requested. r=vlad,r+sr=dbaron
2007-09-24 02:19:16 +00:00
roc+%cs.cmu.edu
0015775984
Backing out due to test bustage
2007-09-22 13:28:17 +00:00
roc+%cs.cmu.edu
d8b780c76c
Bug 96041. Compute true glyph bounding metrics. r=vlad,dbaron,sr=dbaron
2007-09-22 12:43:55 +00:00
roc+%cs.cmu.edu
e5f1ba2ea3
Bug 389421. Rework word selection, in particular so that layout.word_select.stop_at_punctuation is applied to boundaries between punctuation and non-punctuation, and all Unicode punctuation is treated as punctuation.
2007-08-30 03:10:19 +00:00
jwalden%mit.edu
ef68fcf595
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 07:08:56 +00:00
dbaron%dbaron.org
ad71819fa6
Make text-indent contribute to intrinsic widths, and handle negative text-indent and negative margin properly by distinguishing forced and optional breaks when accumulating minimum widths. b=368155 r+sr=roc
2007-06-21 22:33:10 +00:00
dbaron%dbaron.org
48a5de0d15
Don't propagate line layout in reflow state when we're not in the line. b=320502 r+sr=roc
2007-05-18 06:04:04 +00:00
bzbarsky%mit.edu
6bfe4d1b01
Make computed style handle eStyleUnit_Chars. Bug 371043, r+sr=dbaron
2007-05-05 06:09:50 +00:00
bzbarsky%mit.edu
8f5c7263d5
Make computed style handle "normal" for line-height by computing an actual
...
numeric height. Bug 371041, r+sr=dbaron
2007-05-05 05:30:10 +00:00
dbaron%dbaron.org
b985c7a438
Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc
2007-02-24 18:33:33 +00:00
cvshook%sicking.cc
0c24c4a4c3
Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128
2007-01-30 00:06:41 +00:00
dbaron%dbaron.org
47f4966b12
Change the bulk of ascent (baseline) computation to happen on a virtual method on nsIFrame, and remove the redundant descent member from nsHTMLReflowMetrics, primarily to support having both first-line and last-line baselines. b=367332 r+sr=roc
2007-01-23 04:06:56 +00:00
timeless%mozdev.org
abc256e3da
Bug 355300 There should be only one nsGkAtoms creature
...
r=dbaron
2006-12-26 17:47:52 +00:00
dbaron%dbaron.org
116da6be23
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
uriber%gmail.com
58e29c5cff
Refactor nsIFrame::PeekOfset to use iteration instead of recursion, plus some more related refactoring. bug=300131 r+sr=roc
2006-09-11 20:43:01 +00:00
uriber%gmail.com
63dc4e2947
Backing out bug 300131 until I figure out how to deal with the bustage.
2006-09-11 08:03:28 +00:00
uriber%gmail.com
1b4975fbeb
Refactor nsIFrame::PeekOfset to use iteration instead of recursion, and some related refactoring. bug=300131 r+sr=roc
2006-09-11 06:39:56 +00:00
aaronleventhal%moonset.net
50e2faacac
Fixing bustage
2006-07-12 14:35:43 +00:00
aaronleventhal%moonset.net
49f91a55b3
Bug 340667. New ATK: Expose <br>'s as \n character, combining before & after blocks of text together. r+sr=roc
2006-07-12 13:51:50 +00:00
aaronleventhal%moonset.net
2ded89ada9
Bug 342596. Allow start/end of word to be specified for PeekOffset(). Necessary for upcoming nsIAccessibleText::GetText[At|Before|After]Offset() methods. r=uriber, sr=roc
2006-07-11 22:11:02 +00:00
roc+%cs.cmu.edu
d4d6564919
Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc
2006-04-26 02:01:07 +00:00
dbaron%dbaron.org
42db31dfcc
Single line comments to describe files (helpful in LXR)
2006-03-29 18:29:03 +00:00
roc+%cs.cmu.edu
dba51376ea
Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc
2006-03-26 21:30:36 +00:00
sharparrow1%yahoo.com
c85638a9e7
Bug 320326: deCOMtaminate GetContentAndOffsetsFromPoint, plus some slight behavior changes. r+sr=roc.
2006-02-27 05:57:37 +00:00
roc+%cs.cmu.edu
5451e97878
Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others
2006-01-26 02:29:17 +00:00