timeless%mac.com
33c6c4e5d5
Bug 145589 we call a getter with null, which crashes winEmbed
...
r=jkeiser sr=jst
<timeless> *shrug* i'm not actively trying to defend this patch, it's the
right thing to do for the given contract
<jkeiser> timeless: I dunno, doing *x = blah; when you don't need to do
it is definitely more expensive than if (!x)
<timeless> you aren't even allowed to do what you suggest, the
contract explicitly forbids it
[clarification, the caller isn't allowed to rely on this]
if i tried to do what you suggest, shaver would kill me :)
<jkeiser> timeless: so shaver is the guy to ask here?
<timeless> yeah if you're concerned about it
if you care measure. i care about crashing and contract violations
the contract was (out foo). which according to what shaver said
when i asked him and my memory of that, didn't allow 0.
<shaver> it doesn't allow 0
<jst> right
<shaver> we check it all over the place in the code, because we're sheep
<dmose> baaa
2002-05-20 20:06:29 +00:00
jst%netscape.com
a3758e6b7f
Fixing bug 131841. Don't make calls on weak XPCOM (nsIPresShell in this case) pointers since the objects might go away during the call, this lead to a crash in this particular case. r=sicking@bigfoot.com, sr=vidur@netscape.com, brendan@mozilla.org
2002-05-18 00:02:50 +00:00
jst%netscape.com
277cd8403f
Fixing bug 141442. Make window.openDialog() overridable from web content, and move the security check into the actual method implementation. r=mstoltz@netscape.com, sr=jband@netscape.com
2002-05-17 22:24:06 +00:00
av%netscape.com
63666b7227
Fixing 143178 -- refreshing plugins before going to the plugin finder sevice, r=peterl, sr=beard
2002-05-16 20:41:26 +00:00
dougt%netscape.com
e96df2ad1b
Fixes mozilla/strings requiring unfrozen nsCRT class. patch by scc, r=dougt, sr=jag, b=136756
2002-05-15 18:55:21 +00:00
caillon%returnzero.com
c915a8cf43
Initial implementation of DOM Level 3 Core methods Node.compareTreePosition() and Node.isSameNode(), Bug 139344, r=jkeiser, sr=jst
2002-05-14 01:28:17 +00:00
jst%netscape.com
2ceb32b8a1
Fixing bug 143088. Freezing nsIDOMWindow, nsIDOMWindowCollection, and nsIDOMBarProp. r=fabian@bluishgecko.net, sr=vidur@netscape.com
2002-05-08 21:55:48 +00:00
rods%netscape.com
b850da33e8
Turn on pluggable dialogs (second part of checkin, first part Bug 135441)
...
Bug 115136 r=dcone sr=attinasi
2002-05-07 12:03:37 +00:00
timeless%mac.com
5cbbff26b4
Bug 141813 add javadoc comments to idl so people can get useful info from them
...
nsIDOMEvent.idl nsIDOMEventListener.idl nsIDOMEventTarget.idl
r=fabian sr=jst
2002-05-03 19:57:42 +00:00
ben%netscape.com
c4694d442f
[Chrome FastLoad]
...
Patch from jst to prevent crash on shutdown.
r=ben, sr=brendan
2002-05-03 03:02:07 +00:00
jst%netscape.com
c91f2558c2
Backing out a small security related part of the last fix for bug 118933 that wasn't needed.
2002-05-02 21:21:58 +00:00
jst%netscape.com
5909fbe828
Fixing one more part of the DOM performance bug 118933. Cache the properties 'document' and 'window' on the global object in JS to avoid needing to go through XPConnect every time these are accessed. 2x speedup on some DOM testcases where the bulk of the time we spend is in the JS engine and XPConnect. r=peterv@netscape.com, sr=vidur@netscape.com
2002-04-27 00:03:47 +00:00
hyatt%netscape.com
5c9121b9b8
Fix for 139574, wrong user agent specifics on mach-o builds. r=bryner, sr=darin
2002-04-24 00:55:53 +00:00
jaggernaut%netscape.com
43c849a706
Backing out joki's checkin for bug 124990 (at his request) since this breaks some stuff on linux.
2002-04-20 01:48:32 +00:00
jst%netscape.com
d6949fadc9
Fixing bug 80083. Making sure window.navigator doesn't get GC'd during the lifetime of a document. r=fabian@bluishgecko.net, sr=vidur@netscape.com
2002-04-20 00:04:33 +00:00
joki%netscape.com
561d97d9b1
Fix for bug 124990 , Add additional processing loop for DOM event listeners to allow browser level handlers to be fired after content based listeners. r:saari, sr:jst
...
Browser based listeners can now registers themselves using the AddGroupedEventListener and passing the system event group (which can be gotten via the nsIDOMEventReceiver interface). These listeners will now fire after all content based listeners have processed.
In this initial version of the checkin most browser listeners are still left in the original content group for stability purposes.
2002-04-19 02:53:22 +00:00
joki%netscape.com
ab75e3f4ce
Fix for bug 124990, Add additional processing loop for DOM event listeners to allow browser level handlers to be fired after content based listeners. r:saari, sr:jst
...
Browser based listeners can now registers themselves using the AddGroupedEventListener and passing the system event group (which can be gotten via the nsIDOMEventReceiver interface). These listeners will now fire after all content based listeners have processed.
In this initial version of the checkin most browser listeners are still left in the original content group for stability purposes.
2002-04-19 02:52:01 +00:00
danm%netscape.com
a395b44008
make blur() available to embedded apps. bug 57841 in its third avatar r=jst,scc a=valeski
2002-04-18 21:50:11 +00:00
jst%netscape.com
21ff37f2ef
Checking in the fix for bug 52334 for the third time. This time it should stick! Making iframe's load their document even if they're not displayed. r=jkeiser@netscape.com, sr=rpotts@netscape.com.
2002-04-17 04:17:16 +00:00
peterv%netscape.com
02e9bfd150
Fix for bug 132300 (Need a better way to bootstrap an XPathEvaluator). r=pike, sr=jst.
2002-04-16 11:57:17 +00:00
caillon%returnzero.com
939ebf6997
Bug 117707. Disabling most of the prefs in Edit>Prefs>Advanced>Scripts/Windows was causing real JS scripts to break because it used CAPS. Move the checks for these features into C++, with new prefs. Patch by doronr@naboonline.com (initial work) and caillon@returnzero.com. r=fabian sr=jst a=asa.
2002-04-12 10:11:00 +00:00
hyatt%netscape.com
7402d05fb4
Fix for 136985, add api for finding out if a global window is running a timeout or still loading, r=jst, sr=blake
2002-04-12 02:15:43 +00:00
sicking%bigfoot.com
a57f4d46e0
Fix for bug 132302: Return the right exception for DOM Range. Fix by peterv.
...
r=Pike, sr=jst
2002-04-10 13:38:30 +00:00
aaronl%netscape.com
837f42b949
Bug 124234. Active Accessibility: doDefaultAction not working on html buttons. r=jkeiser, sr=jst, a=asa
2002-04-05 23:49:42 +00:00
timeless%mac.com
2f543f9a66
http://bonsai.mozilla.org/cvsquery.cgi?module=SeaMonkeyAll&branch=HEAD&cvsroot=/cvsroot&date=explicit&mindate=1017959940&maxdate=1017960540&who=jst%25netscape.com&generateBackoutCVSCommands=1
...
Backing out the fix for bug 52334
approved by sheriff (karnaze) and cathleen
2002-04-05 05:42:10 +00:00
jst%netscape.com
0a42ceaaf0
Checking in the fix for bug 52334 again now that the linux crash and the scrollwheel crash has been fixed. Making iframe's load their document even if they are not displayed. r=jkeiser@netscae.com, sr=rpotts@netscape.com, a=asa@mozilla.org
2002-04-04 22:42:19 +00:00
jst%netscape.com
96d1e84dc6
Backing out latest checkins due to them not working on linux and other unix systems with broken compilers.
2002-04-04 07:31:16 +00:00
jst%netscape.com
af0cf0c5e7
Fixing bug 52334. Making iframe's load their document even if they are not displayed. r=jkeiser@netscae.com, sr=rpotts@netscape.com, a=asa@mozilla.org
2002-04-04 02:09:19 +00:00
aaronl%netscape.com
678e7ec0af
Bug 128025. Confirm dialog for caret browsing. r=akkana, bryner, sr=hewitt, a=asa
2002-04-02 01:56:12 +00:00
hewitt%netscape.com
07d96867f1
bugs 110156, 110155
...
Removing support for <outliner> tags
Removing <tree> layout code and moving <tree> tags to outliner layout
Convert all usage of <outliner> to tree tags
Convert all usage of <tree> tags to new <tree> syntax or <listbox>
r=cmanske,varga sr=hyatt,sspitzer a=asa
Also includes fixes by Jan Varga (varga@utcruk.sk ) for bugs 132020, 133451, 131393, 115894, and 129327
2002-03-29 02:46:01 +00:00
jst%netscape.com
42d3d42f56
Fixing bug 132904. Making window.clearTimeout() and .clearInterval() callable with no argument and with an undefined argument for backwards compatibility. r=sicking@bigfoot.com, sr=jband@netscape.com, a=dbaron@fas.harvard.edu
2002-03-27 00:55:57 +00:00
jst%netscape.com
5023c205ce
Fixing bug 131311. Making window.scrollX and .scrollY replaceable for backwards compatibility. r=hidday@geocities.com, sr=jband@netscape.com, a=dbaron@fas.harvard.edu
2002-03-27 00:02:25 +00:00
bryner%netscape.com
f2bcde7f5c
Second try at fixing bug 130778. Create a new content interface, nsIMenuElement, which is implemeneted on nsHTMLSelectElement, nsHTMLOptGroupElement, and the newly-created nsXULMenuElement. Create a nsXULMenuElement instance for XUL menubar and menupopup tags. Use this interface to set and get the active item from the XUL menuframe code and the :-moz-menuactive pseudoclass matching code. Should eliminate the Txul slowdown resulting from fetching the active item through js from the pseudoclass matching code. r=jkeiser, sr=jst, a=scc.
2002-03-24 22:38:21 +00:00
dbaron%fas.harvard.edu
9c55382a01
Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa
2002-03-24 01:02:53 +00:00
dbaron%fas.harvard.edu
40db78b748
Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa
2002-03-24 00:49:22 +00:00
dbaron%fas.harvard.edu
2ce0e7fae7
Make nsIFocusController.h build without nsAString.h included first to prevent future bustage of the same type. b=131899
2002-03-24 00:27:42 +00:00
dbaron%fas.harvard.edu
92aa754e0a
Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa
2002-03-24 00:16:18 +00:00
jst%netscape.com
090681fd34
Fixing topcrash bug 131725. Make nsLocation deal with null URI's from the nsIWebNavigation implementation. r=adamlock@netscape.com, sr=darin@netscape.com, a=asa@mozilla.org.
2002-03-23 00:48:40 +00:00
andreas.otte%debitel.net
0b19287cac
fix bug 104081 [javascript: URL cant submit because of %20 instead of
...
SPACE] the script in a javascript url was not getting unescaped before
being evaluated by the js engine, r=jst, sr=darin, a=asa
2002-03-22 21:41:06 +00:00
caillon%returnzero.com
6ced451a8d
Bug 119807, Computed color values should support getRGBColorValue(). r=bzbarsky, sr=jst, a=asa
2002-03-22 20:18:42 +00:00
bryner%netscape.com
0fb5a715ab
Backing out my checkin from earlier (bug 130778), it seems to be the culprit for the Tp increase.
2002-03-21 07:33:51 +00:00
darin%netscape.com
819ce1f98f
b=128508 "freeze nsIChannel nsIRequest" r=gagan, sr=rpotts, a=asa
2002-03-20 22:50:33 +00:00
bryner%netscape.com
93114688c3
Bug 130778 - fixing Txul regression from changing 'menuactive' attribute to :-moz-menuactive pseudoclass. Get the menuactive state from the frame instead of the content node so that we don't have to call through xpconnect and js. r=dbaron, sr=hyatt, a=asa.
2002-03-20 22:48:24 +00:00
locka%iol.ie
944c7aa6fc
Append [JavaScript Application] to the title of alert/confirm/prompt dialogs posed by ordinary JS. b=31573 r=danm@netscape.com sr=blaker@netscape.com a=asa@mozilla.org
2002-03-20 11:23:13 +00:00
hidday%geocities.com
2776cf256b
Moving the patch for bug 122726 "Unable to enumerate the form elements
...
by using for/in" to the right place in the file. No code change.
r=hidday@geocities.com sr=jst@netscape.com a=asa@mozilla.org
2002-03-20 08:01:54 +00:00
heikki%netscape.com
01edb62f44
Bug 126473, make sure we initialize variables before using them. r=peterv, sr=jst, a=asa.
2002-03-19 01:46:38 +00:00
peterv%netscape.com
aa17b929a9
Fix for bug 103235 (Implement DOM Level 3 XPath WD). r=sicking, sr=jst, a=dbaron.
2002-03-14 12:18:04 +00:00
peterv%netscape.com
f16c40594e
New files for bug 103235 (Implement DOM Level 3 XPath WD). r=sicking, sr=jst, a=dbaron.
2002-03-14 11:12:51 +00:00
shanjian%netscape.com
1af020bc91
#128825 Browser crash if I view an image
...
There is no semantic difference in this part of the change. Major one
is in nsUnicodeToUTF8.cpp
r=ftang, sr=jst, a=shaver
2002-03-14 00:40:59 +00:00
jkeiser%netscape.com
4f8479fdf7
pete.zha@sun.com: add form elements into for x in form enum (bug 122726), r=jkeiser, sr=jst, a=asa
2002-03-13 02:56:40 +00:00