Граф коммитов

128 Коммитов

Автор SHA1 Сообщение Дата
Chris Jones 6e34a38bee bug 535073: prevent plugins from corrupting the stack by making word-size stores to pointers to NPBool (unsigned char). r=bsmedberg 2009-12-17 00:32:44 -06:00
Benjamin Smedberg e4bea0b2ba Bug 518924 - Implement NPN_AsyncCallback r=cjones 2009-12-16 17:27:18 -05:00
Benjamin Smedberg dec7565457 Bug 532751 - Notify the nsNPAPIPlugin and the related nsNPAPIPluginInstances when a plugin crashes so that reloading will create a new plugin process, r=josh 2009-12-16 15:08:45 -05:00
Chris Jones 763e468e41 bug 534863: the plugin DLL path needs to be quoted on windows. irc r=bent 2009-12-15 17:10:41 -06:00
Benjamin Smedberg 7e75d7eb22 Merge mozilla-central into electrolysis. 2009-12-14 21:27:17 -05:00
Jim Mathies 69278ef03e Bug 534027 - input event coords incorrect for oop windowless plugins. r=jmuizelaar. 2009-12-14 18:28:51 -06:00
Jim Mathies 511810cb85 Bug 531860 - plugin-alpha-zindex ref test fails with oopp enabled. r=jmuizelaar. 2009-12-14 18:27:25 -06:00
Benjamin Smedberg d3562a9a29 Followup to e10s landing (and back to bug 516509): on Mac, NP_GetMIMEDescription and NP_GetValue are optional entry points, because the metadata can be retrieved from the .plist file, r=josh
--HG--
extra : rebase_source : 0fc5db971736612606c66c20cc2f0a3cc62ca444
2009-12-14 16:19:25 -05:00
Ben Turner 78fcc09c48 Backing out changesets ed8d3323a50d, 3930bbdffdd5, 36e32abd2cc8, f4bcfc703ff9, 21051d997076, and 49f489315dd9 at the request of bsmedberg. 2009-12-11 12:48:37 -08:00
Benjamin Smedberg db6a7106b7 Defer the PluginCrashed notification so that we don't delete the PluginModuleParent while we're in the middle of a crash notification. 2009-12-04 21:20:06 -05:00
Benjamin Smedberg d27452982d Partly fix test bustage from bug 532751: set mShutdown before notifying the nsNPAPIPlugin, so that it doesn't re-enter IPC methods. 2009-12-04 18:41:56 -05:00
Benjamin Smedberg 4b6b1bff2d Bustage fix 2009-12-03 15:44:33 -05:00
Benjamin Smedberg 663016e74b Bug 532751 - Stop cacheing the nsNPAPIPlugin when it crashes, so that refreshing the page immediately reloads the plugin, r=bent pending r?joshmoz 2009-12-04 13:24:57 -05:00
Benjamin Smedberg f05b026fe1 Bug 532671 - After a plugin crashes, the module entry points (most importantly NPP_New) should fail, r=bent
--HG--
extra : rebase_source : 389d54e70fea2801d28bdf2e48740dcaaec31a07
2009-12-03 15:31:52 -05:00
Benjamin Smedberg 96c1e24a4d When the plugin crashes, set NPP->pdata to NULL, and null-check NPP->pdata in the callbacks that matter. r=bent
--HG--
extra : rebase_source : 32489b985b05b9da68546d37a2f0302bac8fd467
2009-12-03 15:31:01 -05:00
Benjamin Smedberg 886a4835ae Bug 532659 - PluginScriptableObjectParent gets double-deleted when the plugin crashes, and fix the IPDL bug where we `delete` the actor if construction fails, instead of calling Deallocate on it, r=bent
--HG--
extra : rebase_source : dbe9a100735b1e0d0a8b07f4421e1ccb6055a78a
2009-12-03 15:30:05 -05:00
Ben Turner 172ff1c4cd Fix bad invalidation bug in child NPObjects 2009-12-03 11:53:09 -08:00
Chris Jones 588f9c3710 bug 529005: detect child process shutdowns vs. crashes, and expose this information to IPDL actors in a new |ActorDestroy(why)| interface. also ensure that subprotocol actors are notified of shutdown and cleaned up properly. r=bsmedberg r=bent 2009-12-03 02:16:28 -06:00
Chris Jones dfa19ba299 bug 525342: make IPDL dtors part of the destructed actor's protocol instead of the manager's. r=bsmedberg 2009-12-03 02:16:14 -06:00
Chris Jones f8e4f3e6a0 bug 524220: add a |nullable| type qualifier denoting whether C++ actor params are allowed to be NULL. r=bent 2009-12-03 00:35:22 -06:00
Chris Jones 79b6f8a465 Build fix 2009-12-01 17:33:51 -06:00
Ben Turner fb7820fa39 Bug 526401 - Fixup handling of null NPP. r=bsmedberg. 2009-12-01 13:27:13 -08:00
Jim Mathies 8aaa7248e8 Bug 522299 - Electrolysis: Get windowless plugins drawing on win32. r=jmuizelaar. 2009-12-01 15:05:26 -06:00
Benjamin Smedberg 42f095d4fa XXX removal: don't destroy the stream on failure (a future ActorDestroy callback will take care of that), and other shutdown- and crash-related XXX removal which are handled by bug 529005 2009-11-25 15:34:49 -05:00
Benjamin Smedberg 3712d51cbc TODO-removal: make NullableStringGet an inline function instead of a macro, and make NullableString an inline function in mozilla::plugins instead of in an anonymous namespace: no need to have a separate copy of it for each translation unit. 2009-11-25 15:07:45 -05:00
Benjamin Smedberg 8a0394d0bc More TODOs in the the plugin stream code, use the NullableString mechanisms which were invented after this landed. 2009-11-25 10:34:59 -05:00
Benjamin Smedberg 70fc9c0f28 Bug 530894 - Clean up TODOs in the plugin stream remoting: if NPN_{Get,Post}URLNotify fail, clean up the actor properly. Also deal with null postdata, which currently causes significant problems for the in-process case (NPN_PostURLNotify succeeds, but NPP_URLNotify is never called). r=bent 2009-11-25 09:26:01 -05:00
Benjamin Smedberg 07c38a4873 Backed out changeset 97c456993dbd -- red herring, no need for this debugging spew. 2009-11-20 13:48:42 -05:00
Chris Jones 6e777e3863 temporary debugging spew to check bug 529234 2009-11-20 11:54:46 -06:00
Benjamin Smedberg 4fafe32fb3 Don't crash if NP_Initialize failed remotely: PluginLibrary::NP_Initialize returns an nsresult, not a NPError; nsNPAPIPlugin::CreatePlugin fails but still sets the outparam; nsPluginHost doesn't properly rv-check nsNPAPIPlugin::CreatePlugin, which causes us to think the bad plugin is actually good. I hate stupid failure chains! 2009-11-20 10:34:20 -05:00
Chris Jones 6d25cf367a bug 530007: fix crashing edge cases in the hope of getting better diagnostics about failed tests 2009-11-20 02:23:07 -06:00
Benjamin Smedberg 490cfa9544 Don't use a static nsCString (causing leaks in the plugin process). Also, use NS_LogInit/NS_LogTerm for the child process so that leaks are reported at the right time. 2009-11-19 17:57:56 -05:00
Ben Turner 5cc7195330 Fix bad allocation pattern in NPP_New 2009-11-19 14:47:09 -08:00
Ben Turner d97bf323b1 Followup to bug 527876 2009-11-13 13:19:33 -08:00
Ben Turner acf33c1b75 Bug 527876 - 'test_windowed_invalidate.html hangs during mochitest-ipcplugins'. 2009-11-13 12:20:03 -08:00
Chris Jones c586829aab no need to include in C++ protocol-common headers |include protocol|'d from IPDL. this is an accident of history 2009-11-12 16:20:20 -06:00
Ben Turner ea90e1d517 Bug 525792 - 'Fix leaks running mochitests'. 2009-11-12 14:16:54 -08:00
Benjamin Smedberg 8cf5fe32cf Don't rely on the plugin methods to return a non-null actor when the say NPERR_NO_ERROR... crashing here is a no-no even if the plugin is stupid. 2009-11-11 17:01:07 -05:00
Ben Turner 6246a42a0d Fix invalidation algorithm so that we never leave a deleted actor in the live hash map. 2009-11-11 17:12:01 -08:00
Chris Jones dc4ccf2a1a mac builds and runs with --enable-ipc, but the subprocess nsAppShell dies for an apparently Cocoa-related reason. IPC is fine though 2009-11-10 20:25:10 -06:00
Ben Turner f993dfcfe8 Fix silly bugs 2009-11-09 17:30:02 -08:00
Phineas T. Farnsworth 3ecf49ffd9 bug 526626: band-aids for shutdown assertions 2009-11-09 16:56:55 -06:00
Ben Turner 371897fda8 Bug 522414 - 'RPC and Sync channels will deadlock easily on Windows'. r=jimm+rs. 2009-11-06 14:33:12 -08:00
Chris Jones 0555b3b979 bug 523894: wstrings are bad news in OPT builds due to chromium/Mozilla -fshort-wchar mismatch 2009-11-05 18:24:27 -06:00
Chris Jones dfe557b425 bug 525792: fix leaking PluginModules, call NP_Shutdown() on plugins. minor, no r= 2009-11-03 15:37:07 -06:00
Benjamin Smedberg 96abb55009 Remove stale TODO, this will be properly covered by parent-side error handling events. 2009-11-02 11:48:52 -05:00
Benjamin Smedberg dbd0c99a7f Linux build bustage from previous commit, bug 525605. 2009-10-31 15:32:06 -04:00
Benjamin Smedberg e729a604e0 Bug 525605 - Windows unit tests orange loading plugins: on Windows, the directly-imported plugin functions are WINAPI, so we need to use careful typedefs to get the calling convention right. 2009-10-31 15:22:02 -04:00
Benjamin Smedberg b41ad3bdb8 Bug 525454 - Crash in mochitest-ipcplugins where NPP_Invoke returns the last reference to an object. Also fixes an operator-precedence error. 2009-10-30 17:02:47 -04:00
Chris Jones 24ec1aa919 bug 523761: give top-level IPDL actors handles to each others' processes. r=bent 2009-10-27 16:52:37 -05:00