8a4dfb84a5
Fix for bug 42810 - Bugzilla would choke if your product name contained a ' mark.
...
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com , caillon@returnzero.com
2001-08-31 23:51:35 +00:00
825d57d288
Fix for bug 96603: Grammatical error in bug_status.html. Simple one word fix.
...
Patch by Christopher Aillon (caillon@returnzero.com ). r1=Christian Reis (kiko@async.com.br ),
r2=Zach Lipton (zach@zachlipton.com ) though not really needed for this patch.
2001-08-31 23:37:36 +00:00
dbd90ba1be
Fix for bug 97764: Fixes errant sending of mail on attachment changes to users who do not want to receive mail about their own changes.
...
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org ; no second review needed.
2001-08-31 21:40:33 +00:00
23212ed017
Adding runtests.sh and 1.t to start the testing suite. No bug has been
...
filed on this issue. NOT_PART_OF_BUILD.
2001-08-31 17:41:38 +00:00
4c94f5c6c3
Fix for bug 97721: Bugzilla now requires Perl 5.005 (previous requirement was Perl 5.004). This is due to the use of Template Toolkit for templatizing the pages for easier local customization. The new attachment tracker that was checked in earlier tonight uses the templates. Also included on this patch is a check for AppConfig, which is a prerequisite for Template Toolkit, because the Makefile.PL for Template Toolkit won't run without it, and it doesn't tell CPAN that it has prereqs, which causes confusion if you're installing from CPAN.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
2001-08-31 06:08:43 +00:00
19a5a3e365
Fix for bug 75840: syncshadowdb -syncall now properly shuts down Bugzilla during the sync process so mysql doesn't get overloaded while the tables are locked. This patch also adds some funtionality to the script to allow you to specify an alternate temp directory on the command line, in case you have a large database and need it made to a different filesystem for space reasons.
...
Patch by Dawn Endico <endico@mozilla.org> and Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-31 05:49:01 +00:00
41268ed110
Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
...
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com
2001-08-31 04:19:32 +00:00
34ed0df3d8
Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
...
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com
2001-08-31 03:54:37 +00:00
70b600ce7e
Fix for bug 26189: "cannot view images with lxr". The image-handling code was running too early and didn't have access to the "raw" URL parameter by which images get displayed.
...
Patch by Dawn Endico <endico@mozilla.org>
r=myk@mozilla.org
2001-08-31 00:46:09 +00:00
983ad23402
Fix for bug 96534: The version, component, and milestone select lists on the query page were slow to reflow when you changed the product in the first select list. This patch is a complete rewrite from scratch of the javascript used on query.cgi, which results in an approximately 700% speed increase in the reflow time when changing the selected product.
...
Patch by Chris Lahey <clahey@ximian.com> and Christian Reis <kiko@async.com.br>
Javascript changes r= caillon@returnzero.com , louie@ximian.com
Perl changes r= jake@acutex.net , justdave@syndicomm.com
2001-08-30 22:56:53 +00:00
c6459e2072
merge this sample with code I am really using, to demonstrate how to build
...
tar files for each build and use the -D in CVS.
2001-08-30 18:54:25 +00:00
94050ac3cb
Fix for bug 28736 - Bugmail will now show the summary for the bug that changed in the "This bug depends on bug X, which changed state" messages.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-08-30 03:14:24 +00:00
7d1487e8ed
Bumping version to 2.15 for development
2001-08-29 21:41:50 +00:00
72c5f424e5
moving version to 2.14 (golden) to roll the tarball.
2001-08-29 19:52:13 +00:00
4a68b9ae59
Updating release notes for 2.14
...
Release Notes written by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com , jake@acutex.net
2001-08-29 19:39:01 +00:00
423e261089
Typo in perl modify string, added "#!" to /usr/bin/perl strings.
2001-08-29 18:13:42 +00:00
e9d3e04bff
Buncha' release updates. Moved all images to
...
./images so we don't have multiple copies of the
same image, fixed these doc bugs (in no particular order):
94949
97070
97071
97114
96498
95970
96677
94953
96501
96679
97068
97191
97192
2001-08-29 17:25:41 +00:00
6929a0dcaf
*** empty log message ***
2001-08-29 16:07:08 +00:00
1296d0bf87
Fixing a couple typoes
2001-08-28 17:55:14 +00:00
8b3f62a485
Re-fix for bug 87769: the original patch checked in for this prevented any votes from being changed at all. This corrects that so votes can be changed again while still trapping the error the original patch was designed to catch.
...
Patch by Christoper Aillon <caillon@returnzero.com>
r= justdave@syndicomm.com
2001-08-28 09:19:16 +00:00
af99f4f812
All code patches targetted for 2.14 have been checked in. Bumping version
...
number to 2.14rc to indicate release candidate status.
2001-08-26 23:06:45 +00:00
796b6cf561
Fix for bug 92266: Prevent dataloss in the bugs_activity table by wrapping
...
entries into additional entries if they're too long to fit.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-08-26 22:58:34 +00:00
0c11288732
Bug 96085 - bypassing group security checks using duplicate bugs
...
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net
2001-08-26 18:51:45 +00:00
83ff039814
Fix for bug 87769 - doeditvotes.cgi can nuke votes
...
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net
2001-08-25 18:53:31 +00:00
51d56e60fb
Fix for bug 95634 - Improvements to Param('voteremovedmail')
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-08-25 00:12:12 +00:00
5206e0b6ac
Fix for bug 95235: variables with untrusted content were being echoed back to the user in error messages. Those variables are now run through html_quote() first.
...
Patch by Gavin Shelley <gavins@iplbath.com>
r= justdave@syndicomm.com
2001-08-24 17:32:25 +00:00
1e367845e7
Adding some pretty images for the Bugzilla Guide warning,
...
note, caution, and tip entries.
2001-08-23 14:30:20 +00:00
4eb813cb2d
Big checkin of docs to resolve every
...
known outstanding doc bug! Yay release.
Still many things to fix. Aren't there always?
2001-08-22 03:44:35 +00:00
f22a315477
Bug 96063 - the old method of doing this barfed on long URL strings.
2001-08-21 00:36:54 +00:00
94ad120a76
Fix for bug 96085: don't allow unauthorized users to access restricted bugs that do not have a QA contact.
...
Patch by Myk Melez <myk@mozilla.org>
r=Jake <jake@acutex.net>
2001-08-20 20:36:10 +00:00
87e2b74b56
current as of mon aug 20
2001-08-20 18:59:56 +00:00
262f3cf591
catch io errors from storable and give better discriptions.
2001-08-20 18:57:12 +00:00
caf8704094
Fix for bug 95890: Correctly convert/record keyword changes in the bugs_activity table for keywords containing a plus sign or other
...
regular expression meta-characters. Myk's first ever Bugzilla checkin!
Patch by Dave Miller <justdave@syndicomm.com> and Myk Melez <myk@mozilla.org>.
r=myk@mozilla.org ,justdave@syndicomm.com
2001-08-19 18:26:21 +00:00
65e904febe
Refixing bug 95875 - The code that breakes the typed in CC list into individual lists is now slightly more robust and allows perl to handle the splitting more efficiently (by using a space as the delimiter).
...
r= myk@mozilla.org
2001-08-18 03:35:36 +00:00
4655038d3a
Fix for bug 95857: process_bugs.cgi sees blank address in cc: line (would show up as __UNKNOWN__)
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-18 01:49:02 +00:00
2f772f1b84
Fix for bug 95747 - CC List validation (for additions) wasn't happening until after the bug's changes were in the process of being commited. This caused problems if a typo was made in the e-mail address.
...
r= myk@mozilla.org
2001-08-17 20:18:33 +00:00
1f0d8fe308
Fix for bug 95731: "INSERT INTO shadowlog" failed because "Table 'shadowlog' not locked", fixed typo in lock tables command.
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-08-17 12:42:34 +00:00
44f95ac895
Fix for bug 95743: the role-accessible checkboxes were getting cleared if a user with group access had to log in to make changes to a public bug.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-17 11:15:04 +00:00
a70b156a17
Fix for bug 95731: "INSERT INTO shadowlog" failed because "Table 'shadowlog' not locked", fixed typo in lock tables command.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-17 08:38:54 +00:00
c44843283c
Fix for bug 95546. MySQL versions before 3.23 don't support INNER JOINs
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-08-16 15:28:33 +00:00
007829877b
Fix for bug 95535: the token generator for password resets is allowing the & character to be used for tokens, but wasn't escaping them for the URL it emailed to users to use to get in to reset their password.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
2001-08-16 06:52:55 +00:00
d12bd21adf
Fix for bug 87779: thanks to the new password reset code, there was no clear way to create a new Bugzilla account from the login screen. There is now a link to createaccount.cgi from the login screen, and the text around the password reset button has been edited so it doesn't sound like you can get a new account by using it (because you can't)
...
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
2001-08-16 06:43:21 +00:00
ea3bc4ddbb
Fix for bug 95304: Add a buglist link to the top of duplicates.cgi
...
Patch by Gervase Markham <gerv@mozilla.org>
r= justdave@syndicomm.com
2001-08-16 02:54:49 +00:00
8b40d3d395
Fix for bug 92593: Changing a bugs product will no longer remove the votes from that bug unless the number of votes for a given user is beyond what is allowed per-bug on the new product. Only the per-bug vote count is checked. If the user is beyond the per-product vote limit for the new product, it is left alone, on the theory that it's better to preserve the votes on the bug. The user will be forced to reduce their votes to fit the product limit the next time they try to vote on something.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-16 02:46:15 +00:00
9397cee068
Re-fix for bug 95082: allow syncshadowdb to continue to make queries while Bugzilla is shut down.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-15 02:38:02 +00:00
aa90ad2a9c
commiting changes from Pavel Hlavnicka <pavel@gingerall.cz>, to add seperate "grouped" and "alphabetical" TOCs, as well as automatic <C> linkage in <SYNTAX> blocks.
...
Fixed navToGroup to work in the new world.
2001-08-15 00:41:43 +00:00
448f3d1e24
Fix for bug 72951 - oopsbot should have flooder defences
...
r= zach@zachlipton.com
a= hixie
2001-08-14 16:53:30 +00:00
554a6f0c6e
clean the same ENV variables that sudo does at start time.
2001-08-14 16:34:36 +00:00
08ad49dcaa
the estimate of the time remaining was broken (variable name changed in
...
some code and not others).
2001-08-14 15:57:43 +00:00
a06166fb63
fix a typo. Try to auto update the status page when admin functions
...
are performed.
2001-08-13 20:11:55 +00:00
8de442942b
reject bug tickets for trees we do not know about. This allows
...
BTData to not depend on TreeData
2001-08-13 20:03:10 +00:00
d1758bf024
generalize the interface of BTData::bug_id2bug_url. we he a bug tracking
...
system which does not have a simple mapping of bugid to url.
2001-08-13 20:01:36 +00:00
dd158be05b
generalize the interface of BTData::bug_id2bug_url we have a bug tracking
...
system which does not have a clear mapping from bugid to url.
2001-08-13 20:00:24 +00:00
3709a9534b
generalize split_cgi_args so that other programs can use it. now it accepts
...
an argument.
2001-08-13 19:56:41 +00:00
c76e8f2812
generalize split_cgi_args so that other scripts can use it. Add an
...
argument.
2001-08-13 19:55:25 +00:00
d1df4373a4
the calls to save_structure used to pass a scalar variable and not a reference. this was just wrong and broke when used with storable.
2001-08-13 19:52:34 +00:00
95a486b119
add code to call the bonsai save state functions. this does not work yet.
2001-08-13 19:50:46 +00:00
b01934cfd9
add code to call the Bonsai save state functions. this does not work yet.
2001-08-13 19:49:36 +00:00
5fe79aa986
Fix for bug 95082 - Param('shutdownhtml') doesn't completely shut down bugzilla.
...
r= justdave@syndicomm.com
2001-08-13 19:11:35 +00:00
c56dabc3aa
Fix for bug 26194: There are now substitution parameters available for use in newchangedmail which will include the reason(s)
...
that the person is receiving the mail in either an email header, the body of the message, or both. The default newchangedmail
parameter includes these in it. If you have an existing installation you will need to either hit "reset" next to the
newchangedmail parameter, or add the substitution parameters where you like them according to the instructions given in
editparams.cgi viewed from the web.
Patch by Matthew Tuck <matty@chariot.net.au> and Zach Lipton <zach@zachlipton.com>
r= justdave@syndicomm.com
2001-08-13 17:06:38 +00:00
15919620d2
Fix silly syntax error I missed.
2001-08-13 00:48:45 +00:00
210fb412d3
Fix for bug 39816: Anyone in CC, Reporter, QA Contact, or Asigned To fields can now be given access to view a bug even if the permissions on that bug are set to a group that would normally exclude those people.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-13 00:46:20 +00:00
1c10cce037
Fix for bug 95008: duplicates page no longer ignores verified INVALID/WONTFIX bugs
...
Patch by Gervase Markham <gervase.markham@univ.ox.ac.au>
r= justdave@syndicomm.com
2001-08-13 00:19:37 +00:00
76616604cb
More bug 26194: move the reason to the top of the email so that it doesn't look like part of the comment. a=dave
2001-08-12 01:11:21 +00:00
a78ae48b1a
patch for bug 26194: Header explaining reason d'etre for email in New email notification scheme.
Patch by MattyT <matty@chariot.net.au>, r=zach@zachlipton.com.
2001-08-11 23:16:16 +00:00
2d4bccef0c
Updates to README from bug 94846.
...
Patch by Matthew Tuck <matty@chariot.net.au>
2001-08-11 19:56:40 +00:00
27be6d253e
Fix for bug 94618: remove restrictions on valid characters in passwords. If crypt() takes it, why shouldn't we?
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-11 01:51:05 +00:00
3e202c2d5f
fix for bug 66235: process_bug.cgi: multiple product change misses the groupset bit. Patch by Myk <myk@mozilla.org> r=Jake, oh, and it's my first checkin, yahoo!
2001-08-11 01:18:24 +00:00
41422b4bcf
CHANGES move to "UPGRADING-pre-2.8"
2001-08-10 22:35:22 +00:00
849098f553
Compiled HTML/TXT check-in. For some reason, it keeps thinking my darn
...
dbschema.jpg file is changing, though.
2001-08-10 22:27:11 +00:00
a7c29834ca
Removal of HTML from docs temporarily due to massive renaming
...
in the latest restructuring of the Bugzilla Guide.
2001-08-10 22:15:55 +00:00
de3254008a
Checkin for 2.14 release. Still some problems; this cannot yet
...
be used for 2.14 documentation due to inconsistencies.
2001-08-10 22:13:55 +00:00
25d56d5f96
Re-fix for bug 55161 - if data is partial in activity table, prepend a ? to indicate that we don't know for sure what got dropped.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-09 06:12:18 +00:00
d7e341a8dd
Major bug in the untainting code. It seems that $1 is not cleared if
...
a pattern match fails. I need to go and explicity add lots of if then else
clauses to ensure that variables are properly clean. This unleashes a torrent of bugs. Also split the check for valid filenames into two. One checks
that each character is a valid character the other checks that
the directories which are pointed to are subdirectories of well known
directories.
2001-08-02 20:11:03 +00:00
c396b4145e
fix bug in the untainting code by splitting the checks into two parts
...
one checks for valid characters in a filename the other checks
for both valid characters and valid directories as well.
2001-08-02 20:06:02 +00:00
0cfc60c491
fix bug in untainting code by splitting up the file checks into two pieces
...
one checks for legal characters and the other checks for legal characters AND
legal directories.
2001-08-02 20:04:25 +00:00
fad5a324d4
version number had a space when the day of the month was less then 10,
...
now it has a zero.
2001-08-02 20:02:17 +00:00
9a48968d9f
change zcat to cat. don't assume that the file is compressed
2001-08-01 04:03:18 +00:00
b4c6f37786
weed out cruft. two years of data contained 5 million urls most of which were various bonsai and htdig queries. This is insane. Crop off everything in the url after a question mark. Crop off "index.html". Crop off trailing slashes except the root of the web site which is a lone slash. Added a shell script to preprocess the log data since that code was reused from another web analizer script.
2001-08-01 03:52:22 +00:00
55642aed86
Fix for bug 92713, show_activity.pl displays zeros as non-breaking spaces.
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-07-30 12:52:21 +00:00
6b213c5b12
Added support for string escaping, and shrinking (flattening) and expanding of hashes of arrays (such as the data.input.arguments hash), to COSES. These features are necessary for making the UI layer of an application.
2001-07-30 06:29:25 +00:00
73704b6765
* Abstracted out the string expander logic so that now strings have to say what string expanded they expect to be processed with (e.g., 'COSES', 'XSLT', 'Template' or whatever). This required one field 'type' to be added to every default string and a new field 'type' to be added to the string data source.
...
* Changed the COSES editor to support the abstracted logic mentioned above (note: maybe "COSES editor" is no longer an apt name...).
* Made the parseNS method of the XML service actually do something.
* Made the COSES processor namespace aware.
* Changed <coses:embed string=""> to <coses:include href="">. I was going to change it to an XInclude, but it turns out the processing model is wrong for that (XInclude, for instance, bans recursive nesting). Added support for a 'parse' attribute just like for XInclude (support three values: 'xml', 'text' and 'x-auto').
* Added columnExists() to the DBI database helper.
* Added string caching to the strings data source. Should be particularly helpful for Apache mod_perl installations.
2001-07-29 22:38:30 +00:00
7acbdf2b93
added explanations so that others may avoid installation problems I had.
2001-07-27 20:46:10 +00:00
0ea3f91c86
fixes because the default bonsai directory conventions were wrong and
...
I was not getting good treestates.
2001-07-27 20:44:45 +00:00
80385db79a
show an example of how to use the new bonsai default parameter.
2001-07-27 20:42:56 +00:00
a8b1bcf470
change the 'show next' links to 'show previous' links, too many
...
users ask me dumb questions about the future (really!)
2001-07-27 20:41:31 +00:00
fc5d0aff02
a useful example to show how to write buildcf files.
2001-07-27 20:39:18 +00:00
0a4f3289ae
errors in the system3 and the chdir are now caught and sent to the server.
...
give and example of the command line arguments.
2001-07-27 20:38:50 +00:00
9a26cf12c7
Added a hash of the user's rights to the user hash to make it easier to enable or disable UI elements
2001-07-26 03:40:56 +00:00
840a7e70c4
Added better handling for error conditions in the Database code, and fixed the 'addRight' method to use it.
...
Pasted in excerpts from the DBI man pages with sections highlighted in order to keep track of what will need fixing.
2001-07-26 00:54:37 +00:00
ea14628a29
* Added a section on common errors to Documentation.txt
...
* Added more comments to a few modules
* Changed the semantics of adding and removing user fields ("user data types")
* Implemented a factory service to perform those semantics ('registerField', 'removeField' and the convenience 'registerSetting')
* Added a missing return in the MySQL implementation of the user data source
* Added an assert in the MySQL version of 'addRight' to catch an easy error
* Added XXX comment in the MySQL version of 'addRight' (will fix this in the next patch)
* Fixed a case where sending an undefined value to the DBI database implementation would fail during the untainting
* Fixed MySQLID to actually work (in the DBI ResultsFrame)
* Fixed two typos in the user service ('settings' to 'setting')
* Added the requirement that a user must have certain rights to use the COSES editor
* Added a setupInstall implementation to the COSES editor
2001-07-25 23:54:32 +00:00
0b4e32b4e4
fix for bug 91903: insecure dependency in require in importxml.pl under taint mode only in Perl 5.005.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-25 20:12:00 +00:00
73729302e9
Fix for bug 90933: inconsistant field types for profiles.disabledtext
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-25 17:55:29 +00:00
2d8ad22f72
Mainly changes to make it compile and easier to debug:
...
* Made the start of an execution start clearer in the error log. This depends on the debug level; just makes it easier to determine what is a single execution block in a 70MB error log.
* Changed a stray semicolon into a comma, and fixed other misspellings or typos.
* Added the default strings to the CosesEditor component.
2001-07-25 09:32:28 +00:00
b653371b07
re-fix bug 76154: permissions weren't being set correctly on the .htaccess files when checksetup.pl was run again. Also adding .htaccess to .cvsignore so it won't show up as ? in cvs diffs and updates.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-07-25 07:26:42 +00:00
39493163bc
Remove the code for rejecting the version of MySQL with broken encryption (as bugzilla no longer uses MySQL's encrypt routine). Also, point to mysql.com for downloading newer versions.
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-07-23 14:33:04 +00:00
238fc00d62
re-fix for bug 55161: buglist works again if you search for change history on a bug
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-23 02:34:08 +00:00
d5d9a021f0
Fix for bug 76154: Bugzilla can now optionally provide .htaccess files for Apache to help restrict viewing of private data
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-07-22 05:23:33 +00:00
29355c8359
fix "used only once" error reported by tinderbox
2001-07-22 00:43:34 +00:00
7694170df1
Fix for bug 84714 and bug 88797: You can now change bug groups from the "change several bugs" form even if the bugs aren't all in the same groups. Also, the groups are no longer cleared when you make a change from the "change several bugs" form (unless you tell it to)
...
Patch by Joe Robins <jmrobins@tgix.com> and Dave Miller <justdave@syndicomm.com>
r= zach@zachlipton.com
a= justdave@syndicomm.com
2001-07-22 00:29:45 +00:00
76d4f8f765
Fix for bug 84714 and bug 88797: You can now change bug groups from the "change several bugs" form even if the bugs aren't all in the same groups. Also, the groups are no longer cleared when you make a change from the "change several bugs" form (unless you tell it to)
...
Patch by Joe Robins <jmrobins@tgix.com> and Dave Miller <justdave@syndicomm.com>
r= zach@zachlipton.com
a= justdave@syndicomm.com
2001-07-22 00:22:36 +00:00
2806b1c6ab
Change work email address to new company.
2001-07-20 19:05:22 +00:00
53c9483d50
Fix handling of trees other then default. This is still a bit broken
...
for the default tree, but all others work now.
2001-07-20 18:59:35 +00:00
e5debd345c
Must pass the treename through to BonsaiData.
2001-07-20 18:56:39 +00:00
ad65247cfe
Show the users that there is a treeheader_bonsai module:
2001-07-20 18:55:44 +00:00
285f9a7aaf
Update the specfiles to work with the RedHat conventions for RH 7.1.
2001-07-20 18:43:11 +00:00
387f33e515
add RedHat Package Managment (RPM) spec files. So that users of
...
this package managment system can easily deploy prepacked version of
bonsai.
2001-07-20 18:16:30 +00:00
bfb5083c70
clarify details about the installation which gave me trouble.:wq
2001-07-20 18:14:53 +00:00
9e27da07a4
Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
...
r= justdave@syndicomm.com
2001-07-20 15:18:30 +00:00
ad9910175d
Re-fix for bug 77699: the undefined error affected other browsers than just IE5, so work around it for all browsers.
...
Patch by Stephen Lee <slee@uk.bnsmc.com>
r= afranke@ags.uni-sb.de
2001-07-20 08:25:30 +00:00
b3128f1fb0
Bugzilla Bug 90704 there is a correct spelling for gobbeldygook and this is not it
...
r=terry [C=WP, A=OED]
2001-07-16 20:15:03 +00:00
7b4eabd282
Correcting the URL for MySQL's web page. Bug 90553.
...
Patch by Myk Melez <myk@mozilla.org>
2001-07-16 19:50:17 +00:00
91e042867e
Fixing minor problem caused by the original bug 77473 checkin where an SQL error was being produced if you tried to log in
...
with an invalid username.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-07-16 19:38:34 +00:00
b28e18d445
Bugzilla Bug 90598 spelling and minor syntactic correctness [doeHs]
...
r=mpt a=terry. [C=WP, A=OED]
2001-07-13 17:45:52 +00:00
7bbb20c84e
Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com , jake@acutex.net
2001-07-11 05:29:21 +00:00
69d9e7ef30
Fix for bug 87701: Invalid username in bug changes echoed back without escaping HTML data
...
Patch by Gervase Markham <gervase.markham@univ.ox.ac.uk>
r= justdave@syndicomm.com
2001-07-04 07:06:00 +00:00
221a000a29
Killing the "used only once" error that suddenly popped up out of nowhere on tinderbox.
2001-07-04 05:33:37 +00:00
54e70bd943
removing "Use Carp" and "sub die_with_dignity" that I was supposed to remove from the previous patch before checking it in.
2001-07-04 05:28:39 +00:00
15cf3536a8
Fix for bug 59349: Processmail now runs in taint (perl -T and $db->{Taint}=1) mode. Hooks also added to globals.pl to make converting other files in Bugzilla to run in Taint mode easier.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-07-04 04:41:27 +00:00
b07434e0b5
Add strikethrough to resolved bug numbers. Bug 79816. r=jake.
2001-07-01 20:17:28 +00:00
a0cc8282f1
Make bug chart filenames other-OS friendly by removing colons. Bug 88179. r=jake.
2001-07-01 19:09:29 +00:00
5959477189
Fix for bug 87596: improper definition of $::components in globals.pl
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-07-01 02:00:56 +00:00
bf9843744b
Fix for bug 76183 and bug 71555: consolidates chmod activity in one place in checksetup.pl and also provides permission setting for bugzilla installations installed in a personal user directory as opposed to the server's main web space. (makes the files world-readable so the webserver can see them, since you can't set the group)
...
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com
2001-06-29 03:47:56 +00:00
f321dcd882
Fix for but 76073: - and + didn't work in quicksearch in IE and Opera
...
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com
2001-06-28 16:27:37 +00:00
e95335dcaf
Refix bug 80289. Don't print header for groups if there aren't any groups to display (was printing a header without groups in rare instances).
...
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net
2001-06-28 15:42:30 +00:00
b89f413d7c
Fix for bug 87983: backdoor.cgi is Netscape-specific, and not part of the bugzilla package. Removing from CVS.
2001-06-28 06:49:06 +00:00
bd2fb60405
Fixing "used only once" errors flagged by tinderbox on the last checkin.
2001-06-27 02:31:55 +00:00
790d95d351
Fix for bug 80289: Group restrictions are now identified with checkboxes instead of select widgets. Also, product groups are now only offered if they are either already set, or match the current product (i.e. the option to set a product bit for a product other than the one the bug is in is no longer available) This results in much less clutter for the admin folks on sites with lots of products.
...
Patch by Joe Robbins <jmrobins@tgix.com>
r= justdave@syndicomm.com
2001-06-27 01:44:34 +00:00
276a4fa320
* Implemented dispatcher.output service in CosesEditor.pm
...
* Implemented dispatcher.output.generic service in CosesEditor.pm
* Fixed a semantic error in the string data source
2001-06-23 04:07:21 +00:00
b3fa6accc6
(this checkin comment applies to the previous checkin on this file as well)
...
* Added some comments to various files indicating work to do and documenting some methods
* Fleshed out the Strings Data Source API (and implemented it in the MySQL version)
* Added the name "MySQL" to the MySQL-specific ID method of the Database Helper
* Factored out the XML parser dependency into an XML service
* Added a generic content sink implementation to the XML service
* Added a convenience method for manipulating user settings
* Added and implemented all the COSES commands
* Removed trailing spaces
2001-06-23 00:20:22 +00:00
d21968d31c
* Added some comments to various files indicating work to do and documenting some methods
...
*
2001-06-23 00:10:43 +00:00
612f397227
Re-fix for bug 28458: AddFDef always replaces the fielddefs every time you run checksetup.pl, so the change to them during doeditparams was nullified if you updated. Other recent changes have nullified the reason for changing it in editparams anyway, so just backing that part out.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-21 15:03:11 +00:00
d0985be7f8
Fix for "used only once" error reported by tinderbox after the last checkin. (Aaargh!)
2001-06-21 02:42:41 +00:00
208706e674
Fix for bug 47914: buglist.cgi always had a not-logged-in footer if you were unlucky enough to have a login cookie that got corrupted in the shadow database. This patch makes buglist.cgi switch back to the primary database before looking up your login cookie for the footer.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-21 02:02:30 +00:00
336f1bf129
Fix for bug 86447 - ChangeFieldType() wasn't dealing with 'not null' properly.
...
r= justdave@syndicomm.com
2001-06-20 01:37:19 +00:00
1e6085864c
Fix for bug 85833: show_bug.cgi (and probably others) now allow leading or trailing spaces in the bug id, to allow for user input error. This used to work, and recent bug validation changes broke it.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-19 22:48:21 +00:00
e9d91b0a04
Fix for bug 45918: the old password field on the userprefs page is now used to log you back in if you try to change your password with cookies turned off, which avoids the confusing login screen after entering your new password in which you used to have to enter your old password one more time in order to let it set your new password (yes, it used to be as confusing as that just sounded :)
...
r= tara@tequilarista.org
2001-06-19 22:02:53 +00:00
4b69b94fcd
Changing despot owner to endico@mozilla.org with her permission
2001-06-19 04:04:34 +00:00
1a56480df1
Running a query using the Added Comment option was very slow (bug 57350).
...
Patch by Myk Melez <myk@mozilla.org> and Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-19 02:05:08 +00:00
06a95c3b47
Refixing bug 71396. Each PushGlobalSQLState() needs a PopGlobalSQLState() and this file instead had two "pushes".
2001-06-19 01:37:02 +00:00
b56688d21e
Allow '\' as a path delimiter (bug 29064)
...
Patch Concept by <timeless@mac.com>
r= jake@acutex.net
2001-06-18 23:13:18 +00:00
46dd08d79f
Fix for bug 85832 - QuickSearch should strip leading and trailing spaces.
...
Patch by Andreas Franke <afranke@ags.uni-sb.de>
2001-06-18 19:24:17 +00:00
7d0248c021
applying handy patch to refix version table to be 64 instead of 16--partial fix of bug 9352
2001-06-16 23:01:12 +00:00
583e8ba725
Fix for bug 71396 - $::db->do isn't needed anymore
...
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net
2001-06-16 14:51:16 +00:00
4c159e297e
Fix for bug 83619 - QuickSearch was crashing Netscape 4.76 and 4.77 on Unix
...
Patch by Andreas Franke <afranke@ags.uni-sb.de>
2001-06-15 20:16:59 +00:00
aced5efdec
Checking in the cleaner version of the fix for "No Available Products". This was attached to bug 65311.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-14 20:02:31 +00:00
11d8239204
Backing out previous changes as there was a better patch already attached to a different bug
2001-06-14 20:00:03 +00:00
c52c3207f3
Bugzilla shouldn't display empty header in the New: email notifications (bug 85734)
...
r=timeless
2001-06-14 14:16:27 +00:00
d12c665fae
Fix for bug 84596: Syncshadowdb wasn't using the db_user and db_pass from localconfig, which meant that it previously wouldn't run unless it was running under a user that had access to the bugs and shadowbugs dbs and didn't have a password. It now looks for db_user and db_pass and specifies them on the command line to mysqldump and mysql if they're in use.
...
r= tara
2001-06-10 17:38:15 +00:00
0caf63ff4b
Re-fix for bug 21253: fix calling conventions for syncshadowdb so that a phony parameter to get past the multi-param system() test in tinderbox actually works.
...
r= tara
2001-06-10 17:15:56 +00:00
f3b1e25aea
Give a logical error message if no products are available to a user for bug entry (bug 84285).
...
Patch by Paul Thomas <paul.thomas@sse.ie>
r= jake@acutex.net
2001-06-08 13:12:13 +00:00
89f9bad83e
Hopefully the fix for bug 77778: component lists, etc stuttering due to corruption in data/versioncache.
...
Patch design by Terry Weissman <terry@mozilla.org>
Patch implemented by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-07 21:26:49 +00:00
e5c14c816c
Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-07 20:26:40 +00:00
88476cc75c
fix typo
2001-06-07 01:31:51 +00:00
8da17e3922
Fix "used only once" error, per tinderbox build log.
2001-06-06 23:09:54 +00:00
6a4944b94c
Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
...
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
2001-06-06 21:17:42 +00:00
fa59d128b6
Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the DBD::mysql Perl module, and has been this way for a while. Fixing the version checks in checksetup.pl to check the correct module. Also eliminates a DBD::mysql-specific database function call that is depricated in the current version of DBD_mysql.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net , tara@tequilarista.org
2001-06-06 21:10:47 +00:00
48ffd8c640
Users should only be able to view attachments if they can view the bug that the file is attached to (bug 70189)
...
r=tara
2001-06-06 18:36:25 +00:00
79fc592bf7
Fixing typo. Attachments isn't spelled 'Attachemnts' (bug 84295).
2001-06-06 14:25:18 +00:00
7337f9ee7a
Fix for bug 39557: doeditvotes.cgi will no longer create a vote record for a nonexistant bug if the HTML is tampered with or other bugs cause bad bug numbers in the submitted form.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 04:51:55 +00:00
16951bbe32
Fix for bug 82781: describecomponents.cgi now checks viewing permissions to make sure you can see a product
...
Patch by Myk Melez <myk@mozilla.org>
r= tara@tequilarista.org
2001-06-06 04:32:45 +00:00
1e4536e632
Fix for bug 28458: "NEW" bugs were not getting CC or QA Contact information displayed.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-06 04:28:52 +00:00
72e876fa2d
Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it).
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-06-06 03:16:52 +00:00
b0ae801a6f
* Improved the helpfulness of the extremely verbose debugging information of PLIF.pm by quoting embedded variables
...
* Implemented MagicCollectingArray, which acts like MagicPipingArray except that the result is collected into one big array instead of multiple arrayrefs
* Added the relevant getCollecting*List methods to the Controller class
* Added DESTROY methods to the magic array to prevent DESTROY method calls from being propagated
* Made the debug.dumpVars string more robust when the data hash includes one of the three magic characters '(', '.' or ')'
* Implemented sanitation in COSES so that any keys in the data hash containing one of the three magic characters '(', '.' or ')' will have them transliterated to '[', ':' and ']' respectively (sanitation is optional and can be bypassed)
* Changed the API of the generic output module's 'output' method to take the optional $session argument last, thus simplifying the call sites a lot
* Implemented the 'dispatcher.output' service in several classes to return strings that must be support in variants (required for a good UI in the COSES editor)
* Renamed the Login module's strings so that they use the dot-notation separating significant parts
2001-06-04 06:13:22 +00:00
008ca7535f
Stub implementation of a COSES editor component, plus added 'component.nameOfComponent' to the list of services provided by the other two components
2001-06-03 23:06:09 +00:00
4e83d4d77b
Moved AdminCommands.pm and Login.pm to a Component directory
2001-06-03 22:45:37 +00:00
eb1fb18fb5
Minor bug fixes required to make the code run without crashing...
2001-06-03 16:14:41 +00:00
17da5d7b8a
Some more minor corrections to get it to run as well as compile... (removes some XXX comments and adds some error checking)
2001-06-03 15:27:16 +00:00
f71bddbcc2
Fixing a gazillion syntax, logic and XML errors and adding some debug code. It compiles!
2001-06-03 14:49:41 +00:00
0157ac85b3
* Added some comments (including some XXX comments where I realised we had missing code)
...
* Added implicit data to the hash passed to the string expander from the generic output service
* To support the implicit data, added a |hash| stub method to the Session.pm module (and changed the already implemented version in the descendant user service to take this into account)
* To support the implicit data, added |hash| and |getArguments| methods to the Input.pm module (and implemented |getArguments| in the Arguments.pm module)
* To support the implicit data, made the Program.pm module keep track of the executing command
* To support the implicit data, added |hash| and |name| methods to the Program.pm module (actually, |name| was already assumed to exist in other parts of the codebase)
* Corrected trivial semantic mistake in Program.pm's |verifyInput| method
* Added a way to get a user not by username but by a specific address (modifies the user service and the user data source and it's MySQL implementation)
* Implemented GenericOutputs.pm, an implementation of 'dispatcher.output.generic' and 'dataSource.strings.default' for some strings used by other parts of PLIF (currently only supports 'stdout' and 'http' protocols, and minimally at that)
* Implemented Login.pm, a helper module that implements user authentication, user creation and the sending of a new password if it is forgotten, a utility method |hasRight| to ensure that the authenticated user has a particular right (resulting in a message if not), and various routines to support all this.
2001-06-03 10:11:58 +00:00
71c26619d6
Landing Myk's patch for bug #71767
2001-06-02 22:02:02 +00:00
7e84b3b87a
sanitycheck.cgi was able to be run by anybody - even people without Bugzilla accounts. It is now restricted to only people with the editbugs permission (bug 54556).
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-02 14:24:45 +00:00
bf46713283
Fix for bug 65190: add comparison type "all words as substrings" and "any words as substrings" to the text fields in query.cgi
...
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com
2001-06-02 04:02:13 +00:00
6887947dcb
Fix for bug 78407: extra safeguard against overpopping the email list when pruning people who aren't supposed to get mail.
...
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-06-02 03:19:26 +00:00
c6f5cbc4aa
Fix for bug 83596: optional dependency on XML::Parser now checked in checksetup.pl
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:57:22 +00:00
16c44fa582
Fix for bug 83618: checksetup.pl crashes if DBI module isn't already installed.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-02 01:53:01 +00:00
40da63cff5
More leak pluggin. This one fixes bug 39526.
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-06-01 13:38:01 +00:00
6e938b4597
Fix for bug 83633: perl warnings in 5.6
...
r= Hixie
2001-06-01 10:03:52 +00:00
53e52cbe8b
Fix for bug 73249: perl warnings under 5.6.0.
...
Patch by Chris Yeh <Chris.Yeh@nokia.com>
r= justdave@syndicomm.com
2001-06-01 08:34:45 +00:00
1b32170af6
Fix for bug 79317: dependency on CGI::Carp not caught by checksetup.pl
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-01 03:13:28 +00:00
db91c9e3ba
backing out previous fix to importxml.pl. It fixed it on Perl 5.6 and broke it on Perl 5.005. Will need to investigate.
2001-06-01 02:27:52 +00:00
63ca1160dd
Fix for bug 72862: fixes more Perl warnings in RelationSet.pm and globals.pl
2001-06-01 02:14:23 +00:00
f1b8abb8a9
Fix for bug 57848, perl warnings in several files.
...
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= justdave@syndicomm.com
2001-06-01 02:07:28 +00:00
8d91c20844
* fixing some syntactic errors
...
* added addUserGroup and removeUserGroup to the data source interface for users
* added some comments
* changed many double quotes |"| to single quotes |'| where double quotes were not needed
* implemented the remaining methods for the MySQL implementation of the user data source
* added a mode flag to user fields (idea from MattyT) so that fields can be disabled, hidden, etc
2001-06-01 00:32:35 +00:00
e5f7a1dd6e
Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
...
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net
2001-05-31 15:52:25 +00:00
277b5d0fd0
Bug 80388 - cvsblame shouldn't require layers for popups
...
r=baloo
2001-05-30 22:13:03 +00:00
477a26a860
Fix for bug 45164 - New users created by the admin were not subject to the userregexp for groupsets.
...
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net
2001-05-30 15:47:30 +00:00
e5bf5d6659
Dummy commit so I can put the attributions I forgot in the previous one.
...
Patch from bug 65290 was by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-29 21:27:12 +00:00
d7cf4940e2
Fix for bug 65290: can now edit user-regexps for system groups
2001-05-29 21:25:02 +00:00
f09e634284
Change the semantics of address changing, making it faster, smaller, simpler, and better. Aaah... :-) In the new system, instead of cloning the current $session object to pass it back to the output code, you pass the real $session object to the output code, just making sure that the relevant field has been warned to return a different address than found in the database.
2001-05-29 20:34:12 +00:00
1f0393f665
Fix for bug 65399: Can't use string ("") as an ARRAY ref while "strict refs" in use at query.cgi due to no components defined in a product.
...
Patch by Matthias Radestock <matthias@sorted.org>
r= justdave@syndicomm.com
2001-05-29 20:30:51 +00:00
5d428e80a4
Additional cleanup for bug 73191. newquip.html is no longer needed.
2001-05-29 18:44:00 +00:00
97310affb6
Adding some XXX comments regarding a known bug (when the user is changing their address, fields try to update the database before the new address has been authenticated)
2001-05-29 09:11:33 +00:00
c769c615d1
* Fixing a minor bug in the MySQL implementation of the string data source
...
* Started implementing the MySQL version of the user data source (completed so far: database creation and a few of the SELECT calls)
* Changed the user property 'disabled' to 'mode' to enable extensibility
* Fix a potential bug with changing addresses (make sure the fake session object doesn't update the database -- this is an incomplete solution so far, fields still have the bug)
2001-05-29 09:07:10 +00:00
65b58b6d44
Fix for bug 78045: change references to README in error messages to point to the Bugzilla Guide instead.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com
2001-05-29 08:10:28 +00:00
add36de033
Landing quips.cgi (bug 73191) by Owen Taylor <otaylor@redhat.com>
...
Submitted by Martin Baulig <baulig@suse.de> from bugzilla.gnome.org
r= justdave@syndicomm.com
2001-05-29 04:01:48 +00:00
54b8850bf6
Fix for bug 77699 and bug 71503: fix javascript errors in quicksearch and improve IE5 compatibility
...
Patch by Stephan Lee <slee@uk.bnsmc.com> and Andreas Franke <afranke@ags.uni-sb.de>
2001-05-29 03:05:46 +00:00
ad978537ad
* Moving 'type' to the front of the list of things returned by the User data source's 'getField*' methods so that they map more directly to the user field constructor arguments
...
* Moving 'typeData' around in the order of the user field constructor arguments to match the User data source's 'getField*' methods so that, again, they map more directly
* Renaming the 'getFieldFrom*' methods to 'getFieldBy*' to be consistent with 'getUserBy*'
* Implemented UserFieldFactory.pm
* Implemented Passwords.pm
2001-05-28 23:43:56 +00:00
f285f118ae
* Correcting a typo in Input.pm
...
* Added a comment to DataSource/User.pm explaining how (typically) to search for a username
* Fleshed out the DataSource/User.pm API by adding some schema management methods
* Added notes on which fields in the database schema should be keys
* Added comment to Service/User.pm noting the difference between Objects, Services, and Service Instances
* Changed 'user.field.factory' to 'user.fieldFactory' to prevent a namespace collision with 'user.field.(type)'
* Calling 'insertField' in one case which I missed when adding the method
* Implemented 'hash', 'joinGroup', 'invalidateRights', 'writeProperties' and 'writeGroups'
* Changed Service/UserField.pm so that one user field class can be used for any category
* Added a 'username' convenience method and implemented 'write'
* Added a comment to Service/UserFieldFactory.pm explaining how it should work
* Removed the 'user.field.generic.generic' field implementation, replaced it with a simpler 'user.field.string' implementation
2001-05-28 20:09:23 +00:00
70066ead27
Bug 79739 - Initial Owner and QA Contact were not being handled correctly by the email interface after they were changed to userid's in bug 66876.
...
r= justdave@syndicomm.com
2001-05-25 12:48:47 +00:00
748983d1a8
Mention the Bugzilla project page and where to report bugs
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com , jake@acutex.net
2001-05-24 12:58:33 +00:00
246e57a096
Added some minor corrections and clarifications to the documentation.
...
Added some comments to various user-related files.
Factored out some code that started becoming common when inserting fields in Service/User.pm.
Added code to deal with adding new contact details.
Added code to support removing fields from a user.
2001-05-24 07:06:41 +00:00
37ee78c2b6
62446 extra spaces inside links on some lxr-generated pages
...
r=terry
2001-05-24 04:10:23 +00:00
29836c8973
45785 Swapped ALIGN/VALIGN attributes
...
39224 duplicate word on lxr.mozilla.org/ ("use use")
r=terry
2001-05-24 04:07:43 +00:00
097ab228ca
Bug 71552 - Remove oldemailtech from Bugzilla
...
r= justdave@syndicomm.com
2001-05-24 03:10:49 +00:00
8238de6157
Started work on fleshing out the user components. This is still work in progress.
2001-05-14 06:45:08 +00:00
4120888dd9
Initial checkin of the Field part of the User work. Just ideas at the moment, nothing here is implemented, and much of it is likely to change.
2001-05-13 20:54:35 +00:00
2d1db306ca
First pass at adding User objects (derived from Session). Lots of XXX code -- none of this works, it's basically all stubs.
...
In addition to the code that actually does stuff, I still need to add a MySQL implementation of the data source and the Field class and its associated Factory.
Also added Passwords.pm (stubs for a password generator and encryptor) and made Session objects store a pointer to the controller object.
2001-05-13 18:11:54 +00:00
c5aa38e236
Added a bit more support for objects (as opposed to services): added a new objectCreate() constructor and an objectInit() method.
...
Added an optimisation to Controller.pm so that service names will be hashed once accessed. This should make multiple accesses of the same service a lot quicker. To go with this I added some diagnostics code (on exit) and moved the code around a little bit.
Fixed a minor transgression of the coding style guidelines in Magic*Array.pm. :-)
Neatened up the code in Output.pm.
Made it so Session objects assume they have an 'app' property, and so don't need to be passed $app all the time. (Sessions are objects now.)
Added an unimplemented getAddress() method to the Session class.
2001-05-13 18:04:52 +00:00
b19846e219
fixing two rather serious (albeit simple) bugs in the strings data source; adding a comment to Input.pm in preparation for doing the user authentication stuff
2001-05-13 05:52:24 +00:00
52d319efbd
Fix for bug 38859: escape invalid email addresses for HTML before displaying to the user.
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net , justdave@syndicomm.com
2001-05-11 18:02:38 +00:00
9c2c47cd80
Fix for bug 80045: 500 Server Error in IE (but not Netscape or Mozilla) on errors looking up email addresses.
...
Patch by <jake@acutex.net>
r= justdave@syndicomm.com
2001-05-10 18:16:51 +00:00
e2700ba982
Fix for bug 38854: reports.cgi needs to escape (untrusted) url params
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-05-10 03:02:52 +00:00
4addc2a9a8
Fix for bug 38855: showvotes.cgi needs to escape (untrusted) url params
...
Patch by Myke Melez <myk@mozilla.org>
r= jake@acutex.net
2001-05-10 02:53:22 +00:00
d5ede4c824
Fix for bug 79730: Minor minor typo in move.pl (recieve -> receive).
...
Patch by gavins@iplbath.com (Gavin Shelley).
r= justdave@syndicomm.com
2001-05-09 18:32:35 +00:00
14cee70f2a
adding some progress messages to the setup output; making COSES more resilient to invalid input
2001-05-08 00:05:42 +00:00
521f6ccd5f
Slight changes to make output code more flexible
2001-05-07 07:04:17 +00:00
ccf7da49f7
* fixed the methodMissing() method so that it actually is possible to use it to do method dispatching;
...
* factored out some of the method dispatching code by adding a dispatchMethod() method to the controller;
* turned the Dispatcher class into simply a function on the base Service class and removed Dispatcher.pm;
* made it possible for services to be both services and objects and provide different services depending on which context they were called in (and used this to make the AdminCommands module actually do what it was intended to in the first place, namely, only work for CommandLine access);
* fixed it so if a service is first created by getServiceList the constructed version will actually be cached;
* made output more generic by allowing services to implement arbitrary parts of the output API, used that to make AdminCommands usable without requiring additional code to support it;
* added some documentation;
* added some dump(10) statements to help debugging;
* fixed the string datasource SQL;
* fixed the DBI database so it can handle errors;
* added tableExists API to the DBI database helper.
Thanks to myk, justdave and zach for some ideas.
2001-05-06 06:26:24 +00:00
c1358435d5
Made the lack of a configuration file be non-fatal (and factored out the low level code while I was at it). We need that so that the configuration data source can actually go in and create the configuration file if it is missing; otherwise the program exits with "no configuration file! waah!" before you get to the configuration-file-creation code!
2001-05-05 19:00:06 +00:00
145a175901
Implementing (and documenting!) PLIF::debug() as suggested by zach. a=hixie
2001-05-05 18:28:08 +00:00
8ed0eabc73
work in progress
2001-05-05 07:12:56 +00:00
ace6939d80
Blatantly copied http://scarab.tigris.org/scarab-design.html and changed it to suit Bugzilla
2001-05-03 10:57:46 +00:00
c95e89d881
Creating new Bugzilla 3 directory. Nothing to see here yet!
2001-05-03 10:41:12 +00:00
3db33a040e
Fixing various typos and spelling mistakes spotted by timeless. There shouldn't be any code level changes here. moa=hixie
2001-04-29 08:35:29 +00:00
18444287d2
rolling version number to 2.13 for development
2001-04-27 19:36:20 +00:00
42939fefb9
addition to 2.12 release notes
2001-04-27 19:32:27 +00:00
58f3eab2ff
Fix for sendmail daemons that don't support EHLO. We never use the extended
...
functionality anyway, so replace it with a standard HELO. Thanks to Ken Key for
helping me track this down.
2001-04-26 22:53:20 +00:00
c392e83131
Backing out .htaccess commit, these don't belong here yet. It broke checksetup.pl, too.
2001-04-26 04:16:03 +00:00
07f20503cf
Added .htaccess files for shadow/, data/, and /.
...
I added related information to the Bugzilla Guide, and
tacked in a couple of last-minute additions. Also fixed the
annoying "Tip: HINT:" thing.
2001-04-26 01:51:59 +00:00
960946be09
Tara is a bucket head. Floating version to 2.12 ship for tag and stripe
2001-04-25 15:45:27 +00:00
232c86701a
Removing forward planning text
2001-04-25 15:38:34 +00:00
5962891e51
Fix for confusing language regarding protection of data/ & shadow/ directories
...
and localconfig file.
2001-04-25 07:38:24 +00:00
20e2d3f554
Updated Bugzilla Guide and README to fix bug 76156, bug 76841, and bug 26242.
...
The README is now gutted, pointers to Guide. Also some new sections added,
old ones fixed, and notes appended to deprecated sections I've not yet had
the heart to remove.
2001-04-25 07:12:20 +00:00
4d29f9449f
Checking in the last of the changes for 76837 for 2.12. Good enough for government work.
2001-04-23 22:16:12 +00:00
10f7c757c2
README now points everybody to the release notes and the new user guide
2001-04-23 22:14:50 +00:00
4a768a4662
Changing release numbers to 2.0 to match mozbot version number.
2001-04-23 07:09:20 +00:00
ef86cfa4d4
Updating mozbot to version 2.0: changed to a more modular architecture, added support for multiple channels, added support for multiple nicks, generally cleaned up the code, etc. Uses some code and ideas from timeless and zach.
2001-04-23 07:07:17 +00:00
d725a5f0ed
updated url to stats on mothra
2001-04-23 06:02:59 +00:00
96371cef8e
Adding reference to data/comments needing to be an exception to the blocking of the 'data' folder.
2001-04-22 18:56:58 +00:00
74918a074d
Checking in Matty's update to the release notes
2001-04-22 18:48:04 +00:00
1a53f658ba
Added a couple of lines about mysqld-watcher.pl. Bug 76862.
2001-04-22 18:13:40 +00:00
5fc70a1c81
Per bug 76862, moving mysqld-watcher.pl into contrib
2001-04-22 17:48:12 +00:00
59aef0d98d
Lots of formatting fixups, removed tab characters. Also removed incorrect DB_File requirement.
2001-04-22 17:26:35 +00:00
912600377c
Fix bug 76524 - mostfreqhtml param text has a few issues. Patch by matty@chariot.net.au .
2001-04-22 16:44:10 +00:00
9fc65d6dfe
column change from when to ci_when a long time ago. make repophook.cgi
...
match database schema
2001-04-21 00:10:39 +00:00
6b6a3cfe83
Checking in massive changes to make this document more generic to all bugzilla installations
2001-04-20 22:08:09 +00:00
e2bb9e2554
Adding new Release Notes for MattyT
2001-04-20 16:46:59 +00:00
e2352e2bfe
another chmod with a leading 1 (Perl interprets this as a decimal instead of octal)
2001-04-20 14:41:44 +00:00
799f38f2c4
Changing all chmod 1777 to chmod 01777. Without the leading 0 it's interpreted as decimal instead of octal (oops)
2001-04-19 20:46:53 +00:00
1e20598db4
Bullshit checkin to add the fact that the previous changes also include the final fix for bug 72721. I am a buckethead
2001-04-19 17:35:23 +00:00
jake%acutex.net
zach%zachlipton.com
myk%mozilla.org
justdave%syndicomm.com
kestes%walrus.com
barnboy%trilobyte.net
gerv%gerv.net
rginda%netscape.com
endico%mozilla.org
ian%hixie.ch
timeless%mac.com
dmose%mozilla.org
tara%tequilarista.org
Chris.Yeh%nokia.com