f1efc20ae6
Bug 213602: Switch some users of NS_GetWeakReference over to do_GetWeakReference. r=bzbarsky, sr=dbaron
2003-07-25 19:06:59 +00:00
7318257470
Remove comment made obsolete by previous checkin.
2003-06-29 23:39:54 +00:00
55a49cd4d6
Ongoing deCOMtamination. r+sr=dbaron
2003-06-29 03:43:05 +00:00
9b1d1eed2b
Add nsIFrame::GetPresContext, which gets the pres context from the rule node which it gets from the style context. DeCOMtaminate nsStyleContext::GetRuleNode, nsRuleNode::GetRule, and nsRuleNode::GetPresContext. Remove unused nsRuleNode::PathContainsRule. b=208190 r+sr=roc
2003-06-20 01:22:44 +00:00
6d22d3c842
Fixing DEBUG-only bustage.
2003-06-20 00:54:57 +00:00
adce84c7af
Remove |aPresContext| and |aPresShell| parameters from |nsIFrameManager| methods. b=208190 r+sr=bzbarsky
2003-06-19 23:52:58 +00:00
42b06cc4f5
DeCOMtaminate nsIFrame::GetView and SetView, and add HasView, GetClosestView, and AreAncestorViewsVisible to consolidate common patterns. b=208004 r+sr=roc
2003-06-19 23:44:01 +00:00
46aba0f3e8
Handle state and attribute changes on elements without frames more efficiently, and keep the undisplayed map up to date. b=209733 r+sr=bzbarsky
2003-06-18 21:54:51 +00:00
ba75de772b
Bug 209087
...
Content interface out-parameters should use ptr-to-ptrs instead of ref-to-ptrs and some small deCOMtamination.
r+sr=jst@netscape.com
2003-06-13 20:10:01 +00:00
1decc3f74c
Bug 203960: Make bookmark groups replace existing tabs instead of appending. r=jkeiser, varga, adamlock, sr=jst, hewitt
2003-05-30 00:21:01 +00:00
149f719c00
bug 100649: Length() being used where IsEmpty() is meant
...
treewide changes to convert incorrect usages of string.Length() to string.IsEmpty().
thanks to afatecha@idea.com.py (Ariel Fatecha) for the patch. r=dwitte, sr=jst.
got the ok from Asa to land into a closed tree.
2003-05-23 21:34:47 +00:00
d9f7fd70f9
Fixes CantRenderReplacedElementEvent memory leak. b=203596, r+sr=dbaron, a=asa@mozilla.org
2003-05-17 01:10:50 +00:00
a15b9f2cf4
Clean up API (and its callers) for getting style data: remove unneeded null checks and switch to new inline member functions (one for each struct) that return values. b=197205 r+sr=roc a=brendan
2003-05-15 03:42:21 +00:00
42d3112d35
Don't check for :before/:after on frames that have pseudo-style-contexts. Bug
...
202917, r+sr=dbaron
2003-04-23 00:43:03 +00:00
1d9d07a002
Make nsCSSFrameConstructor::AppendFrames be smarter about looking for :after
...
pseudos. Move some utility functions into nsLayoutUtils; simplify some places
that basically had copies of those functions. Improves perf a bit in bug
145425 and its dependencies, r+sr=roc+moz
2003-04-21 23:06:40 +00:00
f2dc5c2442
Bug 126263. Whack comboboxes/listboxes to use Gfx scrollbars. Also, make scrollbars attach their XBL content only when they become visible, to avoid pageload hit. r+sr=dbaron
2003-04-08 20:50:57 +00:00
618e66b5eb
ComputeStyleChangeFor does not need to put all the in-flows into the
...
changelist. Propagate the "current" toplevel change as the min change as we go
down the in-flow and special sibling list. Bug 166205, r+sr=dbaron
2003-04-03 21:51:06 +00:00
925955c81d
landing attempt #2 for 195262 - support for static atoms, and converting atoms over to UTF8 to reduce bloat - now without performance regressions!
...
sr=darin, r=dbaron
2003-03-25 18:55:59 +00:00
16af458ceb
backout my static atom patch for now until I figure out the performance loss! :(
...
bug 195262
2003-03-21 20:13:08 +00:00
c4ea07bc53
fix for bug 195262:
...
- convert atoms to UTF8 because 99% of the time, that is what they are used for
- add support for static atoms, where the strings are declared in a large const array and not copied into the heap
r=dbaron, sr=darin
this is an experimental landing - if there are performance issues, I will back it out.
2003-03-21 06:26:32 +00:00
b3d575fd9b
Fix for bug 195153 (Remove bogus 'extern' decls from NS_New* functions.). Patch by jst, r=sicking, sr=peterv.
2003-03-05 15:08:41 +00:00
8cd3e31161
Fix leaks introduced from bug 114713 (bug 194468). r/sr=dbaron.
2003-02-22 22:21:20 +00:00
c32b76ad84
Replace nsIStyleSheet::AttributeAffectsStyle with nsIStyleRuleProcessor::HasAttributeDependentStyle. Strengthen the attribute optimization and apply it to HTML as well. b=163556 r+sr=bzbarsky
2003-02-22 16:10:53 +00:00
cc390fbe51
Remove nsIStyleContext (bug 114713), r/sr=dbaron. Changed lots of methods to use nsStyleContext* or already_AddRefed<nsStyleContext> as return values, depending on whether a reference is returned. Turn on nsRefPtr (bug 104346), and change nsDerivedSafe to not declare AddRef and Release explicitly virtual, r=jag, sr=dbaron.
2003-02-22 00:32:13 +00:00
c51fe8f39d
Fix crash (and refix other crashes in a cleaner way) by making UndisplayedMap own references to content nodes, just like frames do. b=161304 r+sr=bzbarsky
2003-01-21 00:47:14 +00:00
1419b5fd03
Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag
2003-01-08 21:19:10 +00:00
712030493b
ReResolveStyleContext needs to deal with :before/:after pseudos correctly. Bug
...
126072, r=dbaron, sr=roc+moz. Also fixes bug 141259 (incorrect warnings about
style tree integrity).
2003-01-05 05:05:17 +00:00
6c504f96e1
Make GetType() return int instead of nsresult (bug 167762), r=peterl@netscape.com, sr=kin@netscape.com
2002-12-18 23:38:09 +00:00
d6801ac37b
bug 127286 (part II due to cvs problems) - Handle splitting of floaters when lines impacting them are outside the block containing the floaters. sr=kin, r=alexsavulov
2002-12-04 00:58:52 +00:00
8fa4129fc1
Bug 8929: Kill NS_COMFALSE
...
r=peterv sr=bz
2002-11-25 11:21:22 +00:00
b2f992acb9
Consolidate all CSS pseudos and split them into three atom lists to distinguish between pseudo-classes, pseudo-elements, and fake-pseudo-elements used for anonymous boxes. b=147887 r,sr=roc,bz
2002-11-17 15:37:56 +00:00
5f0c6d63b3
Fix ReplaceChild() on positioned inlines to delegate to
...
nsAbsoluteContainingBlock.h. Bug 176915, r=dbaron, sr=rbs
2002-11-12 03:30:13 +00:00
a272a96238
Make GetParent on nsStyleContext return an
...
already_AddRefed<nsIStyleContext>. Bug 171808, r=jkeiser, sr=dbaron
2002-10-09 01:46:15 +00:00
f228a4da79
Fix some inline-block style-resolution issues. Bug 146409, r=kin, r=dbaron
2002-09-12 20:33:11 +00:00
c5e8f896cd
166917. Clean up xpcom SDK includes. r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com
2002-09-07 17:13:19 +00:00
c0c4d81870
Bug 160936. Add type nsChangeHint for style hints. Make it a set of bits. Make sure an NS_STYLE_HINT_REFLOW always also does a repaint of the frame. r=dbaron,sr=kin
2002-08-24 14:41:28 +00:00
606046a85d
Fix XUL style attribute change regression by making |#ifdef MOZ_SVG| code the default, but moved elsewhere. b=163481 r=bbaetz sr=bryner
2002-08-22 00:01:30 +00:00
f6620a390b
Rearrange how layout history keys are created (bug 162409), r=sicking@bigfoot.com, sr=bzbarsky@mit.edu
2002-08-13 17:14:18 +00:00
67c83f1ac3
Fixing bug 152927: can't script any plugin in nested EMBED tag inside an OBJECT tag from onLoad handler -- CNET radio does not play with Real because SetSource is called from onLoad r=kmcclusk sr=dveditz a=asa
2002-07-26 03:48:24 +00:00
167827f3d1
Make save/restore work for all forms, not just the first (bug 138892), r=rods@netscape.com, sr=attinasi@netscape.com, a=asa
2002-07-16 22:38:51 +00:00
937c8ec244
Bug 144479 (crash changing display prefs on pages with position:fixed
...
stuff), r=dbaron, sr=jst
2002-06-28 23:25:57 +00:00
5ef2ac2f34
Fixing bug 134278. Die kNameSpaceID_HTML, die! r=sicking@bigfoot.com, sr=heikki@netscape.com
2002-05-20 22:47:02 +00:00
11791125b2
Attempt to refix bug 118014 crash by removing SetUndisplayedPseudoIn and doing run-time checks that we're not inserting the same node into the undisplayed map twice. b=136704 r=attinasi sr=waterson
2002-05-16 13:30:57 +00:00
22f523a65f
Remove ClearUndisplayedContentMap hack from ReconstructStyleData (expanded for bug 118014; see bug 136728). Fix multiple content inserted notifications from XBL (the real cause of bug 118014) by checking the undisplayed content map in addition to the primary frame map. Fix FrameManager::GetUndisplayedContent to work correctly, and remove code in nsCSSFrameConstructor::AttributeChanged that was working around its brokenness. b=136704 sr=waterson r=attinasi
2002-05-01 00:36:50 +00:00
699befb430
Backout some diagnostic code. b=134962 sr=waterson r=dbaron
2002-04-14 15:16:40 +00:00
36e043ab43
Attempt to fix topcrash bugs, possibly due to stale cached lookup undisplayed entry (that part by dbaron). Also added some artificial branching to help narrow the problem should crash persist. b=118014 r=attinasi/dbaron, sr=kin a=asa (drivers)
2002-04-02 21:14:43 +00:00
93f1c722f2
Remove |aForceUnique| parameter from style context resolving methods, and corresponding flag from nsStyleContext, since the only caller was ReResolveStyleContext (on the assumption that other callers used it). Allow ReResolveStyleContext to benefit from FindChildWithRules and allow it to re-resolve to the same tree even when called on the root style context. b=133821 r=attinasi sr=hyatt a=asa
2002-03-31 16:59:00 +00:00
b01dbbab15
Move save/restore form control state to content (bug 108309). r=rods@netscape.com, sr=jst@netscape.com, a=asa@mozilla.org
2002-03-31 10:14:01 +00:00
24891ed355
Backing out 108308 due to pageload spike
2002-03-29 07:35:09 +00:00
7ad9388e68
Move save/restore of form controls to content (bug 108309) (r=rods@netscape.com, sr=jst@netscape.com, a=asa@mozilla.org)
2002-03-29 05:35:47 +00:00
43acd755dd
Fix 2 cases where ReResolveStyleContext was broken, causing serious problems with dynamic style reresolution. Change nsIFrame::GetStyleContextProvider to GetParentStyleContextFrame, always use its result rather than using the parent frame in some cases, and move a bit of the complexity into the GetParentStyleContextFrame implementations. Fix block-within-inline case (bug 129350) using a special-previous-sibling frame property and ensuring that NS_FRAME_IS_SPECIAL is copied when frames are split. Fix out-of-flow frame case (bug 88154) by going to the placeholder map and by parenting the placeholder frame style contexts to the style context from their frame parent rather than the out-of-flow frame. b=129350 r=attinasi sr=hyatt a=asa
2002-03-27 02:38:13 +00:00
95771efc1f
Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa
2002-03-23 22:26:36 +00:00
c58b010410
Be sure to initialize out-param no matter what. b=127360 r=aaronl sr=brendan a=asa (drivers)
2002-03-19 00:32:41 +00:00
594643207c
Remove obsolete NEW_CONTEXT_PARENTAGE_INVARIANT ifdefs, and add a few bits of debugging code. b=120888 sr=attinasi r=bzbarsky a=asa
2002-03-16 15:26:56 +00:00
1c7d65563f
bug 92868 - Simplified the style context provider mechanism, changed frame manager to re-resolve the provider first and to use correct style context in a few other places. a=roc, sr=attinasi, r=dbaron.
2002-03-12 15:21:35 +00:00
1c26ad6bf0
Bug 129628. Crash in nsFrameManager::Destroy. r=dbaron, sr=shaver, a=asa
2002-03-10 06:47:42 +00:00
9741f3f2e0
reversion of patch for 92868, to repair severe regression (129827, a=drivers
2002-03-10 06:16:01 +00:00
82d9323758
bug 92868 (also bugs 51037, 90960, 91443) - Simplified the style context provider mechanism, changed frame manager to re-resolve the provider first and to use correct style context in a few other places, sr=roc, r= bernd, a=asa.
2002-03-08 15:34:33 +00:00
14ec465e0d
Fix invalid optimization that prevented style changes on inline elements that caused a reflow from applying to more than the first line. b=98783 r=attinasi sr=hyatt
2002-02-16 16:31:49 +00:00
b3b11b7aec
Do restoration of information in the layout history state immediately after frame initialization rather than using separate code within PresShell::ContentAppended that calls GetPrimaryFrameFor (which is slow and forces every frame into the primary frame map, inefficiently). b=109428 r=rods sr=waterson
2002-01-11 20:10:46 +00:00
14dbf6e625
Fix tabbing through image maps and fix Windows crash right-clicking on image maps by reverting my changes to nsImageMap from bug 110911 and by giving the primary frame map larger entries to accomodate mapping from a content node to a frame with a different |mContent|. b=115481, 114377 r=bryner sr=attinasi
2002-01-05 15:22:52 +00:00
d4065d8e54
Fix for 112980, nsITheme API and dynamic skin switching re-enabling. r=ben, sr=waterson
2001-12-17 22:51:39 +00:00
865670347d
Fix blocker bug 114675 with null check around assertion code that I meant to check in yesterday (bug 114220).
2001-12-11 19:16:15 +00:00
27373573f5
Backing out changes I didn't mean to check in.
2001-12-11 05:41:43 +00:00
18f72ed21d
Prevent input elements from adding frames back into the primary frame map during their destruction (and leaving the map with dangling pointers) by passing the frame to functions that will be called during frame destruction to avoid calls to GetPrimaryFrameFor that will repopulate the primary frame map. b=114220 r=jkeiser sr=jst
2001-12-11 05:39:36 +00:00
1266d06230
Changing noisy warning I added yesterday from |#ifdef DEBUG| to |#ifdef DEBUG_dbaron|. b=110911 / 113810
2001-12-06 19:53:37 +00:00
1be6acf636
Remove nsDST and convert its users (PresShell::mSubShellMap, FrameManager::mPrimaryFrameMap, and FrameManager::PropertyList::mFrameValueMap) to PLDHash. Also convert FrameManager::mPlaceholderMap to PLDHash. Give image map area structures a pointer back to their image frame rather than (mis)using the primary frame map. Change API for changing placeholder map to reflect hash entry that accesses key through value by passing only the value and not the key. Give the root frame a proper mContent. b=110911 r=attinasi sr=brendan
2001-12-06 05:45:07 +00:00
297e61ccb9
Bug 41119 - Don't waste time notifying the frame manager about frame destruction if it is happening from nsFrameManager::Destroy. r=dbaron, sr=waterson.
2001-12-01 00:22:00 +00:00
b69ed06ca6
Perf and footprint opt. Make style re-resolution cheaper. r=glazou, sr=hewitt, bug 109261
2001-11-14 08:19:13 +00:00
5bf2cf4e7e
Checking in John Keiser's <jkeiser@iname.com> fix for *tons* of form submission and <select> related bugs, see tracking bug 34297 for details. r=rods@netscape.com, sr=jst@netscape.com
2001-11-02 07:40:01 +00:00
7980da516a
Ensure that we don't re-resolve placeholders to the style context that should be on their out-of-flow frame. Fixes autocomplete popup. b=107744 r=waterson sr=hyatt
2001-11-02 04:14:58 +00:00
10e3bbbb58
Avoid attempting to do CSS selector matching on text nodes, comments, or processing instructions by adding a 'NonElement' style resolution method that assumes that no rules match (temporarily, until we don't have style contexts for text nodes) and by cleaning code that was using textPseudo (the usual case) or passing the text node directly (only a few unusual cases). b=56117 r=hyatt sr=attinasi
2001-10-30 06:02:05 +00:00
acf2e9816a
two more nsUnicharUtils.h stragglers, I think I got r=jag, sr=scc on these in a previous patch - again for bug 100214
2001-10-26 17:51:22 +00:00
35f09ff982
No need to be this paranoid, checking for pointers being null once is enough! Checking twise in a row is just overkill.
2001-10-26 03:31:49 +00:00
75d32bb579
Bug 86947:
...
Make the line list doubly linked and access it through a list class and iterators.
Stop recomputing margins on all of the children of each block in the reflow chain (which causes O(N^2) state recovery during incremental reflow). Instead, add a second dirty bit to the lines and walk backwards through the line list to recompute vertical margins only when either dirty bit is set and the previous line was not reflowed. Add nsIFrame::IsEmpty to identify frames through which margins collapse.
Fix O(N^2) propagation of float damage by maintaining a set of intervals damaged by floats (bug 61962) and be sure to damage the correct areas (bug 48138).
Introduce nsCollapsingMargin to do correct collapsing of combinations of positive and negative margins (bug 50142).
Clean up some odds and ends and fix another smaller O(N^2) problem in nsBlockFrame::AddFrames.
r=attinasi, rbs sr=waterson
2001-10-25 01:08:40 +00:00
0214ac3fdb
Fix for 104336, deCOMtaminate rulenode, rulewalker, frames, r=dbaron, sr=waterson
2001-10-24 00:01:09 +00:00
5fe12c09e7
Extraneous Symbol Removal. Patch by Jon Smirl jonsmirl@mediaone.net. r=dougt@netscape.com, sr=alecf@netscape.com. Bug 104172 , 104316 , 104420 , 104426 , 104461 , 104511 , 104527
2001-10-23 01:37:21 +00:00
34fc404be7
Replace uses of overloaded |fputs| and most uses of |ns[C]String::ToCString|. b=104763 r=jag rs=scc
2001-10-16 03:53:44 +00:00
338e3871f8
Fixes for printing bugs 84017 and 89151. The fix for bug 84017 removes the need for a resize reflow to get form frame values to print. The restoration of these values into the new frame model is done as part of the initial reflow. The fix for bug 89151 gets rid of the extra frame model built and forces printed images to come out of the decoded image cache. r=darinf, heikki, sr=rpotts
2001-09-29 17:50:15 +00:00
885df97ac4
Bug 84645. Move XBL insertion point logic into nsCSSFrameConstructor, where it can interact nicely with continuing frames. r=dbaron, sr=hyatt
2001-09-12 20:19:41 +00:00
67f6aa83cb
Bug 66835 - fix method hiding warnings by renaming some methods on nsIContent. r=jag, sr=jst.
2001-08-17 08:14:14 +00:00
0e7a2eacd9
Bug 93972: Don't save form control values in session history if they have an autocomplete attribute set to off, or if their containing form has an autocomplete attribute set to off. This is accomplished by returning an empty 'state key' which indicates that the state should not be stored in session history's hash table. r/sr=jst@netscape.com,vidur@netscape.com
2001-08-16 07:18:24 +00:00
8405a1984e
Use NS_PTR_TO_INT32 macros to do 64-bit safe pointer conversions.
...
Bug #20860 r=Roland.Mainz@informatik.med.uni-giessen.de sr=brendan@mozilla.org
2001-08-14 07:59:59 +00:00
b72c324af1
fixing bug 78690. removing old imagelib. r=jst sr=waterson
2001-08-09 20:22:39 +00:00
04fb853f1a
Fix for 90081, r=dbaron, sr=attinasi
2001-07-25 06:33:06 +00:00
a7ba2a86d2
Fixes for 80512 and 83707. r=blake, sr=waterson, a=asa
2001-06-04 00:22:43 +00:00
2bf7260d28
Fix for 78695 (rule matching improvements). r/sr=attinasi, jst, waterson
2001-05-31 22:19:43 +00:00
3cd44086a1
Bug 77834: Fix problem where form control state is being restored to the wrong form control or not restored at all when going back and forth through session history. The problem was that the hash key we used was the content ID, which was not consistent from page load to page load. The fix was to key instead by index of form in document / index of control in form, with logic to fall back to content ID if we are unable to do this. r=nisheeth@netscape.com, sr=jst@netscape.com, a=drivers@mozilla.org (blizzard@mozilla.org)
2001-05-30 11:26:21 +00:00
7979b6163f
Bug 79508. If the computed style change is going to cause a reflow (or worse), then don't touch any continuing frames. This keeps us from queuing an incremental reflow to a continuation, but is not ideal (e.g., there may be cases where we don't properly recompute the style contexts for continuations). r=rbs, sr=attinasi
2001-05-23 06:39:34 +00:00
9bd2e82ac0
Bug 76407. Handle second CantRenderReplacedElement() request for same frame: check to see if we've already posted an event for the frame. r=dbaron, sr=attinasi, a=chofmann
2001-04-24 00:05:33 +00:00
a7135c5aab
bug 71370; author=simon@softel.co.il; r=attinasi; sr=erik; implement bidi
...
(bidirectional text) for languages such as Arabic and Hebrew; from IBM bidi
project; not part of build yet (due to #ifdef IBMBIDI)
2001-03-09 03:29:00 +00:00
34b9bbc1ff
Remove attempted workaround for CantRenderReplacedElement crash that didn't fix the crash (which is now fixed the right way).
...
Clean up the FrameManager a bit, mainly by moving the destruction of the frame tree into the |Destroy| method rather than doing it in the destructor. This would make it safer to convert nsIFrameManager to IDL and use the frame manager from JS. It also reduces the risk of leaks caused by having something owned by a frame own the frame manager. Breaking cycles in a destructor can be risky because the objects entrained by the cycle could include the object whose destructor would break the cycle.
b=65800 r=waterson@netscape.com sr=attinasi@netscape.com
2001-03-06 01:46:03 +00:00
ee4184638f
Bug 62713: Only save scroll position in SH if offset from origin, only put entries in state table if state was created, cleanups, r=jst@netscape.com, sr=vidur@netscape.com
2001-02-06 02:32:04 +00:00
90b8800096
Fix for 55292, r=ben, sr=brendan
2001-02-02 00:54:47 +00:00
7a97a55d82
Remove trailing semicolons after all uses of MOZ_DECL_CTOR_COUNTER to quiet build warnings on Mac. b=60415 a=brendan@mozilla.org
2001-01-27 23:06:33 +00:00
b0da06ecfa
bug 56432 ()
...
the problem was a factorial algorithm for finding primary frames.
fixed by added a hinting mechanism that takes advantage of existing
primary frame cache, greatly reducing the cost for the common case.
r=rods
sr=waterson
2001-01-16 22:10:04 +00:00
c81b2c3b26
removing most all NS_DEFINE_IID and replacing them with NS_GET_IID macros
...
Bug 61274, r=buster sr=waterson
2001-01-04 20:44:42 +00:00
97216875d7
Fixes regression due to Style Data sharing: forcing shared contexts to be unique now when they have to be reresolved. b=63118 r=karnaze@netscape.com a=buster@netscape.com
2000-12-21 22:16:38 +00:00
500ee1e48e
Fix insertion point reparentin gissue with blocks. r=hixie, a=ben
2000-11-28 10:10:41 +00:00
b8561b2b8a
Fix for 51264. r=danm, a=ben
2000-11-27 22:00:33 +00:00
jaggernaut%netscape.com
dbaron%dbaron.org
roc+%cs.cmu.edu
caillon%returnzero.com
dwitte%stanford.edu
dougt%meer.net
bzbarsky%mit.edu
alecf%netscape.com
peterv%netscape.com
bryner%netscape.com
jkeiser%netscape.com
karnaze%netscape.com
sicking%bigfoot.com
dbaron%fas.harvard.edu
dougt%netscape.com
peterlubczynski%netscape.com
jst%netscape.com
attinasi%netscape.com
aaronl%netscape.com
shaver%mozilla.org
hyatt%netscape.com
vidur%netscape.com
waterson%netscape.com
pollmann%netscape.com
cls%seawood.org
pavlov%netscape.com
erik%netscape.com
buster%netscape.com
rods%netscape.com