4df9c7f7b6
Fix bug "IFrames repositioned by whitespace in HTML" (no number yet) - give cols with no content 0 width unless they have style width, sr=kin, r=alexsavulov
2001-09-26 13:49:26 +00:00
a77cb3b548
bug 68998 - added extra param to Paint, PaintChild, PaintChildren used by tables in standard mode. sr=waterson, r=alexsavulov.
2001-09-19 12:35:19 +00:00
23e6683e50
bug 78162 - don't optimize resize reflow on cell if its desired size exceeds its last avail size, sr=timeout, r=alexsavulov
2001-08-06 14:04:58 +00:00
7dcbe365fc
bug 89116 - rebalance table on cell incremental reflow when maximum width changes. sr=attinasi, r=alexsavulov.
2001-07-13 23:49:30 +00:00
ca9d882b4e
remove cellspacing from table row background, bug 86220 r=dbaron sr=attinasi sr=asa
2001-06-20 04:48:34 +00:00
2bf7260d28
Fix for 78695 (rule matching improvements). r/sr=attinasi, jst, waterson
2001-05-31 22:19:43 +00:00
5816b4b59c
bug 59280 - better splitting of row groups/rows with rowspans. r=dcone.
2001-04-16 14:51:52 +00:00
46aa2d1bf9
bug 57467 - print a new row on the current page if it will waste too much space otherwise. sr=attinasi.
2001-04-02 03:21:58 +00:00
d0f96e6378
bug 72181 - treat style change reflow like initial reflow (with same optimizations). sr=attinasi
2001-03-25 20:06:29 +00:00
7cd5717b02
bug 72554 - fix printing assertions, account for footer space when spliting row group and reflow footer. sr=attinasi
2001-03-22 15:59:37 +00:00
d44332bdf7
fix Bug 70989 Clean up lots of "shadows" and other common warnings
...
r=peterv, jst, ducarroz, edburns. sr=jst, shaver
2001-03-21 05:32:22 +00:00
a3a25d11b0
table reflow coalescing, table reflow face lift. sr=attinasi
2001-03-13 06:38:59 +00:00
ea2b429682
Avoid ignorable whitespace in tables by setting the frame state-bit to this effect - bug 68411 r=karnaze sr=waterson
2001-02-23 12:35:34 +00:00
ad19cf4c81
Reinstate my changes that were backed out 10 days ago. #43457 split nsStyleSpacing into 4 smaller structures: nsStyleBorder, nsStylePadding, nsStyleMargin, nsStyleOutline. r=attinasi,sr=buster.
2001-02-07 09:57:26 +00:00
9c6f7ccade
This checkin enables mozilla to support the printing of selection, the printing of page ranges, and
...
the printing of headers and footers.
Printing of selection is implemented by the frames figuring out if they are in the selection and painting
if they or not they they don't paint. This also only allows the printing of the first page of
selections, alothough it is well documented where this is implemeted so it can be removed.
Bugs 63426, 31218, 61075 r=dcone,kmcclusk,erik,buster sr=waterson
2001-01-27 14:09:34 +00:00
9927e53497
better table reflow debugging including support for elapsed time. sr=buster.
2001-01-25 15:55:51 +00:00
2a02bb78fd
Backing out pierre's change from 1/20 for performance reasons (66263). r=attinasi, a=granrose, phil
2001-01-25 02:58:12 +00:00
531ba68b54
#43457 split nsStyleSpacing into 4 smaller structures: nsStyleBorder, nsStylePadding, nsStyleMargin, nsStyleOutline. Review=attinasi. Pending Approval: buster.
2001-01-20 22:46:54 +00:00
4ae530d914
bug 46623 - allocate proportional and auto cols together when balancing columns. (sr=buster, r=peterl)
...
allow columns (due to colspan) containing no originating cols at the end of the table to exist
2001-01-12 23:07:54 +00:00
da2e6037b8
bug 57828 - better handling of nowrap in table cell. sr=buster, r=attinasi.
2001-01-11 23:03:37 +00:00
c81b2c3b26
removing most all NS_DEFINE_IID and replacing them with NS_GET_IID macros
...
Bug 61274, r=buster sr=waterson
2001-01-04 20:44:42 +00:00
003761d59a
bug 40721 - improved TallestCellGotShorter(), sr=buster, r=rods
2000-12-21 23:03:42 +00:00
9a76306ac2
bug 40828 - call DidSetStyleContext when reflow a cell unconstrained. a=buster, r=dcone.
2000-11-15 16:01:26 +00:00
a4a746eda1
bug 59252 - fixed regression caused by bug 53690. Don't reflow cell's in a fixed layout table unconstrained. a=buster, r=attinasi.
2000-11-15 14:59:47 +00:00
d089df6135
bug 53690 - don't allow a split row to reflow its cells unconstrained. a=buster, r=dcone.
2000-11-03 04:25:29 +00:00
37a037daea
bug 53690 part of table never displayed because of incremental reflow bug
...
r=karnaze
a=waterson
2000-10-30 04:15:32 +00:00
4189314fdb
Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc.
2000-10-28 22:17:53 +00:00
6e35f97e31
Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson
2000-10-27 22:43:51 +00:00
bc890dbe54
bug 51392 - use nothing changed flag when deciding whether to rebalance table during row incremental reflow. a=buster, r=peterl
2000-10-05 21:05:06 +00:00
dc387c311c
Fix for bug 46368. Fixed cellMet.mMaximumWidth for incremental reflow. r=karnaze
2000-09-11 22:58:59 +00:00
9d0a56f33b
bug 45350 - correctly consider rowspan height in table row incremental reflow
2000-09-05 14:57:34 +00:00
644740d8b6
bug 48295 (floating nested table height initially 0, makes layout wrong)
...
r=karnaze
values from the wrong struct were getting passed into SetTallestCell
2000-08-31 02:57:58 +00:00
91721f92dd
bug 3992
...
chris k did the work.
r=buster
2000-08-24 05:03:18 +00:00
9adcb3708a
Enable the code to support for 'vertical-align: baseline' in table-cells. bug 10207. a:waterson@mozilla.org. was r:karnaze@netscape.com.
2000-07-28 09:19:26 +00:00
0db9744cc0
bug 40721 - put back fix that was erroneously backed out. r=rods from before.
2000-07-06 13:58:54 +00:00
027a9b2cb0
bug 42726 - back out previous checkin.
2000-06-15 23:39:49 +00:00
943e053626
bug 40721 - better in determining if height of a cell gets smaller during incremental reflow, r=rods
2000-06-15 14:31:12 +00:00
c96e164bef
[#ifdef MOZ_MATHML: not yet part of default build]. Add support for 'vertical-align: baseline' in table-cells. bug 10207. r:karnaze@netscape.com. a:waterson@mozilla.org
2000-06-05 08:25:11 +00:00
95f0dd93a8
fix #ifdefs to quiet output (speeds up display of complex tables like tinderbox and slashdot.org) - does not affect release builds
2000-06-04 09:44:08 +00:00
bf5d727d9f
nsbeta2+ bug 39885 - invalidate minimal areas. optimize reflows when cells don't change size. r=attinasi
2000-05-25 22:40:21 +00:00
d2c39b970f
bug 37037, 37490, and a table paganation problem when captions are present.
2000-05-04 23:16:42 +00:00
75ea85e43a
new reflow/layout code for outer table to handle captions and margins. better % height handling.
...
row groups and rows don't include external cellspacing in there dimensions. r=troy.
2000-04-28 21:05:31 +00:00
807b258faf
Add ifdef'ed Performance Reflow Counting code
2000-04-21 21:36:33 +00:00
fd5dc605d2
Fix event targetting bugs by using paint layers in GetFrameForPoint, testing for visibility, and trying GetFrameForPoint on additional views if one fails. r=joki@netscape.com(, hyatt@netscape.com) b=12232,20051,21304,24474,26785, and remaining issues from 23161.
2000-03-22 02:43:08 +00:00
4b5db8f52f
Fix 32199 (visibility:collapse is not being interpreted as hidden on block and inline level elements) and parts of 21701 (misuse of style attr mVisible).
In the following files, replacing disp->mVisible with disp->IsVisible() is a BUG FIX: nsBlockFrame, nsBulletFrame, nsHRFrame, nsHTMLContainerFrame, nsImageFrame, nsTextFrame.
In all the other files, replacing disp->mVisible with disp->IsVisible() or disp->IsVisibleOrCollapsed() is merely a SYNTACTICAL CHANGE. The respective owners will later review the use of IsVisibleOrCollapsed() and in some cases replace it with IsVisible(). See bug 21701.
2000-03-17 10:15:13 +00:00
f49c1f5eae
PDT+ bug 29429 - incremental reflow and nested tables, r=troy, a=rickg
2000-03-09 08:45:26 +00:00
ad10d5160d
Fix for 28856. r=karnaze,troy a=jar
2000-03-01 02:35:14 +00:00
79a31a4d59
Fix problem with NS_IF_ADDREF on member variables inside of const
...
member functions. This includes removing all references to
NS_DEF_PTR and the including of nsIPtr.h
r=troy@netscape.com ,dougt@netscape.com,scc@netscape.com
# 28114
a=chofmann@netscape.com
2000-02-17 23:19:18 +00:00
2a1844ff70
bug 10636, 15499(partial) - correctly get margin,border,padding from reflow info. calculate it for percentage padding when reflow state not available. r=troy
2000-02-12 01:55:40 +00:00
d2e69a1720
bug 8524 - don't use -moz-bg-inset in standard mode. r=troy
...
bug 10269 - renamed RequiresPass1Layout to IsAutoLayout and have it force a fixed layout table (not tree) to be auto layout if the table is auto width.
2000-02-12 00:58:38 +00:00
c43f4c1b2e
bug 7741 - handling of overlapping rowspans, r=troy.
2000-02-03 14:04:49 +00:00
3807ea4d75
bug 24880 colspan/rowspan=0 handling, bug 22122 handle *0 proportional width; r=kmcclusk.
2000-02-01 03:23:29 +00:00
d7b72a10f0
bug 24037 r=attinasi; nsOuterTableFrame handles bad incremental reflow by using the height of its rect.
...
bug 23235 r=attinasi; nsTableRowFrame requests max element size when reflowing cell for the 1st time.
bug 24410 r=attinasi; nsTableCellFrame reflow always checks width and height and updates the content empty flag.
bug 3305 r=troy,hyatt; table frame constructor cleanup, put caption in its own child list.
2000-01-28 02:19:45 +00:00
3e020a70ac
r=karnaze@netscape.com Removed some code that was removed but then added
...
again by mistake
2000-01-27 05:54:17 +00:00
73a3709284
b=21657 a=chofmann@netscape.com Made "overflow list" a full fledged
...
child list and changed ReparentFrameView() to check it.
2000-01-22 01:16:50 +00:00
31b8ebe5d0
b=21657. Changed row frame code to correctly determine if it's complete
...
after an incremental reflow. Fixes crash when printing www.cnn.com
2000-01-17 17:45:17 +00:00
583c152d41
fixed printing assertions; more throughly check cell map usage for contuining frames;
...
fixed bug 24057; r=kmcclusk,cmanske; could not run mail smoke tests due to prior bustage.
2000-01-15 20:10:00 +00:00
3d41b6f70c
Removed some debug assertions that are no longer valid
2000-01-15 05:38:24 +00:00
369b89f5d0
bugs 19061, 9879 - each top level row group gets its own cell map; CellData reduced to 4 bytes.
2000-01-13 05:29:38 +00:00
f7247cd834
b=23707. Made sure HR frame correctly computes max-element-size
...
when it has an 'auto' width
2000-01-12 04:52:19 +00:00
c002799ec9
b=23239. Changed tables to incrementally update maximum width (natural width)
...
if requested. Now we only do a single reflow when processing table cell
incremental reflow instead of the three reflows we had to do before
2000-01-11 15:55:31 +00:00
1243d0ab93
bug 12287 - honors mComputed values in reflow state and uses CSS box-sizing property.
2000-01-02 22:55:48 +00:00
4ddb903853
Work-in-progress for having maximum width (needed by tables) be updated
...
incrementally
1999-12-30 04:15:45 +00:00
4ee592a9da
Reduced size of table cell member data by 4 bytes by only storing the
...
maximum width and not both the width and height. The height was never used
so this wans't an issue
1999-12-24 03:46:21 +00:00
ba422c3ed8
incremental cell map, columns. Bugs 12122, 21544. r=troy,hyatt a=hofmann
1999-12-13 22:56:31 +00:00
16a944a1e3
Implementing a generalized recycler and arena for all layout frames. Hoping to improve
...
bug #9489 . Should also definitely fix bug #15916 . r=troy
1999-12-04 23:49:50 +00:00
7ca374e1b7
b=20367, r=jinjin@pacbell.net. Changed ResizeReflow() so that if we skip
...
reflowing the table cell (that's an optimization we do) we make sure and
position any child views
1999-12-02 01:02:53 +00:00
a0640b60c4
Changed nsIPresContext& to nsIPresContext*. Changed nsEventStatus& to nsEventStatus*. Now more compatible with XPIDL. a=vidur r=scc
1999-11-24 06:03:41 +00:00
fe56995443
WillReflow/DidReflow changes and changes to the way view positioning
...
and sizing works
1999-11-19 15:33:29 +00:00
42fc94a6ec
updated license boilerplate to xPL 1.1, a=chofmann@netscape.com,r=endico@mozilla.org
1999-11-06 03:40:37 +00:00
04accb3de6
Moved a bunch of stuff out to a nsIFrameDebug interface
1999-11-01 22:12:45 +00:00
732b6f429c
Space reduction. We now save 8 bytes per row frame by eliminating the max
...
top/bottom margin data members which are no longer needed
1999-10-29 14:40:58 +00:00
a47e8db44b
Changed SetView/GetView to take an additional argument which is the
...
pres context
1999-10-26 04:44:41 +00:00
533bdbcf57
Quieted down some debug noise and added a missing newline to a printf
1999-10-25 23:02:43 +00:00
ce952b6207
Space reductions for nsTableRowFrame. Changed mInitializedChildren to be a
...
frame state bit, and changed mMinRowSpan and mRowIndex to be packed into
one 32-bit field. Total savings of 8 bytes per row frame
1999-10-23 23:08:30 +00:00
d26165e530
bug 11321 - Renamed kidMaxElementSize to localKidMaxElementSize and renamed pKidMaxElementSize to kidMaxElementSize and fixed the incorrect usage.
1999-10-17 03:17:53 +00:00
5e139f0234
Space optimization for nsTableFrame. r=karnaze@netscape.com
...
- changed mBorderEdges to be heap allocated (only needed for collapsing border model)
- made the 8 boolean data members into bitfields
- changed mColumnWidths to be as small as necessary instead of defaulting its size to 100 elements
1999-10-04 23:48:05 +00:00
e2ac00fe47
Hooked up SizeOf() for cell map and table layout strategies. Also added in
...
some table frame data that was missed
1999-10-02 00:02:54 +00:00
55df05944d
Eliminated compiler warnings
1999-09-08 20:29:56 +00:00
dff5b76938
Updated SizeOf methods to not waste space when doing a non-debug build
1999-09-01 01:02:16 +00:00
fd426dec6a
Reimplemented SizeOf methods in some of the frame classes; partial rework of first-line handling snapshot
1999-08-31 03:09:40 +00:00
428ded8cf6
Changing tables to return max element size during an incremental reflow
1999-08-30 22:30:32 +00:00
8c3c551001
Changes to the cell map to support incremental insertion and removal of rows. Currently
...
only used by the tree widget.
1999-08-30 00:01:09 +00:00
bebd447494
Fix for bug #12592 . Optimized style change reflow commands targeted at
...
a cell frame
1999-08-29 04:18:00 +00:00
544eff13a4
Tweaks to be able to see the RowReflowState over in trees
1999-08-28 00:43:53 +00:00
0b5b66f195
bug 1271 - percentage height cells, added GetNumCellsOriginatingInRow, fixed GetNumCellsOriginatingInCol
1999-08-25 21:49:18 +00:00
9305f5241c
replaced debug flags with class. removed compiler warnings.
1999-08-24 12:01:31 +00:00
61f5d63599
Minor cleanup
1999-08-21 21:24:42 +00:00
cf38c609d5
Optimized incremental reflow and split some code out into member functions
...
so there's less dusplication of code
1999-08-21 20:16:32 +00:00
8a61d5c83a
bug 11944 - correct placement of row group using table border/padding. bug 625 - reinitialized col sizes before 2nd pass 1 reflow.
1999-08-21 06:38:07 +00:00
f301d55556
remove mac compiler warning
1999-08-20 13:32:23 +00:00
66b706bb32
Added new incremental reflow methods.
...
CellData keeps track of row versus col spans.
nsColFrame keeps track of what cell contributed to constrained width.
nsCellMap::GetCellFrameAt replace with GetCellInfoAt
simplified nsTableCellFrame::RecalcLayoutData and removed FindLargestMargin, CalculateMargins, CalculateMargins
simplified nsTableFrame::RecalcLayoutData and removed AppendLayoutData
Added gsDebugReflow capability, remove all existing debug printf
1999-08-19 19:52:37 +00:00
2a655ce368
Changed to table incremental reflow
1999-08-19 03:51:25 +00:00
91e90de3bd
bug 3517.
...
Always get border-collapse from nsTableFrame::GetBorderCollapseStyle.
Added several null checks for border edges.
Added check in nsTableFrame::DidComputeHorizontal to replace null edges with trival ones.
1999-08-10 00:49:10 +00:00
e50053ef39
Made sure that column cache is invalidated if necessary when appending rows
...
frames and cell frames
1999-08-07 15:12:50 +00:00
08e48c5f1a
Fix for bug #11393
1999-08-07 00:31:02 +00:00
b4f91e984d
Changed to new command reflow handling
1999-08-03 02:41:27 +00:00
126d24e273
Work-in-progress for table handling of reflow commands
1999-08-01 22:01:37 +00:00
73efaea2c2
bug 10809, incremental reflow of nested tables now reflows children.
1999-07-29 23:19:52 +00:00
d5e430c16a
new nsCellMap, BasicTableLayoutStrategy, plus various fixes to table
...
frames while testing the new cell map and strategy
1999-07-28 08:09:02 +00:00
537d74d82c
Renamed some nsFrameList member functions
1999-07-22 04:00:57 +00:00
1e4bbda958
fixing table selection again. also adding parameter to nsIFocusTracker that allows us to get the current caret location. I am also stopping nsTableRowFrame from putting blue border around itself since cells are a high enough granularity. made a change to nsIFrame GetPosition to remove some useless parameters ect. this caused me to change nsDOMEvent.cpp and some other places.
...
MJ
1999-06-10 21:08:17 +00:00
5bf51e9a40
bug 6459 - incremental reflow methods call DeleteFrame instead of RemoveFrame
1999-06-10 02:29:34 +00:00
45d73d88de
support for backgrounds on table elements in both compatibility modes
1999-06-07 21:10:25 +00:00
fea30bc4eb
Reworked frame factory methods; fixed bug 4519
1999-05-11 22:03:29 +00:00
a926943797
bug 3103 - resizing table based on height attribute now considers row spans of cells.
1999-05-04 19:15:56 +00:00
fbb69f0465
bug 5838 - right-to-left handling of col span at right edge
1999-05-04 03:31:07 +00:00
cea85eaf3b
support for right-to-left direction
1999-04-22 03:51:58 +00:00
23c2c377ef
Removed SetInitialChildList() and now we inherit the base class version
...
which does the same thing
1999-04-13 01:11:46 +00:00
aa1d2236b2
Removed some code from nsContainerFrame that is no longer needed now that'
...
we have nsFrameList
1999-04-12 23:46:02 +00:00
fab8db134e
Whacked paint methods to use new constants
1999-03-26 00:39:35 +00:00
661ba87dcb
bug 2220; changed wording of some warnings.
1999-03-13 12:49:37 +00:00
ba18377496
use new nsHTMLReflowState ctors
1999-03-05 04:19:09 +00:00
f19915b56d
Removed nsIFrame::CreateContinuingFrame()
1999-02-25 05:31:15 +00:00
dfdacc8159
Changed nsIFrame::Init() to take an additional parameter
1999-02-25 03:27:57 +00:00
e4388eb926
Added frame type atoms for several table frame classes
1999-02-24 05:54:31 +00:00
8dfabdf1a8
Changed GetNextInFlow() and GetPrevInFlow() to be pointer arguments and
...
not references
1999-02-24 04:48:08 +00:00
b484183ca3
added printf to flag when a table cell's max element size exceeds its desired size (for bug 3094)
1999-02-23 21:03:57 +00:00
d4fd3a2158
More work-in-progress for table pagination
1999-02-22 03:28:00 +00:00
55ce870c23
Removed some XXX code that was temporary, but I forgot to delete
1999-02-19 02:05:00 +00:00
e844c3e177
collapsing rows, row groups, cols, col groups
1999-02-11 06:22:33 +00:00
a350956668
changed getters to be XP_COM-like, with out-params instead of return values.
...
this is so these getters can be bound to an XPCOM interface, nsITableCellLayout
1999-02-11 01:16:28 +00:00
c37ccfbc4c
Changed GetNextSibling() to use a pointer argument instead of a reference
1999-02-10 06:13:38 +00:00
5c3d1395f3
Changed a bunch more nsIFrame member functions to be pointer arguments
...
instead of references
1999-02-10 05:38:18 +00:00
a9159f71d6
Changed GetAdditionalChildListName() and FirstChild() to use ** instead
...
of *&
1999-02-10 02:25:01 +00:00
c9c1fa187e
Changed some nsIFrame member functions to use ** instead of *& for OUT
...
paremeters
1999-02-10 00:42:56 +00:00
17a4528838
Renamed RemoveFrame to RemoveAFrame to reduce compiler warnings
1999-02-04 16:27:18 +00:00
5643593d58
work in progress for table visibility=collapse
1999-02-03 23:54:32 +00:00
06d2d8efb3
Spanked away SizeOf methods and nsIListFilter
1999-01-16 00:00:50 +00:00
8dba97945a
Used revised version of nsContainerFrame that uses an nsFrameList instead of a raw nsIFrame*
1999-01-15 22:52:05 +00:00
5d8b4656eb
Removed the content-parent frame pointer. Now we just have the one geometric
...
parent
1999-01-14 05:16:23 +00:00
59d1bc8ea5
Replaced "maxSize" member if nsReflowState with "availableWidth" and
...
"availableHeight"
1999-01-05 23:31:18 +00:00
7a8b4533c3
fixed a bug in fixed layout initial reflow with spanning cells
1999-01-03 19:20:13 +00:00
781a43ae69
Changed width/height constraints in nsHTMLReflowState struct
1998-12-30 17:50:00 +00:00
e1f9e8b29f
Moved logic that deals with moving absolutely positioned frames out of the
...
flow to the frame construction code
1998-12-29 03:38:16 +00:00
1999604fcc
beginnings of collapsing borders now implemented. Doesn't work for spanning cells yet,
...
and doesn't measure borders where the width changes along a shared edge yet.
1998-12-21 06:38:18 +00:00
27f0cfe8cc
Revised frame Paint API
1998-12-18 15:54:23 +00:00
5bdf19f9b4
Fixed a crash when display www.sjmercury.com paginated, because we thought
...
we could re-use our cached cell desired info and we couldn't because there
was a next-in-flow frame and so we needed to reflow the cell frame and pull-up
its next-in-flow child frames
1998-12-16 05:41:57 +00:00
ff88de2ebe
Changed SetRowIndex() to be inline and non-virtual
1998-12-16 04:31:38 +00:00
f87fdd3252
Some improvements to the row splitting code
1998-12-16 03:46:03 +00:00
ae329c5c12
Work-in-progress for splitting of table row frames
1998-12-15 16:39:09 +00:00
4c64b99f4f
fixed a minor bug in incremental reflow where the reflow state's "widthConstraint" wasn't getting set
1998-12-11 18:54:58 +00:00
ffb50a065b
tables can now have independent horizontal and vertical cell spacing
...
("cellspacing" HTML attribute == "border-spacing" CSS property, go figure...)
1998-12-09 06:37:18 +00:00
bee46015b7
fixed cellspacing and cellpadding handling
...
default cellspacing and cellpadding now comes from the table frame itself
other frames on longer look at the "tableStyle" struct for these values
1998-12-05 05:27:21 +00:00
d97a31f115
Added Init() member function to nsIFrame
1998-12-03 06:31:43 +00:00
ccf7f3277f
This checkin (under mozilla/layout) is all about 'const'. Digital Unix's
...
C++ compiler is strict about getting 'const' right. Most of the changes
are to add 'const' to the type casts for the second argument of the
GetStyleData method, which wants a const reference.
1998-12-02 16:45:20 +00:00
c630ab9ae5
bug 1520 (www.mirabilis.com)
...
the problem was the way table layout apportioned height from a rowspanning cell.
Now, we do 2 things correctly:
1) we handle rows with rowspanning cells and no other cells.
2) we divide the height of a rowspanning cell proportionately to the rows spanned, where the proportion is defined by
the max height of a cell in that row that has no effective rowspan.
the partial fix for bug 1431 has to do with dividing width between percent-width and fixed-width columns in the same
table. You won't see any better layout for this page (ww.boston.com) as a result of the code I added. The rest of this
fix is a bit risky, so I'm waiting until after stability push.
1998-11-24 19:41:33 +00:00
d14379cfe9
changed the logic for reflowing cells whose height is changed due to a
...
height attribute.
1998-11-23 23:07:40 +00:00
c85d0477a1
implemented table height algorithms. also made a slight modification to
...
the way a table finds its container's width.
1998-11-20 01:01:25 +00:00
63107e9026
Added DumpRegressionData; revised ListTag; added GetFrameName
1998-11-19 17:22:29 +00:00
7716dc91e8
Reworking internal event code to use nsIFrame::GetFrameForPoint
...
Adding new functionality through nsEventStateManager (cursor change, enter/exit events, tab navig)
1998-11-18 05:25:26 +00:00
15a156711c
fixed a tiny bug in handling unexpected frames in a row
1998-11-12 21:04:41 +00:00
fd34820203
Renamed Init() to SetInitialChildList() and added an additional parameter
...
for the name of the child list
1998-11-10 06:05:32 +00:00
02915d3677
First of a few changes to allow frames to have multiple child lists.
...
FirstChild() now takes an additional argument which is the name of the
child list.
1998-11-09 19:40:27 +00:00
12aa0f3695
fixed the bug where events were not getting passed down to content inside
...
of cells with rowspans. Basically, I just override HandleEvent() in nsTableRowGroupFrame
to ask nsTableRowFrame::Contains(), rather than the default action which is to
just use the child's rect.
1998-11-07 00:36:37 +00:00
db4987a8d2
removed some inefficiencies in finding the parent table frame.
...
Now the parent table frame is cached in the reflow state.
1998-11-04 20:09:19 +00:00
776a2683ef
sync to style resolution api changes
1998-11-03 20:33:43 +00:00
4769e1eae6
fixed rowspan/cell height problem where subsequent rowspanning cells can
...
effect previous cell heights.
1998-11-02 18:32:14 +00:00
8e569cbd83
implemented basic attribute changed handling. most things currently work, those that don't will work better after Peter
...
lands some style context resolution changes.
1998-10-30 23:08:34 +00:00
d8ae00b810
some extremely preliminary work for styleChanged incremental reflow
1998-10-30 07:57:44 +00:00
10921d7b0b
changes to support nsIRenderingContext that conforms to COM conventions.
1998-10-30 02:08:25 +00:00
a813b08b20
fixed bug 1180 (mozilla.org) and all tables that have nonsense colspans
1998-10-26 18:42:22 +00:00
e9c6389c50
fixed bug 1112 - form submission within a table sometimes doesn't work
...
because the form doesn't get a reflow command. Now it does.
1998-10-23 17:24:57 +00:00
69279059ed
just debug info
1998-10-22 21:59:13 +00:00
770456fedd
fixed a bug where columns were not always created as needed during incremental appends
...
added some extra debugging and support methods
1998-10-22 05:27:11 +00:00
113ad4cfe4
fixed several incremental reflow bugs
1998-10-21 22:29:00 +00:00
7072bdfa9c
incremental reflow only does pass1 reflow on new frames when necessary
...
fixed some rotting bits in table frame classes having to do with breaking tables
1998-10-20 20:05:44 +00:00
a212d55079
all containers now decend from nsHTMLContainerFrame
...
all "unknown frame" incremental reflow support methods now
replaced with nsHTMLContainerFrame::AddFrame and ::RemoveFrame
1998-10-20 17:45:07 +00:00
fe51fc04ba
incremental reflow now includes insert/append/delete cell
1998-10-20 15:59:56 +00:00
a68c7be529
lots of work for incremental reflow when the target frame is a table frame
1998-10-14 16:32:45 +00:00
05a50b6ce3
Added an nsIPresContext& to html-reflow-state's ctors and used it to implement better percentage width/height handling
1998-10-12 14:48:02 +00:00
cc44601bb8
Removed GetContentIndex() from nsIFrame
1998-10-08 20:35:16 +00:00
f039f11a24
Changed ReflowChild() to send the WillReflow() notification as well
1998-10-06 00:27:22 +00:00
0499b15ed9
Removed calls to MoveTo() BEFORE reflowing a frame. We used to do this
...
sequence: MoveTo(), Reflow(), SetRect(). Now that we have the WillReflow()/
DidReflow() code sandwhiches we no longer need to do the MoveTo()
1998-10-05 00:58:32 +00:00
360bd18d2d
minor interface cleanup
1998-10-02 20:36:35 +00:00
f095846367
Eliminated nsIRunaround interface, and folded space manager parameter into
...
nsHTMLReflowState structure
1998-10-02 04:10:00 +00:00
8b034f4950
Separated reflow process out of nsIFrame and into nsIFrameReflow. Also
...
added nsIHTMLReflow, which is an HTML specific reflow interface
1998-10-01 04:46:11 +00:00
01b8c34dc8
Fixed up includes to not depend on old content model classes
1998-09-24 21:37:45 +00:00
b89f1873bc
removed lots of assumptions about frame ordering and containership.
...
table frames no longer assume they are n levels below the inner table frame
table frames no longer assume their child frames are always the expected type of
frame. Now they check the display type and use that as sufficient proof that the frame
is of the right type. This implies a heavy reliance on the frame construction code to do
the right thing and always stamp out the right kind of frame for a given display type.
1998-09-24 16:37:22 +00:00
82c4fa9df0
Removed PreReflowCheck() and PostReflowCheck() from nsContainerFrame
1998-09-24 03:59:30 +00:00
c1981ca059
all frame initialization and related logic has moved into the various table frames' Init() methods
...
from their respective InitalReflow() methods.
table-layout=fixed now completely skips pass1 reflow and doesn't require maxElementSize
information, saving a tremendous amount of time during initial reflow.
1998-09-23 21:48:26 +00:00
29018c63f5
set all the groundwork for FAST table layout based on CSS-2 table-layout property
1998-09-22 23:36:06 +00:00
528288293f
Removed all references to m<First,Last>ContentOffset,mChildCount,mLastContentIsComplete
1998-09-21 03:40:32 +00:00
9955ac85ce
Removed farme enumeration member functions for indexed access, last child,
...
and child count
1998-09-19 03:24:26 +00:00
1595410b34
added ColIsSpannedInto, ColHasSpanningCells
...
moved *IsSpannedInto and *HasSpanningCells into cellmap, giving us the oppurtunity
to easily cache results if we want. These methods are still accessed through nsTableFrame.
changed nsTableFrame::GetCellAt to nsTableFrame::GetCellFrameAt to make it more clear what
the method returns: a frame, not content.
1998-09-18 22:37:14 +00:00
52eb998d8f
Removed nsIContentDelegate.h
1998-09-18 17:34:48 +00:00
c15391cc5b
Removed some old commented out code
1998-09-18 02:28:12 +00:00
abdd161d93
Frame construction changes for tables
1998-09-16 17:19:20 +00:00
58ec784e3d
better handling of non-cell frames in rowFrames
...
support for the case where a nested table is in a cell that has colspan>1
1998-09-16 00:48:14 +00:00
c47f9bbfcb
nsStyleConsts.h added some HTML 4 consts for tables
...
nsHTMLAtoms.cpp,h added some HTML 4 strings for tables
nsHTMLParts.h added constructors for new table content classes
nsGenericHTMLElement.cpp,h added table frame creation, common table attribute parsing
nsHTMLTable*Element.cpp these are the new table content classes
nsHTMLContentSink.cpp enabled the new content and removed the old
nsHTMLStyleSheet.cpp fixed the table style optimizations to work with new content
nsTable*Frame.cpp these work with the new content
1998-09-15 17:58:24 +00:00
e20837cb63
many fixes that effect http://www.mozilla.org and related pages.
...
these fixes are for nested tables with percent widths, for tables including both rowspan and colspan,
and for tables with only a single column.
some rounding errors were eliminated.
more debugging output, and some new assertions.
1998-09-09 20:00:40 +00:00
a8906329f4
expanded nsIFrame::List to include nsIListFilter *aFilter param, by default nsnull.
...
aFilter is useful for determining if a frame should output itself during
a List(). In any event, the children of the frame are always processed.
added nsIListFilter, an interface for any object that wants to act like a filter for frame dumps
added static NS_LAYOUT nsIListFilter * GetFilter(nsString *aFilterName);
currently, only TableListFilter implements nsIListFilter.
in response to List(...TableListFilter), the frame model is dumped in a way that is useful
for table layout regression testing. Currently this is controlled by command line switches on the viewer app.
1998-09-02 21:59:54 +00:00
1d3e803e2e
empty rows now handled properly
1998-09-01 17:49:05 +00:00
e5ebbcebfb
reimplemented cell map in terms of nsVoidArrays for incremental building.
...
the cellmap is now built incrementally, driven by nsTableRowFrame::InitialReflow
1998-08-31 21:23:28 +00:00
ed22b370c4
XPCOM'ized nsIContent and nsIHTMLContent
1998-08-29 20:20:38 +00:00
187d67d420
no longer force unique style contexts
1998-08-27 00:57:05 +00:00
6db252107e
more content decoupling
...
support work for style optimizations
fixed a bug in table columns -- the attribute repeat defaults to 1, not 0
1998-08-26 17:26:38 +00:00
530e8de8f4
modified the resize reflow optimization so max element size is returned
...
if requested without triggering a reflow if the width hasn't changed.
1998-08-19 18:40:33 +00:00
4b212c0467
Change to object lifetime management. Views are no longer ref counted
1998-08-08 04:23:33 +00:00
2559cf7afe
synch with branch
...
fixed the following bugs: 312653 312656 312655
the fixes were:
1. cells now inherit their bgcolor from the row, if available. This is the
Nav4 way of drawing row bgcolor, rather than having the row paint its own bgcolor. (Troy, I intend to make this conditional
based on the compatibility mode)
2. colspans across cols that are all specified width no longer try to proportionately
divide the width of the span between the cols. see http://www.city.net (now it's really fixed, without breaking nested tables in
constrained situations.) A happy side effect is nested tables in general behave better when constrained.
3. min table sizes are fixed, so min width changes to content now effect the
table correctly during incremental reflow. This fixes the table layout portion of the bugs on the http://www.aol.com/corp tree.
Rick will check in the other half of this fix soon. Until then, don't expect to see much improvement.
4. fixed bug 312799. Table cell now always reserve at least the maxElementSize
of its content, fixing problems when desiredSize<maxElementSize
1998-08-07 02:11:51 +00:00
79b37f8596
fixed this case: (an image tag with no width attribute) inside (a specified-width column) inside
...
(a nested table with specified width) inside (an auto-width column)
inside (a specified-width table). Got that?
The problem was that we we not setting state correctly during incremental reflow
when the image returned its proper metrics after giving default metrics that
were for its ALT text.
1998-08-03 20:27:59 +00:00
05a1471845
fixed a memory leak on a style context
1998-08-01 02:30:35 +00:00
4a52add42a
Remove most compiler warnings on IRIX
1998-07-29 20:19:08 +00:00
1c628a7907
COLS attribute ignored if any column width info is specified (like <TD width=100>)
...
fixed lots of COLS related bugs.
handle min width spec (<TD width=0 or width=0% or width=0*>)
major fix to colspan handling
1998-07-26 04:23:01 +00:00
2afd6cc554
GetColCount now returns the effective column count of the table, adjusted
...
for nonsense COLSPANs at the edge of a table. Fixed some bugs this uncovered
where the cell was being asked for its colspan attribute rather than the table
being asked for the cell's effective col span.
1998-07-24 16:51:16 +00:00
a2d1127af7
any table with a nonsense rowspan lays out better
1998-07-24 00:43:09 +00:00
15e6cd169c
fixed table width problems when there are colspanning cells
1998-07-22 05:38:41 +00:00
7232d0c359
Changed PaintBorder() to use the (x,y) that's passed in
1998-07-22 05:02:07 +00:00
a064b4803b
* reworked the way colspan and rowspans are handled in table layout strategy. We do less work, and we look better.
...
* fixed more margin code. we're inching towards correctness.
* the width contributed by a colspanning cell is now proportionately distributed to the columns based on the columns "effective width"
* added logic for handling illegal COLS attribute on a table (like COLS=4 in a 3-column table). See nsTableFrame::GetEffectiveCOLSAttribute()
* added logic for handling illegal COLSPAN attribute on a cell (like COLSPAN=4 in a 3-column table). See nsTableFrame::GetEffectiveColSpan(). This is wrong, and will get reworked soon.
* added the ability for cell width attributes to effect column width like Nav4.
1998-07-22 03:53:43 +00:00
417a329fa3
Changed Paint() to render the background if there is one
1998-07-20 23:56:17 +00:00
67b833fdc3
fixed a space leak/logic error handling colspans
...
added backwards compatibility for percent width tables inside of auto width tables (see http://webreview.com/wr/pub warning: you'll have to look at a local copy until
Troy/Vidur/somebody fixes an image problem.)
1998-07-17 21:02:28 +00:00
8c1e033fc9
we now allow empty rows
1998-07-17 17:51:43 +00:00
728589d34d
fundemental overhaul of the BasicTableLayoutStrategy
...
We now cache lots of useful info in the colframes
we now properly account for margins just as uniform cellspacing
1998-07-16 23:23:31 +00:00
6b93376d50
Some more changes of nsIPresContext* to nsIPresContext&
1998-07-15 17:05:21 +00:00
a3ff77478f
Added an XXX to remind me to talk with Cujo about how we determine
...
whether the column widths have changed...
1998-07-15 04:52:32 +00:00
fe75103d32
Some improvements to the incremental reflow logic to handle all the
...
cases handled by resize reflow
1998-07-15 04:45:58 +00:00
e264371e9b
Changed API for CreateContinuingFrame and GetReflowMetrics to take
...
a reference to a nsIPresContext
1998-07-15 03:23:23 +00:00
e8893481dd
Changed Reflow() member function to take a reference to a nsIPresContext
...
instead of a pointer
1998-07-15 02:53:09 +00:00
993e1fb8ac
Incremental reflow changes
1998-07-14 15:29:50 +00:00
ec1a4ff016
Reflow child when max-element-size is requested (this works around a purify detected crash)
1998-07-12 00:19:17 +00:00
03dd77b394
Added back in some changes that got lost in the previous
...
check-in
1998-07-11 04:16:29 +00:00
106c3a7c7a
fixed unix build, and one small uninitialized variable problem
1998-07-11 00:47:29 +00:00
7a2fe842b8
major hackage to the table data structures. slimmer, simpler, faster
...
this work exposed a few bugs and slow spots, which have been fixed
for the aol page, I added some additional backwards compatibility code
to proportionately distribute width when a fixed-width cell has colspans
1998-07-11 00:00:31 +00:00
be29f02f19
More code re-shuffling. I need to hurry and check-in before Cujo
...
whacks the tree
1998-07-10 22:56:13 +00:00
cee35a3b5c
Changed it so we assume that rows are always complete
1998-07-10 05:23:05 +00:00
ee57569c83
Some incremental improvements
1998-07-10 04:00:38 +00:00
03fd05a8af
fixed 3 dumb bugs I introduced recently.
...
1. cellmap couldn't properly delete CellData because definition was unavailable
2. optimized table cells made taller wouldn't shrink when they should because we were not
remembering the previous desired height of the cell.
3. rows were placing cells on the left edge, and not adding in the left margin.
1998-07-07 01:06:51 +00:00
e1426ada21
More incremental reflow changes
1998-07-07 00:49:07 +00:00
ed14926019
added support for "effective column widths", the width of a column pretending that spanning cells have no effect.
...
this gets us some more Nav4 compatibility.
several minor fixes.
1998-07-06 21:00:11 +00:00
1ee17c78b1
Moved code that resized the table row cells from the row group frame
...
to the row frame. It's now handled as part of the DidReflow() post-
processing code
1998-07-02 20:35:23 +00:00
2b75ce1f63
added an optimization that skips pass2 cell reflows when the new available width is unchanged
...
from the prior available width. Some real-world test cases sped up
1-2 orders of magnitude for resize reflow. Initial reflow is unchanged because
we still need to get pass1 metrics on all content.
fixed nsCSSBlockFrame.cpp to take margins into account when computing parent's available width
fixed distribution of excess space to table cells when table is bigger than the content it holds.
not quite finished yet, but better.
1998-07-02 17:40:56 +00:00
b4aa257397
Some work-in-progress for incremental reflow
1998-07-02 05:39:10 +00:00
226119c0ab
Some work-in-progress for incremental reflow
1998-07-01 04:55:15 +00:00
7c185eac84
Removed some vertical margin collapsing stuff that wasn't needed
1998-07-01 03:03:32 +00:00
3cc96f5b94
fixed-width cells no longer improperly impact the available size
...
of subsequent cells in reflow pass 1
we correctly distribute extra space in a table proportionately.
We try to give the extra space to auto-width columns first,
and if there are none we distribute it to all columns.
The percentage is based on the cell content's desired size.
1998-06-30 20:12:45 +00:00
a5505b8275
cells no longer monkey with their available width based on attribute constraints.
...
The row does this work now. This makes table layout more properly top-down.
1998-06-29 20:38:22 +00:00
5e60369eda
minor tweaks for table layout
1998-06-29 03:09:14 +00:00
163249f258
Eliminated IRIX compiler warnings (and a bug)
1998-06-26 15:07:09 +00:00
a6ca882bee
fixed some nested table bugs and made some minor adjustments to Kipp's new line layout code.
1998-06-26 00:48:44 +00:00
2b34ccf86a
Added some asserts to the incremental reflow code
1998-06-24 22:05:59 +00:00
670bf41c19
fixed some bugs related to rowspans. This gets us closer on pages like Mozilla.org that were getting wild table heights.
1998-06-24 19:13:19 +00:00
d8d860fb0b
Changed to make sure we set the (x,y) for the frame before we reflow it
1998-06-24 18:09:47 +00:00
a5129668b4
Changed to make sure we link the child frame into the list of frames before
...
we reflow it
1998-06-24 16:35:21 +00:00
69e26c8efd
Some incremental reflow changes
1998-06-24 04:38:52 +00:00
722a46b983
lots of nested tables look much better
...
misc. nav4 compatibility enhancements
added the ability to QueryInterface for some specific table frame types
1998-06-23 23:23:21 +00:00
92961a089a
Some work-in-progress for table incremental reflow
1998-06-23 05:43:27 +00:00
3f9f422457
Separated table content from table layout. This paves the way for XML/CSS-2 tables.
...
Lots and lots of optimizations.
1998-06-17 16:38:24 +00:00
6e9e901bcd
Changed PaintChildren() to only paint those children that intersect
...
the dirty rect
1998-06-14 00:45:21 +00:00
df525f7de0
some tentative steps towards content/frame separation in tables
1998-06-11 00:13:18 +00:00
71d5fd1025
sync up to new style data apis
1998-06-05 06:09:09 +00:00
karnaze%netscape.com
bernd.mielke%snafu.de
hyatt%netscape.com
timeless%mac.com
rbs%maths.uq.edu.au
pierre%netscape.com
rods%netscape.com
mcafee%netscape.com
buster%netscape.com
warren%netscape.com
peterlubczynski%netscape.com
alecf%netscape.com
dbaron%fas.harvard.edu
jdunn%netscape.com
troy%netscape.com
tbogard%aol.net
dmose%mozilla.org
kipp%netscape.com
brade%netscape.com
mjudge%netscape.com
wtc%netscape.com
joki%netscape.com
peterl%netscape.com
michaelp%netscape.com
troy
kipp
buster
peterl