dce353762e
Bug 336408 - Allow the caret to be positioned at the end of trimmed whitespace, as if the whitespace wasn't trimmed [p=roc r=smontagu sr=mrbkap a=blocking1.9+]
2007-11-08 04:07:00 +00:00
fef81552e6
Clean up prbool misuse in layout. bug 398312, r+sr+a=dbaron
2007-10-10 00:00:06 +00:00
001dc7f51c
remove XP_MAC usage. b=281889 r=cbarrett sr=roc a=roc
2007-10-01 23:20:38 +00:00
cdcd437255
Bug 390423 - Simplify the signature of nsIFrame::GetPointFromOffset, patch by Ben Karel <web+moz@eschew.org>, r=aaronlev/elif, sr=roc, a1.9=dbaron
2007-08-17 03:43:01 +00:00
0e649aa15e
Redragging over empty text field doesn't show drag caret, except for the last text field. bug 390228, r+sr=roc a=dbaron
2007-08-13 21:33:25 +00:00
fc86ba7f00
Clamp the caret's position so that we always draw within the nearest scrollframe. Not doing this allows the scrollframe to clip the caret, causing it to not show up at all. bug 335560, r+sr=roc
2007-08-13 20:51:16 +00:00
7781581f63
Fix for bug 387380 (No visible caret when caret browsing). r=smaug, sr=jst, a=dbaron.
2007-08-10 13:19:14 +00:00
cdbcbdeb35
Bug 390740: Pass lang-group into GetMetricsFor more consistently (general patch). r+sr=roc, a=dbaron
2007-08-07 19:07:44 +00:00
ef68fcf595
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 07:08:56 +00:00
b188226d8f
Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking.
2007-06-28 02:48:22 +00:00
3aef5b4f41
Backing out to fix orange.
2007-06-27 23:21:09 +00:00
c08e0c73cb
Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking.
2007-06-27 22:29:54 +00:00
199d4d164d
Bug 370379: Create views less frequently. Stops creating views for -moz-hidden-unscrollable, opacity, fixed backgrounds, and scrollbars, plus removes some unneeded methods from views and view managers. r+sr=roc.
2007-02-24 00:23:42 +00:00
c78720aa24
Bug 177805: Fix the use of units in Gecko. r+sr=roc
2007-02-07 07:46:44 +00:00
0c24c4a4c3
Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128
2007-01-30 00:06:41 +00:00
f74ad021dc
Bug 233348: BiDi marker is hidden when the caret is at the edge of a textarea. Patch by Haamed Gheibi <gheibi@gmail.com>. r=mrbkap sr=roc
2006-11-01 18:31:42 +00:00
58e29c5cff
Refactor nsIFrame::PeekOfset to use iteration instead of recursion, plus some more related refactoring. bug=300131 r+sr=roc
2006-09-11 20:43:01 +00:00
63dc4e2947
Backing out bug 300131 until I figure out how to deal with the bustage.
2006-09-11 08:03:28 +00:00
1b4975fbeb
Refactor nsIFrame::PeekOfset to use iteration instead of recursion, and some related refactoring. bug=300131 r+sr=roc
2006-09-11 06:39:56 +00:00
0873327099
Moved mCaretBidiLevel and its accessors from nsPresShell to nsFrameSelection. Also added sBidiKeyboard as a static service to nsContentUtils. bug=346891 r+sr=roc
2006-08-08 05:14:52 +00:00
6365be0e90
Enable PeekOffset to find the visual beginning/end of a line, and use use it for bidi caret positioning. bug=302051 r=smontagu sr=roc
2006-08-03 06:24:11 +00:00
4684a1ddda
Bug 345371: add null checks for weak pointers in nsCaret. r+sr=roc.
2006-07-20 23:26:05 +00:00
596fb2c114
Only display a bidirectional caret on platforms that implement nsIBidiKeyboard. Bug 272096, r+sr=roc
2006-07-06 08:29:53 +00:00
64166325ef
Only recalculate the caret's rect when we're not currently drawn in an attempt to avoid caret turds when we're being notified of the caret movement after the frame has already been marked dirty. bug 335834, r+sr=roc
2006-05-04 00:05:22 +00:00
60b3288089
Update the caret position after reflows to avoid turds. bug 334649, r+sr=roc
2006-04-28 04:33:41 +00:00
d23fe29f4c
Bug 330305. Rename nsSelection to nsFrameSelection, and deCOMtaminate it, removing nsIFrameSelection. patch by Marc Liddell, r+sr=roc
2006-04-26 01:57:22 +00:00
97d5c65b7b
Make the caret paint in the same color as the foreground so it's not always painted black. bug 334635, r+sr=roc
2006-04-21 19:13:58 +00:00
cfb04e2527
Draw the caret in the normal path of frame painting instead of doing it directly to the current view. bug 287813, r+sr=roc
2006-04-17 23:16:46 +00:00
8b90a8ebf4
One-line descriptions of files, partly because they show up in LXR.
2006-03-30 05:56:38 +00:00
4c05ba4736
In nsTextEditRules::CheckBidiLevelForDeletion(), use nsSelection::GetPrevNextBidiLevels to determine bidi levels. bug=330460 r=smontagu sr=roc
2006-03-23 08:20:29 +00:00
31ce373202
Bug 305798: Bidi: After deleting last character of reverse-direction text, arrow keys move caret incorrectly. Patch by Uri Bernstein <uriber@gmail.com, r=smontagu, sr=roc
2005-11-16 09:37:01 +00:00
23a8fc37a5
Bug 311399, Crash [@ SetOrigin] during rendering context destruction. Remove QD save/restore from rendering context, it was placed there as a workaround for scrollbar functional and aesthetic bugs. Add OS event handler to fix aesthetic problems, and check for bad states to work around functional problems. r=josh sr=smfr
2005-11-10 03:46:52 +00:00
418b11e331
Bug 313918 IME candidate list is positioned to wrong position if the caret is positioned non-root view r+sr=roc
2005-10-29 12:43:51 +00:00
41f7b1ac4a
Bug 311152. Make DOM selection changes repaint the caret in the new position. r=mrbkap,sr=dbaron
2005-10-12 18:40:38 +00:00
839cc756d5
Bug 193316. Caret not visible in readonly fields (HTML or XUL). r=mrbkap, sr=smfr
2005-10-04 03:14:03 +00:00
98ee62a50a
Caret drawn at incorrect position after typing a single LTR character in a blank RTL input field (or vice versa) while caret is visible. b=307533 r=uriber sr=bzbarsky
2005-09-10 11:14:48 +00:00
24bc2f5eea
bug 303399: Bidi: Problems with caret positioning on blank lines. Patch by Uri Bernstein <uriber@gmail.com>. r=mrbkap sr=roc
2005-08-24 17:44:28 +00:00
2f49f7bb2a
Erase caret if needed when content is removed. b=304383 r=mrbkap sr=bzbarsky
2005-08-22 00:25:20 +00:00
6e51772951
Don't use a Frame pointer to remember where we last painted the caret, instead use Content+offset+hint. b=296464 r=mrbkap sr=roc a=cbeard
2005-08-11 03:44:16 +00:00
373d7db1ba
Windows CE build changes. This addresses most of the outstanding Windows
...
CE compilation issues.
This patch also fixes/removes CheckStackGrowthDirection assertions in
Javscript. This change is based on bug 242518. See comment 36.
This patch also removes the unused enum in transformiix . See bug
292118.
r/sr = dveditz/shaver
b = 291229
a = asa
2005-04-29 13:33:49 +00:00
c410f2fe3f
Account for the view's origin not lining up with the widget's. b=190290 r=bzbarsky sr=roc
2005-03-26 14:50:09 +00:00
3ef2e416b4
Fix crashes in GTK1 builds due to reuse of rendering contexts for the caret.
...
Bug 254049, patch by Mark Banner <mark@standard8.demon.co.uk>, r=jst, sr=roc
2005-02-01 21:19:05 +00:00
56a6d2bc54
Remove nsIAutoCopy and fold the functionality into nsSelection.cpp (bug 231343). r+sr=roc.
2005-01-31 23:47:26 +00:00
ef4604f958
remove unused prescontext argument from GetOffsetFromView bug 276015 r/sr=dbaron
2004-12-26 19:48:54 +00:00
65e7b883f1
Prevent the right-to-left directional hook from overlapping the caret and make both directions thinner. Bug 264903, r=mkaply, aaronleventhal, sr=rbs.
2004-11-30 19:28:00 +00:00
d13fb54f7e
Don't use QueryInterface to get a scrollable view from a view b=258521 r+sr=roc
2004-11-24 00:19:21 +00:00
6bdf5c1fed
Try landing the fix for infamous Bug #98564 again -->
...
caret overlaps the last character in textfield (if positioned after the last char)
r=smontagu
sr=sfraser
We think this patch can land again because the regression it introduced was fixed by
Bug #216101 which does a better job of clearing out caret fragments.
2004-11-10 07:14:08 +00:00
120611ee77
Fixing bustage
2004-10-13 02:24:38 +00:00
24eabf40af
Bug 261054. Make caret consistently the same width throughout Gecko/Mozilla. Configurable through ui.caretWidth. r=glazou, sr=rbs
2004-10-13 01:12:14 +00:00
1c346b8beb
Don't use QueryInterface to get a view from a scrollable view b=258521 r+sr=roc
2004-09-20 22:25:07 +00:00
a8153addf4
More nsIPresShell deCOMtamination:
...
- Made Get/SetAuthorStyleDisabled and ReconstructStyleData non-virtual when called internally.
- Inlined GetFrameSelection and renamed it to FrameSelection.
- Removed non-inline version of GetViewManager.
- Removed unused EnablePrefStyleRules and ArePrefStyleRulesEnabled.
Bug 253889, r+sr=roc.
2004-08-29 03:08:44 +00:00
efcc221ee4
Remove refcounting version of nsIPresShell::GetPresContext. Bug 253889, r+sr=roc.
2004-08-20 20:34:37 +00:00
cc807b07b1
Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
2004-07-31 23:15:21 +00:00
ae5e2bdd51
Bug 241507
...
Don't create new rendering contexts for each caret drawn on *nix platforms since there are no known issues with doing so. If issues crop up, I will undo this change.
r/sr=jst/bryner
2004-06-29 19:12:19 +00:00
a01946be7b
Bug 216101 Cleaing frame refs can leave caret fragments p=mnyromyr@tprac.de r/sr=roc
2004-06-25 09:57:35 +00:00
4451888110
Get rid of nsILanguageAtom and deCOMtaminate nsILanguageAtomService (bug 230603). Also, fix a bunch of atom double-addref leaks in nsFontMetricsXlib. r+sr=dbaron.
2004-06-08 23:53:59 +00:00
c9791928b9
DeCOMtaminate nsIFrame Set/GetProperty and merge Set/GetBidiProperty with it. Bug 117751, r+sr=roc
2004-06-01 06:20:16 +00:00
11ed77ad8f
bullet proofing (wall paper) fix for top crasher bug #243294
...
now we just assert, instead of crash. see bug #245055 about the real problem.
Crash [@ nsCaret::GetViewForRendering] when printing a schedule from www.matkahuolto.info
r/sr=roc
2004-05-29 19:57:00 +00:00
85ce8c146b
Bug 236613: change to MPL/LGPL/GPL tri-license.
2004-04-18 14:30:37 +00:00
bd2796f514
Bug 240274 - remove PopState() argument. r=blizzard, sr=bryner
2004-04-18 13:13:35 +00:00
62c142565c
More nsIPresContext deCOMtamination (bug 229371). r+sr=roc.
2004-04-13 00:28:44 +00:00
d4f13c3ba7
Inline getters and setters for scaling factors on nsIDeviceContext. Bug 233103, r+sr=dbaron.
2004-02-05 01:57:10 +00:00
05a0e4f624
Guarantee that the pres context's device context will be non-null by returning failure from Init() if it's null. Rename inline getter GetDeviceContext() to DeviceContext(), convert all callers to use the inline getter, and remove the virtual/refcounting getter. Bug 229371, r+sr=dbaron.
2004-02-02 22:17:21 +00:00
290494e26b
Continuing nsIPresContext deCOMtamination (bug 229371). Remove GetImageLoadFlags (unused). Make failure to fetch the LookAndFeel service cause Init() to fail, don't null check it after that, and inlined the getter. Move IOService caching to nsImageFrame, the only user of it. r+sr=bzbarsky.
2004-01-21 09:35:59 +00:00
5381098212
Bug #226325 --> Back out the fix for Bug #98564 as this opened us up to a regression where trailing stationary caret remnant left after backspace.
...
a=asa for 1.6b
2003-12-03 20:32:47 +00:00
9a7c8f026b
Bug #98564 --> caret overlaps the last character in textfield (if positioned after the last char).
...
Patch written by kin.
r=smontagu
sr=sfraser
2003-11-16 07:08:55 +00:00
86ad399c4f
Fix build on gcc 3.4 by removing extra semicolons (bug 218551). r/sr=dbaron, a=brendan.
2003-09-07 22:37:27 +00:00
f1efc20ae6
Bug 213602: Switch some users of NS_GetWeakReference over to do_GetWeakReference. r=bzbarsky, sr=dbaron
2003-07-25 19:06:59 +00:00
f008bc2bad
Bug 25886: Get rid of a bunch of unused NS_DEFINE_IID, NS_DEFINE_CID. r=caillon, sr=dbaron
2003-07-20 07:47:59 +00:00
6739b8a3b5
Ongoing deCOMtamination. r+sr=dbaron
2003-07-02 10:30:00 +00:00
eb79de1241
Bug 204005: optimize caret timer usage
...
r=sfraser sr=brendan
2003-05-26 07:03:29 +00:00
9bff1b2bc4
Bug 206165 Unused variable `PRBool aCanCacheFrameOffset' in nsCaret::GetCaretRectAndInvert
...
r=sfraser sr=sfraser
2003-05-23 22:24:37 +00:00
a15b9f2cf4
Clean up API (and its callers) for getting style data: remove unneeded null checks and switch to new inline member functions (one for each struct) that return values. b=197205 r+sr=roc a=brendan
2003-05-15 03:42:21 +00:00
78f946e42d
Bug 199412: optimize nsTypedSelection::ScrollIntoView r/sr=sfraser
2003-04-20 01:03:40 +00:00
371e22d05f
Patch for bug 35296:SetCaretEnabled() takes too long
...
r/sr=sfraser
2003-04-13 08:38:57 +00:00
b7df6947aa
Patch for bug 35296: SetCaretEnabled() takes too long
...
Patch by Leon.Zhang@sun.com
r=sfraser, sr=kin
2003-04-02 05:48:09 +00:00
0fce5c3a3b
Fix bug 74404: show caret drag feedback. r=brade, sr=kin
2003-02-27 23:09:51 +00:00
0f853ce268
Fix for regression bug 194774 (cursor appears to "jump" to beginning of line after hitting backspace)
...
Checking in this work around for leon.zhang@sun.com . Comment out the code that sets mCachedOffsetValid to PR_TRUE. This effectively disables the fix for bug 35296.
r=brade@netscape.com sr=sfraser@netscape.com a=leaf@mozilla.org
2003-02-25 18:10:35 +00:00
112b5683e2
Bug 35296: SetCaretEnabled() takes too long
...
Patch by Leon.Zhang@sun.com , r/sr=sfraser
2003-02-24 10:26:20 +00:00
b9b898a7ea
remove '#ifndef REPEATING_TIMERS' code. This was accidentally turned back on in 9/02 after being dead from 12/01, and will now revert to using repeating timers. Affect caret, <blink>, bookmarks & search 'ping'. bug 182141, r+sr=smfr
2003-01-20 04:26:17 +00:00
b08ebfec8f
Caret not displayed in empty right-aligned text input fields. Bug 105397, r=kin, sr=sfraser.
2003-01-09 01:01:38 +00:00
72b937ea79
Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag
2003-01-08 21:07:51 +00:00
c3e3447b52
Re-landing these because I don't believe this are responsible for the Txul spike.
...
Bug 181975 - Convert layout to use nsIPrefService, nsIPrefBranch, and friends.
r/sr=roc+moz
2002-12-11 14:05:41 +00:00
7ca2c28686
Backing out these changes since they appear to have caused a Txul regression on some tinderboxes (not all... weird...)
2002-12-11 05:11:02 +00:00
28a20c3eb6
Bug 181975 - Convert layout to use nsIPrefService, nsIPrefBranch, and friends.
...
r/sr=roc+moz
2002-12-10 23:41:12 +00:00
04d1861bb8
Bug 166791. Invisible insertion point after tabbing to text field when typeaheadfind is active. r=mjudge, sr=alecf
2002-09-26 00:07:53 +00:00
c5e8f896cd
166917. Clean up xpcom SDK includes. r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com
2002-09-07 17:13:19 +00:00
d94b37c68a
Fixes up the timer interface. b157136, r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com
2002-09-07 05:38:16 +00:00
50c6f53d6c
4302 r=jfrancis sr=kin. pageup/down bug with navigation.
2002-08-26 20:55:30 +00:00
44112f97df
Bug 158754. Allow type ahead find to change selection color, and show caret with selection. r=akkana, sr=jst
2002-08-10 08:15:30 +00:00
e634b069e0
Bug 153196. Active Accessibility: support MSAA caret object and events. r=kyle, sr=kin
2002-06-25 22:54:23 +00:00
6197948cc3
bug 115473 r=pavlov sr=brendan
...
Remove timer priorities
2002-06-11 20:47:04 +00:00
7f123711f0
#142562 problem with <td align=right or align=center
...
We are observing langGroup in some place while ignor it in others. This patch
make all font metrics call consistent. nsIRenderingContext API is change to
make things neat.
r=rbs, sr=waterson
2002-05-24 20:11:14 +00:00
5f64567c97
Fix for bug 135154 (Cursor not appearing in textarea after tabbing into it)
...
Don't call StopBlinking() if the selection changed notification is
for a selection that is different from the one in mDomSelectionWeak.
r=akkana@netscape.com sr=attinasi@netscape.com
2002-04-26 13:11:47 +00:00
4655fdd163
82151 r=jfrancis sr = kin
2002-04-16 02:42:09 +00:00
05ff2775f2
Fix for 129893, cocoa changes to gfx/layout/view, r=pink, sr=ben
2002-04-12 02:05:12 +00:00
5556328edb
Tweak XP_MACOSX ifdefs to fix keyboard shortcuts (partly), context menus, and hidden window behavior and build the mac classic skin in the Mach-O build. b=109165 r=pinkerton sr=beard
2001-11-10 23:30:13 +00:00
75d32bb579
Bug 86947:
...
Make the line list doubly linked and access it through a list class and iterators.
Stop recomputing margins on all of the children of each block in the reflow chain (which causes O(N^2) state recovery during incremental reflow). Instead, add a second dirty bit to the lines and walk backwards through the line list to recompute vertical margins only when either dirty bit is set and the previous line was not reflowed. Add nsIFrame::IsEmpty to identify frames through which margins collapse.
Fix O(N^2) propagation of float damage by maintaining a set of intervals damaged by floats (bug 61962) and be sure to damage the correct areas (bug 48138).
Introduce nsCollapsingMargin to do correct collapsing of combinations of positive and negative margins (bug 50142).
Clean up some odds and ends and fix another smaller O(N^2) problem in nsBlockFrame::AddFrames.
r=attinasi, rbs sr=waterson
2001-10-25 01:08:40 +00:00
6979218b43
#79798
...
r=ftang, sr=kin@netscape.com
Cursor is an ambigous term - use caret to refer to the text caret in Bidi functions
2001-09-30 20:35:55 +00:00
f385eb981a
Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089.
2001-09-28 20:14:13 +00:00
reed%reedloden.com
tglek%mozilla.com
joshmoz%gmail.com
philringnalda%gmail.com
mrbkap%gmail.com
peterv%propagandism.org
sharparrow1%yahoo.com
jwalden%mit.edu
cvshook%sicking.cc
uriber%gmail.com
smontagu%smontagu.org
roc+%cs.cmu.edu
dbaron%dbaron.org
mark%moxienet.com
masayuki%d-toybox.com
aaronleventhal%moonset.net
mats.palmgren%bredband.net
dougt%meer.net
bzbarsky%mit.edu
bryner%brianryner.com
bmlk%gmx.de
neil%parkwaycc.co.uk
scott%scott-macgregor.org
caillon%redhat.com
sspitzer%mozilla.org
gerv%gerv.net
tor%cs.brown.edu
jaggernaut%netscape.com
leon.zhang%sun.com
timeless%mozdev.org
henry.jia%sun.com
sfraser%netscape.com
kin%netscape.com
jrgm%netscape.com
smontagu%netscape.com
caillon%returnzero.com
aaronl%netscape.com
dougt%netscape.com
mjudge%netscape.com
cbiesinger%web.de
shanjian%netscape.com
hyatt%netscape.com
dbaron%fas.harvard.edu
mkaply%us.ibm.com